summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-05-30Codechange: [Network] Let server rcon result use std::stringrubidium42
2021-05-30Codechange: [Network] Let server changing a client name use std::stringrubidium42
2021-05-29Codechange: use setting name instead of index for CmdChange(Company)Setting ↵Patric Stout
(#9306) This is mostly done as there are now constraints on settings.ini you might not expected. For example, conditional settings always have to come last, as otherwise they would influence the index.
2021-05-29Codechange: Rename window related DeleteXXX to match new behaviourglx22
2021-05-29Fix f6d5c01: Delay deletion when closing windowsglx22
2021-05-29Codechange: [Network] Use std::string in CommandPacketrubidium42
2021-05-29Codechange: move from C-string to std::string for DoCommandrubidium42
2021-05-29Codechange: let IsUnique.* functions accept std::stringrubidium42
2021-05-29Codechange: add std::string variant of Utf8StringLengthrubidium42
2021-05-29Fix: Do not send vehicles towards incomplete PF nodesVít Šefl
YAPF could end up in a situation where it sets the best intermediate node to a node whose construction is never finalized (i.e. it is never added to the open list). The content of the node would be overwritten in the next round, potentially sending the vehicle to an unwanted location.
2021-05-29Codechange: move casting a "const char *" to "char *" to the callerPatric Stout
It is not nice to have your definition say you won't change a value while in fact the whole reason for your existance is to change it.
2021-05-29Fix: ScriptObject::DoCommand could modify "text" while defined "const"Patric Stout
This could have unwanted side-effects, as it could change the source for ever and ever.
2021-05-29Doc: describe what each settings-file is aboutPatric Stout
2021-05-29Codechange: move all settings.ini files to table/settingsPatric Stout
2021-05-29Codechange: rename str_validate to StrMakeValid(InPlace) (#9304)Patric Stout
This to be more explicit the function changes the value, and not returns yes/no.
2021-05-29Fix #9281: acquire a company uses special bookkeeping to make you rich (#9300)Patric Stout
When you buy-out a company, you got your shares back. This is based on company-value, which includes values for the vehicles etc. In other words, you not only got the vehicles, but you also got paid to get them back. Additionally, you also got the loan of the company, but not the money for the loan (as that is subtracted from the company-value). Solve this by changing the rules of a buy-out: don't sell your shares, get the loan AND the balance and get the infrastructure.
2021-05-29Cleanup: set the base in the setting templates, instead of defining the base ↵rubidium42
for every setting This has the added benefit of not getting mistaken that multiple bases can be used for the same SettingTable
2021-05-29Fix: [Network] Prevent an empty server name to be set anywhererubidium42
2021-05-29Codechange: use separate pre and post callbacks for int settingsrubidium42
2021-05-29Codechange: use separate pre and post callbacks for string settingsrubidium42
2021-05-29Codechange: split Write_ValidateSetting to get separate functions for making ↵rubidium42
ints valid and writing ints
2021-05-29Codechange: split Write_ValidateSetting to get separate functions for making ↵rubidium42
strings valid and writing strings
2021-05-28Update: Translations from eintstranslators
norwegian (bokmal): 3 changes by Anolitt dutch: 3 changes by Afoklala portuguese (brazilian): 3 changes by Vimerum
2021-05-27Update: Translations from eintstranslators
chinese (traditional): 9 changes by benny30111 english (us): 3 changes by 2TallTyler
2021-05-27Change: by default, make "unload all" leave stations empty (#9301)Patric Stout
2021-05-27Codechange: add helper functions to read an int setting valuerubidium42
2021-05-27Codechange: remove SettingDescType in lieu of the actual classesrubidium42
2021-05-27Codechange: let OneOfMany and ManyOfMany be their own classes as wellrubidium42
2021-05-27Codechange: make BoolSettingDesc its own sub classrubidium42
2021-05-27Cleanup: remove unneeded temporary variables and castsrubidium42
2021-05-27Codechange: move bits of SettingDesc down to the appropriate sub classesrubidium42
And by doing so remove the hack where ints were put into pointers so "def" could either be an int or a string
2021-05-27Codechange: use IntSettingDesc in the settings GUIrubidium42
2021-05-27Codechange: make parsing of IniItems overridable functions of SettingDescrubidium42
2021-05-27Codechange: make Write_ValidateSetting a function of StringSettingDescrubidium42
2021-05-27Codechange: make Write_ValidateSetting a function of IntSettingDescrubidium42
2021-05-27Cleanup: use (config) formatting for console settings functionsrubidium42
2021-05-27Codechange: make formatting of values into strings a method of SettingDescrubidium42
2021-05-27Codechange: make sub classes of SettingDesc for the different types of settingsrubidium42
2021-05-27Codechange: make SettingDesc an instance in the setting table to allow for ↵rubidium42
sub classes
2021-05-27Codechange: do not use SettingDescBase directly when not neededrubidium42
2021-05-27Codechange: use initializer_lists for the settings tablesrubidium42
Not using vectors as those require copying from the initializer list and that makes unique_ptrs to the actual SettingDesc objects later impossible.
2021-05-27Codechange: let SettingDesc extend SettingDescBaserubidium42
2021-05-27Cleanup: remove and/or fix some confusing commentsrubidium42
The comments for SettingDescType; it is a byte, so not 4 bytes and since it is not a flag there are about 250 other possibilities left instead of 9. SettingGuiFlag is uint16 so has 2 bytes allocated. SettingDescGlobVarList and related comments imply that global vars cannot be used elsewhere, but they are used for settings just fine. Even then the type is not used anywhere else but the definition of the table.
2021-05-27Codechange: just pass the SettingDesc to SetSettingValue and remove ↵rubidium42
distinction between (non)company
2021-05-27Change: mark copy-assignment as deleted for classes with a copy-constructor ↵rubidium42
that is not trivial This to prevent the default copy-assignment getting used when during the assignment also some other memory needs to be allocated as that would otherwise be freed.
2021-05-27Cleanup: remove unused copy-constructor without copy-assignmentrubidium42
2021-05-27Codechange: linkgraph always iterates with NodeIDs over the Size(), so make ↵rubidium42
Size() the same type to prevent infinite loops
2021-05-27Cleanup: remove dead code; ++ on ostreambuf_iterator is a no-oprubidium42
2021-05-27Codechange: remove unneeded comparison and castsrubidium42
Division by resize_y is already yielding an unsigned number, so when clicking in the WD_FRAMERECT_TOP you would already get a huge value, so sel would never be negative. So, leave sel an unsigned number and remove the <= check.
2021-05-27Codechange: pass large parameter by reference instead of value, especially ↵rubidium42
in a recursive function