diff options
| author | Patric Stout <truebrain@openttd.org> | 2021-04-20 16:34:14 +0200 |
|---|---|---|
| committer | Patric Stout <github@truebrain.nl> | 2021-04-20 17:34:04 +0200 |
| commit | cd757d53cae20e2f330f0905ec7797ca1a0f8f00 (patch) | |
| tree | c11c77f54cf48ee6a365954bd662a20c2c437e18 /src/network | |
| parent | 31897eaa7de865d41b46f7158c70f94debe1ec66 (diff) | |
| download | openttd-cd757d53cae20e2f330f0905ec7797ca1a0f8f00.tar.xz | |
Codechange: remove always-empty "address" from NetworkContentSocketHandler
When ever you saw this debug lines (which you never should), they
showed an empty address. It is also not very useful to have, as it
always points to a known server anyway.
Diffstat (limited to 'src/network')
| -rw-r--r-- | src/network/core/tcp_content.cpp | 6 | ||||
| -rw-r--r-- | src/network/core/tcp_content.h | 6 |
2 files changed, 5 insertions, 7 deletions
diff --git a/src/network/core/tcp_content.cpp b/src/network/core/tcp_content.cpp index 6fb3b3379..55319e430 100644 --- a/src/network/core/tcp_content.cpp +++ b/src/network/core/tcp_content.cpp @@ -171,9 +171,9 @@ bool NetworkContentSocketHandler::HandlePacket(Packet *p) default: if (this->HasClientQuit()) { - DEBUG(net, 0, "[tcp/content] received invalid packet type %d from %s", type, this->client_addr.GetAddressAsString().c_str()); + DEBUG(net, 0, "[tcp/content] received invalid packet type %d", type); } else { - DEBUG(net, 0, "[tcp/content] received illegal packet from %s", this->client_addr.GetAddressAsString().c_str()); + DEBUG(net, 0, "[tcp/content] received illegal packet"); } return false; } @@ -224,7 +224,7 @@ bool NetworkContentSocketHandler::ReceivePackets() */ bool NetworkContentSocketHandler::ReceiveInvalidPacket(PacketContentType type) { - DEBUG(net, 0, "[tcp/content] received illegal packet type %d from %s", type, this->client_addr.GetAddressAsString().c_str()); + DEBUG(net, 0, "[tcp/content] received illegal packet type %d", type); return false; } diff --git a/src/network/core/tcp_content.h b/src/network/core/tcp_content.h index be1cc6e77..ef8ae3a10 100644 --- a/src/network/core/tcp_content.h +++ b/src/network/core/tcp_content.h @@ -95,7 +95,6 @@ struct ContentInfo { /** Base socket handler for all Content TCP sockets */ class NetworkContentSocketHandler : public NetworkTCPSocketHandler { protected: - NetworkAddress client_addr; ///< The address we're connected to. void Close() override; bool ReceiveInvalidPacket(PacketContentType type); @@ -193,9 +192,8 @@ public: * @param s the socket we are connected with * @param address IP etc. of the client */ - NetworkContentSocketHandler(SOCKET s = INVALID_SOCKET, const NetworkAddress &address = NetworkAddress()) : - NetworkTCPSocketHandler(s), - client_addr(address) + NetworkContentSocketHandler(SOCKET s = INVALID_SOCKET) : + NetworkTCPSocketHandler(s) { } |