summaryrefslogtreecommitdiff
path: root/src/network
diff options
context:
space:
mode:
authorPatric Stout <truebrain@openttd.org>2021-05-11 12:32:27 +0200
committerGitHub <noreply@github.com>2021-05-11 12:32:27 +0200
commit9e7e87ce3e7a7a4f5373883550c6f05a5d023ab6 (patch)
tree4ca56632dba0b0e62c68db9765ecb0ab77b94f30 /src/network
parent9841ebb0bd6531b4ac1474c4c35103d12b8eeb43 (diff)
downloadopenttd-9e7e87ce3e7a7a4f5373883550c6f05a5d023ab6.tar.xz
Fix: [Network] don't rebuild the host-list during iterating the list (#9240)
Additionally, only rebuild it when we added a new manual server, as otherwise it is a noop anyway.
Diffstat (limited to 'src/network')
-rw-r--r--src/network/network.cpp1
-rw-r--r--src/network/network_gui.cpp1
2 files changed, 1 insertions, 1 deletions
diff --git a/src/network/network.cpp b/src/network/network.cpp
index 2186cb8a1..29e66d932 100644
--- a/src/network/network.cpp
+++ b/src/network/network.cpp
@@ -701,7 +701,6 @@ NetworkGameList *NetworkAddServer(const std::string &connection_string, bool man
ClearGRFConfigList(&item->info.grfconfig);
item->info.server_name = connection_string;
- NetworkRebuildHostList();
UpdateNetworkGameWindow();
NetworkQueryServer(connection_string);
diff --git a/src/network/network_gui.cpp b/src/network/network_gui.cpp
index 2df40eeec..35597fa04 100644
--- a/src/network/network_gui.cpp
+++ b/src/network/network_gui.cpp
@@ -830,6 +830,7 @@ public:
if (!StrEmpty(str)) {
strecpy(_settings_client.network.connect_to_ip, str, lastof(_settings_client.network.connect_to_ip));
NetworkAddServer(str);
+ NetworkRebuildHostList();
}
}