summaryrefslogtreecommitdiff
path: root/maint.mk
AgeCommit message (Collapse)Author
2009-04-04tests: tweak po_check syntax checkJim Meyering
* maint.mk (sc_po_check): Don't let dangling lib/*.[ch] links cause spurious "grep: lib/file.h: No such file or directory" warnings.
2009-04-04tests: improve ChangeLog syntax checkJim Meyering
* maint.mk (sc_changelog): Use $(VC_LIST_EXCEPT), not find. Don't hang when there are no ChangeLog files. (sc_require_config_h): For the file-name-filter, use grep -l to be slightly more efficient. (sc_require_config_h_first, _header_without_use, sc_program_name): Likewise.
2009-04-04tests: make syntax-checks more robustRalf Wildenhues
* maint.mk (_prohibit_regexp): Add ';' at end of ':'-introduced comment so that the comment doesn't gobble up the following test for a missing regexp definition. (_header_without_use): Escape all '.'s in a header file name, not just the first one.
2009-03-25tests: don't fail "make syntax-check" on cygwinJim Meyering
* maint.mk (NEWS_hash): Remove trailing " -" or " *-". * cfg.mk (old_NEWS_hash): Regenerate, removing " -". Reported by Eric Blake.
2009-03-21tests: search only files that are under version controlJim Meyering
* maint.mk (sc_error_exit_success): Search only files that are under version control. (sc_makefile_path_separator_check): Likewise. Check *.mk files, too, not just Makefile.am files.
2009-03-21tests: follow own advice: use $(PATH_SEPARATOR), not ":"Jim Meyering
* maint.mk (coreutils-path-check): Use the variable, not the literal.
2009-03-21tests: modernize: use $(var) makefile notation, not @var@Jim Meyering
* maint.mk (sc_makefile_path_separator_check): Recommend the use of $(PATH_SEPARATOR), not @PATH_SEPARATOR@. Remove an obsolete comment.
2009-03-18maint: normalize leading-TAB indentation in MakefilesJim Meyering
* maint.mk (sc_makefile_TAB_only_indentation): New rule. Replace each TAB+8-space sequence with two TABs. * man/Makefile.am: Likewise. * build-aux/check.mk: Likewise. I used this command (run it more than once, if needed): t=$'\t'; git grep -l -E "$t {8}"|grep -E 'Makefile|\.mk$' \ | xargs perl -pi -e 's/\t {8}/\t\t/'
2009-03-06maint: remove spurious case-ignoring option from a testJim Meyering
* maint.mk (sc_trailing_blank): Remove useless/harmless ignore_case=1.
2009-03-03maint: improve release-related process and documentationJim Meyering
* README-release: Fix typo. it's "maintainer-clean". Refer to HACKING for full list of dependencies. Use cvs add's -ko option to inhibit $Id$-style keyword expansion. * maint.mk (web-manual): Factor out definition of $(manual_title). (vc-dist): Set XZ_OPT=-9ev for the final "make dist". * cfg.mk (manual_title): Define it here. Suggestions from Eric Blake.
2009-03-02dist: automate the post-release web-manual update processJim Meyering
* maint.mk (web-manual): New rule, from m4's maint.mk. * bootstrap.conf (gnulib_modules): Add gendocs.
2009-03-02dist: do not emit MD5 or SHA1 checksums into announcement templateJim Meyering
* maint.mk (announcement): Use announce-gen's new --no-print-checksums.
2009-02-28maint: detect unnecessary inclusion of signal.hJim Meyering
* maint.mk (sc_prohibit_signal_without_use): New rule.
2009-02-18maint: changing NEWS' copyright date must not invalidate checksumJim Meyering
* maint.mk (NEWS_hash): Don't let the Copyright date line contribute to the checksum. * cfg.mk (old_NEWS_hash): Update to reflect the new policy.
2009-02-02maint: tighten atoi/atof-prohibiting regexp, clean up .x-sc- fileJim Meyering
* maint.mk (sc_prohibit_atoi_atof): Require "(" after token. * .x-sc_prohibit_atoi_atof: Remove names that no longer contain a match.
2009-02-02* maint.mk (sc_redundant_const): Use $(_prohibit_regexp).Jim Meyering
2009-01-31maint: detect useless inclusion of c-ctype.hJim Meyering
* maint.mk (sc_prohibit_c_ctype_without_use): New rule.
2009-01-29maint: teach "make syntax-check" to print each check name as it's runJim Meyering
* maint.mk (%.m): New rules to print each syntax-checking rule name, just before running its commands. ($(syntax-check-rules)): Depend on it.
2009-01-29maint: factor syntax-check rulesJim Meyering
* maint.mk (_ignore_case): New macro. (_prohibit_regexp): Use it. Factor many existing syntax-check rules to use $(_prohibit_regexp).
2009-01-26tests: generalize install-transform-checkJim Meyering
* maint.mk (install-transform-check): Generalize to work also in a project that installs manuals in a section other than "1".
2009-01-16maint: remove obsolete sc_author_mark_check ruleJim Meyering
* maint.mk (sc_author_mark_check): Remove rule. "and" no longer appears in the definition of AUTHORS.
2009-01-16maint: enforce existing prohibition: no cvs $keywords$Jim Meyering
* maint.mk (sc_prohibit_cvs_keyword): New rule.
2009-01-07* maint.mk: align some backslashesJim Meyering
2009-01-01maint: factor out common code; prohibit use of HAVE_MBRTOWCJim Meyering
* maint.mk (_prohibit_regexp): New macro. (sc_avoid_if_before_free, sc_cast_of_argument_to_free): (sc_cast_of_x_alloc_return_value, sc_cast_of_alloca_return_value): (sc_space_tab, sc_prohibit_atoi_atof, sc_prohibit_strcmp): (sc_prohibit_stat_st_blocks, sc_prohibit_S_IS_definition): Use it. (sc_prohibit_HAVE_MBRTOWC): New rule.
2009-01-01maint: use more sc_-prefixed namesJim Meyering
* maint.mk (sc_po_check): Renamed from po-check. (sc_author_mark_check): Renamed from author_mark_check. (sc_copyright_check): Renamed from copyright-check. (sc_makefile_path_separator_check): Renamed from makefile_path_separator_check. (local-checks-available): Remove the old names. * Makefile.am (EXTRA_DIST): Reflect the renaming: .x-sc_po_check * .x-po-check: Rename to... * .x-sc_po_check: ...new file.
2009-01-01maint: tighten m4 AC_ quoting checkJim Meyering
* maint.mk (sc_m4_quote_check): Renamed from m4-check. Also search for AC_DEFINE and AC_DEFINE_UNQUOTED. Also search in configure.ac. * configure.ac: Quote first argument of AC_DEFINE. * jm-macros.m4 (coreutils_MACROS): Quote the first argument to AC_DEFINE.
2009-01-01maint: move coreutils-specific syntax check rules into cfg.mkJim Meyering
* maint.mk (sc_dd_max_sym_length, sc_prohibit_jm_in_m4): (sc_root_tests, sc_always_defined_macros, sc_system_h_headers): (sc_sun_os_names, sc_tight_scope, sc_no_exec_perl_coreutils): Move rules into cfg.mk. (sc_strftime_check): Renamed from strftime-check, and moved, too. * cfg.mk: Add the above rules.
2008-12-26maint: ensure dd's computation of O_FULLBLOCK uses all O_ symbol namesJim Meyering
* src/dd.c (O_FULLBLOCK): Use a more uniform initializer, that makes it easier to extract all O_ symbol names. * maint.mk (syntax-check-rules): Also search for sc_ rules in cfg.mk. (sc_root_tests): Ensure that this rule sets $diff. * cfg.mk (sc_dd_O_FLAGS): New rule.
2008-12-21maint.mk: enforce the "include <config.h> first" ruleJim Meyering
* maint.mk (sc_require_config_h_first): New rule. * .x-sc_require_config_h_first: New file.
2008-11-30build: don't reject definition of STREQJim Meyering
* maint.mk (sc_prohibit_strcmp): Tighten rule: exclude macro definitions like the one in system.h. * .x-sc_prohibit_strcmp: Don't exempt src/system.h.
2008-10-18* maint.mk (coreutils-path-check): New definition, now runJim Meyering
only if src/true.c exists. Factored out of... (my-distcheck): ...here.
2008-10-16build: when po-check fails, say why and suggest a fixJim Meyering
* maint.mk (po-check): Before, when this check failed, it just spat out a diff mentioning two temporary files. Now, it tells you what's wrong and suggests a fix with a patch using the name of the affected file (rather than temporary file names) in the diff output.
2008-10-12tests: move check-misc targets from src/Makefile.am to maint.mkJim Meyering
* src/Makefile.am (check): Remove check-misc. (check-misc): Remove target. * maint.mk (sc_prohibit_stat_st_blocks): New target. (sc_prohibit_S_IS_definition): New target. * Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_stat_st_blocks. * .x-sc_prohibit_stat_st_blocks: New file. Andreas Schwab reported that "make check" could fail to detect violation of the no-S_IS*-definition policy.
2008-10-05* maint.mk (alpha beta major): Add "-a" to git commit ... command.Jim Meyering
2008-09-27* maint.mk (my-distcheck): remove duplicate c99-related test codeJim Meyering
2008-09-26maint: relax a check so "make distcheck" succeeds againJim Meyering
* maint.mk (makefile-check): Relax the check, in order to exempt the necessary use of a sole @...@-delimited Makefile.am variable.
2008-09-24maint: avoid using find -name Makefile.am; could get false positivesJim Meyering
* maint.mk (makefile-check): Instead, search for the offending @...@ construct only in version-controlled files.
2008-09-14various VPATH-related fixesRalf Wildenhues
* maint.mk (VC_LIST): Prepend '$(srcdir)/'. (patch-check): Fix to make it work with a VPATH build. * src/Makefile.am (sc_tight_scope): Likewise. * man/Makefile.am (.x.1): Do not make outputs unwritable.
2008-09-13tests: reenable disabled test, now that automake can handle itJim Meyering
This reverts the change in ae1c205fc473589d028ef63785926263843555cd.
2008-09-11tests: temporarily disable part of "make distcheck"Jim Meyering
* maint.mk (install-transform-check): Temporarily disable.
2008-09-10tests: use "Exit $fail", not (exit $fail); exit $failJim Meyering
* tests/test-lib.sh (Exit): New function by Ralf Wildenhues in automake http://git.sv.gnu.org/gitweb/?p=automake.git;a=commitdiff;h=20594c08f63 * tests/**: Convert all uses: This restrictive change converted the vast majority: git grep -l '^(exit \$fail); exit \$fail$' \ | xargs perl -pi -e 's/'^\(exit \$fail\); exit \$fail$/Exit \$fail/' And this did the rest, plus a few undesirable ones, so I manually backed out the changes to ChangeLog-* and build-aux/check.mk: git grep -l -E '\(exit [^)]+\); exit ' \ | xargs perl -pi -e 's/\(exit (.+?)\); exit \1/Exit $1/'
2008-07-22tests: ensure "make check" w/tainted build dir no longer impacts $HOMEJim Meyering
* maint.mk (taint-distcheck): New rule. (maintainer-distcheck): Make it.
2008-06-26tests: adjust c99-to-c89 patch as well as the code to generate itJim Meyering
* maint.mk (patch-check) [REGEN_PATCH]: Trim some trailing blanks. * src/c99-to-c89.diff: Adjust shred.c offsets.
2008-06-26tests: fix make distcheck failure due to TODO changeJim Meyering
* maint.mk (po-check): Limit check for e.g., _(...)-marked messages to files matching *.? and *.??, thus excluding TODO and *.diff.
2008-06-20make "make syntax-check" quieterJim Meyering
* maint.mk (po-check, makefile-check, sc_proper_name_utf8_requires_ICONV): Add "@" prefix.
2008-06-17ls, od: avoid redundant constEric Blake
* src/ls.c (long_time_format, sort_functions): Avoid redundant const. * src/od.c (charname): Likewise. * maint.mk (sc_redundant_const): Add rule to detect this.
2008-06-16remove redundant const directivesJim Meyering
In 1463824d8e7f72c31f1d803d7cfe2b608ccafc5c, I added some missing "const" directives, as well as some new, redundant ones. This removes the redundant ones. Pointed out by Eric Blake. * base64.c, cat.c, chcon.c, chgrp.c, chmod.c, chown.c, comm.c: * cp.c, csplit.c, cut.c, date.c, dd.c, df.c, dircolors.c, du.c: * env.c, expand.c, fmt.c, fold.c, groups.c, head.c, id.c: * install.c, join.c, kill.c, ln.c, ls.c, md5sum.c, mkdir.c: * mkfifo.c, mknod.c, mktemp.c, mv.c, nice.c, nl.c, od.c: * paste.c, pathchk.c, pinky.c, pr.c, ptx.c, readlink.c, rm.c: * rmdir.c, runcon.c, seq.c, shred.c, shuf.c, sort.c, split.c: * stat.c, stty.c, su.c, sum.c, tac.c, tail.c, tee.c, timeout.c: * touch.c, tr.c, truncate.c, tty.c, uname.c, unexpand.c, uniq.c: * wc.c, who.c: Remove redundant const directives. * maint.mk (sc_const_long_option): Don't require redundant "const".
2008-06-14* maint.mk (sc_proper_name_utf8_requires_ICONV) Fix typo in diagnostic.Jim Meyering
2008-06-14add "const" attribute, where possibleJim Meyering
* maint.mk (sc_const_long_option): New rule. Enforce global change. * src/base64.c (long_options): Use "const" where possible. * src/cat.c (main): Likewise. * src/chcon.c (long_options): Likewise. * src/chgrp.c (long_options): Likewise. * src/chmod.c (long_options): Likewise. * src/chown.c (long_options): Likewise. * src/comm.c (long_options, OUTPUT_DELIMITER_OPTION): Likewise. * src/cp.c (long_opts): Likewise. * src/csplit.c (longopts): Likewise. * src/cut.c (longopts): Likewise. * src/date.c (long_options): Likewise. * src/dd.c (conversions, flags, statuses): Likewise. * src/df.c (long_options): Likewise. * src/dircolors.c (long_options): Likewise. * src/du.c (long_options): Likewise. * src/env.c (longopts): Likewise. * src/expand.c (longopts): Likewise. * src/fmt.c (long_options): Likewise. * src/fold.c (longopts): Likewise. * src/groups.c (longopts): Likewise. * src/head.c (long_options): Likewise. * src/id.c (longopts): Likewise. * src/install.c (long_options): Likewise. * src/join.c (longopts): Likewise. * src/kill.c (long_options): Likewise. * src/ln.c (long_options): Likewise. * src/ls.c (long_time_format, long_options, sort_functions): Likewise. * src/md5sum.c (long_options): Likewise. * src/mkdir.c (longopts): Likewise. * src/mkfifo.c (longopts): Likewise. * src/mknod.c (longopts): Likewise. * src/mktemp.c (longopts): Likewise. * src/mv.c (long_options): Likewise. * src/nice.c (longopts): Likewise. * src/nl.c (longopts): Likewise. * src/od.c (charname, long_options): Likewise. * src/paste.c (longopts): Likewise. * src/pathchk.c (longopts): Likewise. * src/pinky.c (longopts): Likewise. * src/pr.c (long_options): Likewise. * src/ptx.c (long_options): Likewise. * src/readlink.c (longopts): Likewise. * src/rm.c (long_opts): Likewise. * src/rmdir.c (longopts): Likewise. * src/runcon.c (long_options): Likewise. * src/seq.c (long_options): Likewise. * src/shred.c (long_opts): Likewise. * src/shuf.c (long_opts): Likewise. * src/sort.c (monthtab, long_options): Likewise. * src/split.c (longopts): Likewise. * src/stat.c (long_options): Likewise. * src/stty.c (mode_info, control_info, longopts, set_mode) Likewise. (set_control_char, speeds): Likewise. * src/su.c (longopts): Likewise. * src/sum.c (longopts): Likewise. * src/tac.c (longopts): Likewise. * src/tail.c (long_options): Likewise. * src/tee.c (long_options): Likewise. * src/timeout.c (long_options): Likewise. * src/touch.c (longopts): Likewise. * src/tr.c (long_options): Likewise. * src/truncate.c (longopts): Likewise. * src/tty.c (longopts): Likewise. * src/uname.c (uname_long_options, arch_long_options): Likewise. * src/unexpand.c (longopts): Likewise. * src/uniq.c (longopts): Likewise. * src/wc.c (longopts): Likewise. * src/who.c (longopts): Likewise.
2008-06-09enforce the proper_name_utf8-requires-ICONV link ruleJim Meyering
* maint.mk (sc_proper_name_utf8_requires_ICONV): New rule. * src/Makefile.am (timeout_LDADD, truncate_LDADD): Add $(LIBICONV).