summaryrefslogtreecommitdiff
path: root/maint.mk
diff options
context:
space:
mode:
authorJim Meyering <meyering@redhat.com>2009-03-21 09:56:00 +0100
committerJim Meyering <meyering@redhat.com>2009-03-21 09:58:32 +0100
commit1f95a450996aae2e99c02241f31ffd370db2e472 (patch)
tree98a877fdacfb25d400c82c9bfdfc2e20a2a9b9ce /maint.mk
parent143bfd67c97f255cdfcc629161cf5a2bc343aa65 (diff)
downloadcoreutils-1f95a450996aae2e99c02241f31ffd370db2e472.tar.xz
tests: modernize: use $(var) makefile notation, not @var@
* maint.mk (sc_makefile_path_separator_check): Recommend the use of $(PATH_SEPARATOR), not @PATH_SEPARATOR@. Remove an obsolete comment.
Diffstat (limited to 'maint.mk')
-rw-r--r--maint.mk7
1 files changed, 2 insertions, 5 deletions
diff --git a/maint.mk b/maint.mk
index 0c1ad24a6..17f0be83f 100644
--- a/maint.mk
+++ b/maint.mk
@@ -581,11 +581,8 @@ sc_po_check:
# Sometimes it is useful to change the PATH environment variable
# in Makefiles. When doing so, it's better not to use the Unix-centric
-# path separator of `:', but rather the automake-provided `@PATH_SEPARATOR@'.
-# It'd be better to use `find -print0 ...|xargs -0 ...', but less portable,
-# and there probably aren't many projects with so many Makefile.am files
-# that we'd have to worry about limits on command line length.
-msg = '$(ME): Do not use `:'\'' above; use @PATH_SEPARATOR@ instead'
+# path separator of `:', but rather the automake-provided `$(PATH_SEPARATOR)'.
+msg = '$(ME): Do not use `:'\'' above; use $$(PATH_SEPARATOR) instead'
sc_makefile_path_separator_check:
@grep -n 'PATH=.*:' `find $(srcdir) -name Makefile.am` \
&& { echo $(msg) 1>&2; exit 1; } || :