diff options
| author | Jim Meyering <meyering@redhat.com> | 2008-12-26 15:33:34 +0100 |
|---|---|---|
| committer | Jim Meyering <meyering@redhat.com> | 2009-01-01 02:15:07 +0100 |
| commit | cbecb8cab8ed0228acb4d86d2a0b1ffa6d7977fc (patch) | |
| tree | 96e1c38acdc48a5c277c42b84c4ea03d905de633 /maint.mk | |
| parent | fb992bae4c490dd00dbe1a55143e98efad87158b (diff) | |
| download | coreutils-cbecb8cab8ed0228acb4d86d2a0b1ffa6d7977fc.tar.xz | |
maint: tighten m4 AC_ quoting check
* maint.mk (sc_m4_quote_check): Renamed from m4-check.
Also search for AC_DEFINE and AC_DEFINE_UNQUOTED.
Also search in configure.ac.
* configure.ac: Quote first argument of AC_DEFINE.
* jm-macros.m4 (coreutils_MACROS): Quote the first argument to AC_DEFINE.
Diffstat (limited to 'maint.mk')
| -rw-r--r-- | maint.mk | 9 |
1 files changed, 5 insertions, 4 deletions
@@ -74,7 +74,7 @@ syntax-check-rules := $(shell sed -n 's/^\(sc_[a-zA-Z0-9_-]*\):.*/\1/p' \ .PHONY: $(syntax-check-rules) local-checks-available = \ - po-check copyright-check m4-check author_mark_check \ + po-check copyright-check author_mark_check \ patch-check $(syntax-check-rules) \ makefile_path_separator_check \ makefile-check check-AUTHORS @@ -473,9 +473,10 @@ changelog-check: exit 1; \ fi -m4-check: - @grep -n 'AC_DEFUN([^[]' m4/*.m4 \ - && { echo '$(ME): quote the first arg to AC_DEFUN' 1>&2; \ +sc_m4_quote_check: + @grep -nE '(AC_DEFINE(_UNQUOTED)?|AC_DEFUN)\([^[]' \ + $$($(VC_LIST_EXCEPT) | grep -E '(^configure\.ac|\.m4)$$') \ + && { echo '$(ME): quote the first arg to AC_DEF*' 1>&2; \ exit 1; } || : fix_po_file_diag = \ |