summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2009-04-04tests: improve ChangeLog syntax checkJim Meyering
* maint.mk (sc_changelog): Use $(VC_LIST_EXCEPT), not find. Don't hang when there are no ChangeLog files. (sc_require_config_h): For the file-name-filter, use grep -l to be slightly more efficient. (sc_require_config_h_first, _header_without_use, sc_program_name): Likewise.
2009-04-04tests: make syntax-checks more robustRalf Wildenhues
* maint.mk (_prohibit_regexp): Add ';' at end of ':'-introduced comment so that the comment doesn't gobble up the following test for a missing regexp definition. (_header_without_use): Escape all '.'s in a header file name, not just the first one.
2009-04-03* cfg.mk (old_NEWS_hash): Regenerate once more.Jim Meyering
2009-04-03doc: adjust 7.2 "cat,cp,install,mv,split speed-up" NEWS itemJim Meyering
* NEWS: Reword an entry from 7.2 and change "linux" to "GNU/Linux". The latter was requested by Richard Stallman. * cfg.mk (old_NEWS_hash): Regenerate.
2009-04-03ls: fix alignment when month names have varying widthsPádraig Brady
Reported by Samuel Thibault and Stéphane Raimbault, as the glibc fr_FR locale has recently changed to use the official but variable width abbreviated month names. Other glibc locales also have variable widths. http://sourceware.org/ml/libc-locales/2008-q1/msg00035.html http://sourceware.org/bugzilla/show_bug.cgi?id=9859 * NEWS: Mention the fix * gl/lib/mbsalign.c: A new module to align and truncate a string in a specified number of screen cells, while handling multi-byte characters appropriately. * gl/lib/mbsalign.h: Ditto * gl/modules/mbsalign: Ditto * bootstrap.conf: Reference the new module * src/ls.c (abmon_init): New function, precompute the abbreviated months aligned left in a minimum width column <= 5 screen cells. (align_nstrftime): New function, replace the first %b in the format specification to strftime with the precomputed month string. Note using the cached month strings speeds up `ls -lU` by around 17% on glibc-2.7-2 on linux at least. Also if we implement this function using heap storage rather than automatic storage, and use snprintf instead of strcpy, ls will slow down by 2% and 1% respectively (i.e. a net gain of 14% rather than 17%). * tests/ls/abmon-align: A new test to test ls alignment for various formats and locales * tests/Makefile.am: Reference the new test
2009-04-02doc: Clarify the help for version sorting in ls and sortPádraig Brady
* src/ls.c: Update the -v help description * src/sort.c: Update the -V help description
2009-04-02doc: adjust README-prereq instructionsJim Meyering
* README-prereq: Reverse order of -b/--track options. Pádraig Brady mentioned that is required with at least git-1.5.3.6. Invoke automake's own bootstrap script.
2009-04-02build: require automake-1.10b or newerC de-Avillez
* bootstrap.conf: Require at least automake-1.10b. * README-prereq: Mention 1.10b, not 1.10a.
2009-04-02tests: skip mv/i-3 if /dev/stdin is unreadableJim Meyering
* tests/mv/i-3: Skip if /dev/stdin is unreadable. Reported by Sergei Steshenko.
2009-03-31build: set automake's silent-rules option via configure.acJim Meyering
* bootstrap: Revert commit 9f39fa855, 2009-03-28, "build: use automake's --silent-rules option when possible". * configure.ac (AM_INIT_AUTOMAKE): Instead, set it here. Require the just-released version of automake: 1.10b.
2009-03-31tests: enable automake's color-tests and parallel-tests via configure.acJim Meyering
* gnulib-tests/Makefile.am (AUTOMAKE_OPTIONS): Don't define here. * tests/Makefile.am (AUTOMAKE_OPTIONS): Likewise. * configure.ac (AM_INIT_AUTOMAKE): Instead, add color-tests and parallel-tests here.
2009-03-31build: use Automake's new parallel-tests featureRalf Wildenhues
* build-aux/check.mk: Remove, not needed any more. * tests/Makefile.am (AUTOMAKE_OPTIONS): Add parallel-tests and color-tests. * tests/check.mk: Do not include build-aux/check.mk any more. (SUFFIXES, TEST_LOGS): Remove. (TESTS_ENVIRONMENT): Use $$f rather than $$tst in $PERL invocation. * gnulib-tests/Makefile.am: Do not include build-aux/check.mk. (AUTOMAKE_OPTIONS): New macro, add parallel-test and color-tests. (TEST_LOGS): Remove.
2009-03-31* README-release (savannah news): Also mention the Subject: to use.Jim Meyering
2009-03-31post-release administriviaJim Meyering
* NEWS: Add header line for next release. * .prev-version: Record previous version. * cfg.mk (old_NEWS_hash): Auto-update.
2009-03-31version 7.2Jim Meyering
* NEWS: Record release date.
2009-03-29tests: don't use lang-default from individual testsJim Meyering
* tests/sample-test: Don't recommend using lang-default here. It is now run for each test automatically, via TESTS_ENVIRONMENT. * tests/dd/reblock: Don't source lang-default here. * tests/misc/truncate-fail-diag: Likewise.
2009-03-29tests: other-fs-tmpdir: remove just-added duplicate /usr/tmpJim Meyering
* tests/other-fs-tmpdir (CANDIDATE_TMP_DIRS): Remove 2nd /usr/tmp.
2009-03-29tests: other-fs-tmpdir: avoid bogus "skipped **********..." diagnosticJim Meyering
* tests/other-fs-tmpdir (CANDIDATE_TMP_DIRS): Add /dev/shm to the list. Don't use a line of asterisks as the first line of the "why skipped" diagnostic, now that that line is printed on 'make check's stderr.
2009-03-28build: use automake's --silent-rules option when possibleJim Meyering
* bootstrap: Use automake's --silent-rules option.
2009-03-27tests: test-argv-iter.c: avoid declaration-after-stmtJim Meyering
* gl/tests/test-argv-iter.c: Move declaration "up", so as not to ruffle feathers of crufty compilers. We accommodate such compilers here solely because this module may migrate to gnulib. Tiny patch by Matthew Woehlke.
2009-03-27tests: fix 'make sc_tight_scope' on cygwinEric Blake
* src/Makefile.am (sc_tight_scope): Ignore leading underscores in symbols.
2009-03-27tests: avoid spurious test failure in set-GID build dirJim Meyering
* tests/install/install-C-root: Skip this test if in set-gid directory. Reported by Sven Joachim and C de-Avillez.
2009-03-27tests: migrate setgid-check into test-lib.shJim Meyering
* tests/test-lib.sh (skip_if_setgid_): New function. * tests/setgid-check: Remove file. * tests/Makefile.am (EXTRA_DIST): Remove setgid-check. * tests/chmod/c-option: Use the new function rather than sourcing the separate file. * tests/cp/cp-parents: Likewise. * tests/install/install-C: Likewise. * tests/mkdir/parents: Likewise. * tests/mkdir/perm: Likewise.
2009-03-26tests: mark the rm/ext3-perf test as "very" expensiveJim Meyering
* tests/rm/ext3-perf: Relegate this test to the very_expensive category, since it is failing too often for me, when run in parallel (-j4) with other disk-hammering tests. This test fails when it takes too long, so the fact that it fails under pressure is an inconvenience more than a real problem.
2009-03-26* gnulib: Update submodule to latest.Jim Meyering
2009-03-26df: port the known-value fix to AIX as wellPaul Eggert
* src/df.c (known_value): New function, which also works on AIX /proc file systems. (df_readable, show_dev): Use it instead of hardcoding comparison to UINTMAX_MAX. Suggested by Jim Meyering and Matthew Woehlke.
2009-03-26df: fix a bug when totaling unknown valuesPaul Eggert
* src/df.c (show_dev): Don't add UINTMAX_MAX to grand totals, as that value indicates that the true value is unknown; adding it effectively subtracts 1 from the total, whereas we want to leave the total alone.
2009-03-25tests: don't fail "make syntax-check" on cygwinJim Meyering
* maint.mk (NEWS_hash): Remove trailing " -" or " *-". * cfg.mk (old_NEWS_hash): Regenerate, removing " -". Reported by Eric Blake.
2009-03-25pwd: support -L and -PEric Blake
* src/pwd.c (longopts): New variable. (logical_getcwd): New function. (main): Use it. (usage): Document new options. * doc/coreutils.texi (pwd invocation): Likewise. * NEWS: Likewise. * TODO (pwd): Mark it done. * tests/misc/pwd-option: New file. * tests/Makefile.am (TESTS): Add test. * THANKS: Update. Reported by Paul D. Smith, in savannah bug 24949.
2009-03-25doc: update suffix regex in version sortOndřej Vašík
* doc/coreutils.texi: Reflect current filevercmp regex.
2009-03-25tests: CuTmpdir.pm: avoid use of undefined variable in warningRalf Wildenhues
* tests/CuTmpdir.pm (chmod_tree): Do not warn if $dir is undefined.
2009-03-24tests: ls -v: exercise yet another change in gnulib's new filevercmpJim Meyering
* tests/misc/ls-misc: Add names with ~ and ~.1~ suffixes.
2009-03-24* gnulib: Update submodule to latest.Jim Meyering
2009-03-24ls: make it possible to disable coloring of hard linksKamil Dudka
* src/ls.c (print_color_indicator): Don't color hard links if disabled (when there is an empty hl= in the LS_COLORS environment variable). * tests/ls/hardlink: Add test case for disabled hard link highlighting. * NEWS: Mention the change.
2009-03-21tests: search only files that are under version controlJim Meyering
* maint.mk (sc_error_exit_success): Search only files that are under version control. (sc_makefile_path_separator_check): Likewise. Check *.mk files, too, not just Makefile.am files.
2009-03-21tests: follow own advice: use $(PATH_SEPARATOR), not ":"Jim Meyering
* maint.mk (coreutils-path-check): Use the variable, not the literal.
2009-03-21tests: modernize: use $(var) makefile notation, not @var@Jim Meyering
* maint.mk (sc_makefile_path_separator_check): Recommend the use of $(PATH_SEPARATOR), not @PATH_SEPARATOR@. Remove an obsolete comment.
2009-03-20tests: teach sc_dd_O_FLAGS about new syntax in dd.cJim Meyering
* cfg.mk (sc_dd_O_FLAGS): Adapt to new syntax.
2009-03-20dd: use a more portable definition of O_FULLBLOCKEric Blake
* src/dd.c (O_FULLBLOCK): Compute its value without using a 180KB macro. This avoids triggering a compilation failure with HP-UX's cc. Reported by Matthew Woehlke.
2009-03-20tests: avoid spurious mkdir/selinux test failure on HP-UX 11.23Jim Meyering
* tests/mkdir/selinux: Accept yet another diagnostic. Reported by Matthew Woehlke.
2009-03-19tests: df/total-verify: avoid test failure with older PerlJim Meyering
* tests/df/total-verify: Don't use perl's -f option. Reported by Matthew Woehlke.
2009-03-19* gnulib: Update submodule to latest.Jim Meyering
2009-03-18tests: adjust sort-continue not to fail under valgrindJim Meyering
* tests/misc/sort-continue: Don't run cat inside fd-limited shell. If sort fails to run in an fd-limited shell, skip the test.
2009-03-18tests: add another sort/nmerge testPaul Eggert
* tests/Makefile.am (TESTS): Add sort-merge-fdlimit. * tests/misc/sort-merge-fdlimit: New file. * doc/coreutils.texi (sort invocation): Document that we now silently lower nmerge if necessary. Patch by Paul Eggert, Nima Nikzad, Max Chang, Alexander Nguyen, Sahil Amoli, and Nick Graham.
2009-03-18sort: handle fd exhaustion better when mergingPaul Eggert
This is an alternative to my 9 March patch labeled "Silently lower nmerge; don't (sometimes incorrectly) range-check" <http://lists.gnu.org/archive/html/bug-coreutils/2009-03/msg00070.html>. It differs by not using 'dup' to probe for extra file descriptors; instead, it simply calls 'open' (and 'pipe') to open files and pipes, until one of these calls fails due to file descriptor exhaustion; it then backs off by 1, does a merge with the files that it has opened, and then retries with the (now-smaller) number of files. This patch requires quite a few more changes to the source code than the earlier patch, but it is in some sense "better" because it doesn't need to call "dup" ahead of time in order to decide whether "open" or "pipe" will fail. Also, it's more robust in the case where "open" or "pipe" fails with errno==EMFILE because some system-wide limit is exhausted. * src/sort.c (create_temp_file): New arg SURVIVE_FD_EXHAUSTION. (stream_open): New function, containing guts of xfopen. (xfopen): Use it. (pipe_fork): Set errno on failure. (maybe_create_temp): New function, containing guts of create_temp. (create_temp): Use it. (open_temp): Distinguish failures due to file descriptor exhaustion from other failures, and on fd exhaustion return a notice to caller rather than dying. Don't test execlp's return value; when it returns, it *always* returns -1. (open_input_files): New function. (mergefps): New arg FPS. It's now the caller's responsibility to open the input and output files. All callers changed. (mergefiles): New function. (avoid_trashing_input, merge): Handle the case where a single merge can't merge as much as we wanted due to file descriptor exhaustion, by merging as much as we can and then retrying. * tests/Makefile.am (TESTS): Add misc/sort-continue. * tests/misc/sort-continue: New file. * THANKS: Add Glen Lenker and Matt Pham who coauthored this patch.
2009-03-18maint: normalize leading-TAB indentation in MakefilesJim Meyering
* maint.mk (sc_makefile_TAB_only_indentation): New rule. Replace each TAB+8-space sequence with two TABs. * man/Makefile.am: Likewise. * build-aux/check.mk: Likewise. I used this command (run it more than once, if needed): t=$'\t'; git grep -l -E "$t {8}"|grep -E 'Makefile|\.mk$' \ | xargs perl -pi -e 's/\t {8}/\t\t/'
2009-03-15maint: remove long-unused MakefileJim Meyering
* tests/sort-time/Makefile: Remove long-unused file.
2009-03-15maint: remove unused include and definitionsJim Meyering
* gl/lib/randread.c (__attribute__): Remove unused definition. (ATTRIBUTE_UNUSED): Likewise. * gl/lib/selinux-at.c (_): Remove unused definition. Don't include <gettext.h>. No longer needed.
2009-03-15* gnulib: Update submodule to latest.Jim Meyering
2009-03-14system.h: correct compilation error: MAX not definedJim Meyering
* src/system.h (io_blksize): Move definition down, so it follows that of MAX -- to avoid compilation failure on OpenSolaris. Reported by David Bartley. Details in http://lists.gnu.org/archive/html/bug-coreutils/2009-03/msg00190.html