summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRalf Wildenhues <Ralf.Wildenhues@gmx.de>2009-04-04 10:25:18 +0200
committerJim Meyering <meyering@redhat.com>2009-04-04 10:25:18 +0200
commitd75bcea4cfc7927535d19d34d8d103621b4a0d6d (patch)
treea8fb914698edcbc71f088ffb3bfaa2ff7700a161
parenteaacc89a455c1cc5d3c1c3af1b8ff6442c92ce37 (diff)
downloadcoreutils-d75bcea4cfc7927535d19d34d8d103621b4a0d6d.tar.xz
tests: make syntax-checks more robust
* maint.mk (_prohibit_regexp): Add ';' at end of ':'-introduced comment so that the comment doesn't gobble up the following test for a missing regexp definition. (_header_without_use): Escape all '.'s in a header file name, not just the first one.
-rw-r--r--maint.mk4
1 files changed, 2 insertions, 2 deletions
diff --git a/maint.mk b/maint.mk
index 554b90a12..dd780adb0 100644
--- a/maint.mk
+++ b/maint.mk
@@ -103,7 +103,7 @@ _ignore_case = $$(test -n "$$ignore_case" && echo -i || :)
# If the offending construct can be matched with a grep-E-style regexp,
# use this macro. The shell variables "re" and "msg" must be defined.
define _prohibit_regexp
- dummy=; : so we do not need a semicolon before each use \
+ dummy=; : so we do not need a semicolon before each use; \
test "x$$re" != x || { echo '$(ME): re not defined' 1>&2; exit 1; }; \
test "x$$msg" != x || { echo '$(ME): msg not defined' 1>&2; exit 1; };\
grep $(_ignore_case) -nE "$$re" $$($(VC_LIST_EXCEPT)) && \
@@ -225,7 +225,7 @@ sc_prohibit_HAVE_MBRTOWC:
# h: the header, enclosed in <> or ""
# re: a regular expression that matches IFF something provided by $h is used.
define _header_without_use
- h_esc=`echo "$$h"|sed 's/\./\\./'`; \
+ h_esc=`echo "$$h"|sed 's/\./\\./g'`; \
if $(VC_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then \
files=$$(grep -l '^# *include '"$$h_esc" \
$$($(VC_LIST_EXCEPT) | grep '\.c$$')) && \