summaryrefslogtreecommitdiff
path: root/cfg.mk
diff options
context:
space:
mode:
authorJim Meyering <jim@meyering.net>2012-10-25 18:35:34 +0200
committerJim Meyering <jim@meyering.net>2012-10-25 18:35:34 +0200
commit74da4c80470bffe3ccfaead598dad36bf64f1b97 (patch)
tree4ee4959c1703c0936ab0019ca1fc372a22382eca /cfg.mk
parent77179e4abec6ee5dc6b514d592b6de4359edb93a (diff)
downloadcoreutils-74da4c80470bffe3ccfaead598dad36bf64f1b97.tar.xz
maint: tweak sc_check-I18N-AUTHORS
* cfg.mk (sc_check-I18N-AUTHORS): Remove unnecessary subshell; add a self-explanatory diagnostic.
Diffstat (limited to 'cfg.mk')
-rw-r--r--cfg.mk12
1 files changed, 7 insertions, 5 deletions
diff --git a/cfg.mk b/cfg.mk
index 40ece55d3..08f6c3d82 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -181,13 +181,15 @@ sc_check-AUTHORS: $(all_programs)
&& diff $(au_actual) $(au_dotdot) \
&& rm -f $(au_actual) $(au_dotdot)
-# Ensure programs with authors with non ASCII names link with LIBICONV
+# Each program with a non-ASCII author name must link with LIBICONV.
sc_check-I18N-AUTHORS:
- @(cd $(srcdir)/src && \
+ @cd $(srcdir)/src && \
for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
- grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk > \
- /dev/null || { echo FAIL $$i; exit 1; }; \
- done)
+ grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk \
+ > /dev/null \
+ || { "echo $(ME): link rules for $$i do not include" \
+ '$$(LIBICONV)' 1>&2; exit 1; }; \
+ done
# Look for lines longer than 80 characters, except omit:
# - program-generated long lines in diff headers,