From 74da4c80470bffe3ccfaead598dad36bf64f1b97 Mon Sep 17 00:00:00 2001
From: Jim Meyering <jim@meyering.net>
Date: Thu, 25 Oct 2012 18:35:34 +0200
Subject: maint: tweak sc_check-I18N-AUTHORS

* cfg.mk (sc_check-I18N-AUTHORS): Remove unnecessary subshell;
add a self-explanatory diagnostic.
---
 cfg.mk | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

(limited to 'cfg.mk')

diff --git a/cfg.mk b/cfg.mk
index 40ece55d3..08f6c3d82 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -181,13 +181,15 @@ sc_check-AUTHORS: $(all_programs)
 	  && diff $(au_actual) $(au_dotdot) \
 	  && rm -f $(au_actual) $(au_dotdot)
 
-# Ensure programs with authors with non ASCII names link with LIBICONV
+# Each program with a non-ASCII author name must link with LIBICONV.
 sc_check-I18N-AUTHORS:
-	@(cd $(srcdir)/src &&                           \
+	@cd $(srcdir)/src &&						\
 	  for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
-	    grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk > \
-	      /dev/null || { echo FAIL $$i; exit 1; };            \
-	  done)
+	    grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk	\
+		> /dev/null						\
+	      || { "echo $(ME): link rules for $$i do not include"	\
+		    '$$(LIBICONV)' 1>&2; exit 1; };			\
+	  done
 
 # Look for lines longer than 80 characters, except omit:
 # - program-generated long lines in diff headers,
-- 
cgit v1.2.3-54-g00ecf