diff options
author | Luke Shumaker <lukeshu@parabola.nu> | 2018-08-09 13:42:37 -0400 |
---|---|---|
committer | Allan McRae <allan@archlinux.org> | 2018-09-19 18:01:23 +1000 |
commit | cd7b2d6e07bdbc11f8973bedef0cb0ef02f81563 (patch) | |
tree | 4bf4e624ee13f8905ef2c3308ced5a531f8589fe /proto/proto.install | |
parent | 192d6166e9cb2a8f26d7256690e0158bd5a5d226 (diff) | |
download | pacman-cd7b2d6e07bdbc11f8973bedef0cb0ef02f81563.tar.xz |
makepkg: lint_pkgver: Run even if PKGVERFUNC
lint_pkgver returns 0 if PKGVERFUNC, since it's likely that update_pkgver()
will change the value of pkgver anyway, and there's no point in linting the
old value. update_pkgver() will call check_pkgver() itself to validate the
new value.
However, that "optimization" only holds if we're definitely going to call
update_pkgver() later; and that's way more complicated than
if (( PKGVERFUNC )); then
it's more like:
if (( !GENINTEG && !PACKAGELIST && !PRINTSRCINFO && !SOURCEONLY && !REPKG && PKGVERFUNC )); then
Which is to say: If I have a PKGBUILD with pkgver():
* if I run `makepkg -g` I expect it to lint pkgver, but it won't
* if I run `makepkg -R` I expect it to lint pkgver, but it won't
* ...
So let's fix that.
Rather than try to keep a huge list of conditions in sync with the flow of
makepkg.sh.in, let's just drop it. As far as I can tell, the only thing
that skipping lint_pkgver() really enables is letting the PKGBUILD author
write `pkgver=` in the initial version, and letting pkgver() fill it in.
They can just start writing `pkgver=0` for that workflow.
Signed-off-by: Allan McRae <allan@archlinux.org>
Diffstat (limited to 'proto/proto.install')
0 files changed, 0 insertions, 0 deletions