| Age | Commit message (Collapse) | Author |
|---|
|
Instead of creating the object on heap and use a pointer, create
the object on stack and use a guaranteed-not-null pointer.
The size of IniFile doesn't warrent the forcing to heap.
Additionally, use a subclass instead of a function to do some
initial bookkeeping on an IniFile meant to read a configuration.
|
|
(#9306)
This is mostly done as there are now constraints on settings.ini you might not
expected. For example, conditional settings always have to come last, as otherwise
they would influence the index.
|
|
|
|
instead of an AutoFreeSmallVector.
|
|
Auto[Free|Delete]SmallVector
|
|
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
|
|
|
|
config file.
|
|
push scanning AIs to later in the process (when the GUI is showing the progress bar)
|
|
static in that file.
|
|
settings.cpp
|
|
|
|
from within a game via the console (use setting_newgame instead of setting)
|
|
if a header require a header make it include that header
|
|
|
|
|
|
for a new company instead of zeroing them.
|
|
with calls to CmdChangeCompanySetting
|
|
except where it's used for backward compatability.
|
|
like it's done for other list_* console commands
|
|
NewGRF window. Presets are saved in the config file.
|
|
the patch command.
|
|
the NewGRF settings window.
|
|
|
