(svn r2324) Introduce _cmd_text for passing strings with a command instead of abusing _decode_parameters as text buffer. This should prevent several possible buffer overruns and is a bit cleaner to use. As bonus it reduces the size of most command packets by 79 bytes.

1 files changed, 2 insertions, 2 deletions

diff --git a/waypoint.c b/waypoint.c
index dd6750fe1..f2c502b32 100644
--- a/waypoint.c
+++ b/waypoint.c
@@ -302,8 +302,8 @@ int32 CmdRenameWaypoint(int x, int y, uint32 flags, uint32 p1, uint32 p2)
 
 	if (!IsWaypointIndex(p1)) return CMD_ERROR;
 
-	if (_decode_parameters[0] != 0) {
-		str = AllocateNameUnique((const char*)_decode_parameters, 0);
+	if (_cmd_text[0] != '\0') {
+		str = AllocateNameUnique(_cmd_text, 0);
 		if (str == 0)
 			return CMD_ERROR;