diff options
| author | tron <tron@openttd.org> | 2005-05-15 18:50:55 +0000 |
|---|---|---|
| committer | tron <tron@openttd.org> | 2005-05-15 18:50:55 +0000 |
| commit | fea596567944fba8d9d4ead62d948db14690fdf1 (patch) | |
| tree | ad6dc27f46725e511e93e061f51683311027ec65 /station_gui.c | |
| parent | 6cd410afbb3cedff9f6d86fc30dbd4e67817ebc9 (diff) | |
| download | openttd-fea596567944fba8d9d4ead62d948db14690fdf1.tar.xz | |
(svn r2324) Introduce _cmd_text for passing strings with a command instead of abusing _decode_parameters as text buffer. This should prevent several possible buffer overruns and is a bit cleaner to use. As bonus it reduces the size of most command packets by 79 bytes.
Diffstat (limited to 'station_gui.c')
| -rw-r--r-- | station_gui.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/station_gui.c b/station_gui.c index 608e292e7..046b580ec 100644 --- a/station_gui.c +++ b/station_gui.c @@ -503,14 +503,13 @@ static void StationViewWndProc(Window *w, WindowEvent *e) break; case WE_ON_EDIT_TEXT: { - Station *st; - const char *b = e->edittext.str; - if (*b == 0) - return; - memcpy(_decode_parameters, b, 32); - - st = GetStation(w->window_number); - DoCommandP(st->xy, w->window_number, 0, NULL, CMD_RENAME_STATION | CMD_MSG(STR_3031_CAN_T_RENAME_STATION)); + if (e->edittext.str[0] != '\0') { + Station* st = GetStation(w->window_number); + + _cmd_text = e->edittext.str; + DoCommandP(st->xy, w->window_number, 0, NULL, + CMD_RENAME_STATION | CMD_MSG(STR_3031_CAN_T_RENAME_STATION)); + } } break; case WE_DESTROY: { |