From fea596567944fba8d9d4ead62d948db14690fdf1 Mon Sep 17 00:00:00 2001 From: tron Date: Sun, 15 May 2005 18:50:55 +0000 Subject: (svn r2324) Introduce _cmd_text for passing strings with a command instead of abusing _decode_parameters as text buffer. This should prevent several possible buffer overruns and is a bit cleaner to use. As bonus it reduces the size of most command packets by 79 bytes. --- station_gui.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) (limited to 'station_gui.c') diff --git a/station_gui.c b/station_gui.c index 608e292e7..046b580ec 100644 --- a/station_gui.c +++ b/station_gui.c @@ -503,14 +503,13 @@ static void StationViewWndProc(Window *w, WindowEvent *e) break; case WE_ON_EDIT_TEXT: { - Station *st; - const char *b = e->edittext.str; - if (*b == 0) - return; - memcpy(_decode_parameters, b, 32); - - st = GetStation(w->window_number); - DoCommandP(st->xy, w->window_number, 0, NULL, CMD_RENAME_STATION | CMD_MSG(STR_3031_CAN_T_RENAME_STATION)); + if (e->edittext.str[0] != '\0') { + Station* st = GetStation(w->window_number); + + _cmd_text = e->edittext.str; + DoCommandP(st->xy, w->window_number, 0, NULL, + CMD_RENAME_STATION | CMD_MSG(STR_3031_CAN_T_RENAME_STATION)); + } } break; case WE_DESTROY: { -- cgit v1.2.3-70-g09d2