summaryrefslogtreecommitdiff
path: root/src/screenshot.h
diff options
context:
space:
mode:
authorMatthijs Kooijman <matthijs@stdin.nl>2020-05-12 17:34:16 +0200
committerCharles Pigott <charlespigott@googlemail.com>2020-05-13 08:33:34 +0100
commit2d5869fc79a1f1f347ab31665148c806d54afcd9 (patch)
tree2ecd8a8ca9309ad619a299d7d52f8c07a22143d3 /src/screenshot.h
parent6dcc99edab3b0ab072675ecdeffd638b644913bc (diff)
downloadopenttd-2d5869fc79a1f1f347ab31665148c806d54afcd9.tar.xz
Fix: sdl2-config would always be detected as present
The presence of sdl2-config is used go determine whether to look for sdl2 first, or just sdl1. However, when sdl2-config is *not* present, `which` returns an empty string. Due to lack of quoting, this produces `[ -x ]`, rather than `[ -x "" ]` and it turns out the former actually has a succesful exit status for some reason. This was not a problem when just running configure, because it would then just fail to detect sdl2 and fall back to sdl1. However, when passing `--with-sdl` (without specifying a version), this would only attempt to detect sdl2, even when sdl2-config was not present, but sdl1 is. Adding quotes makes the check work as intended.
Diffstat (limited to 'src/screenshot.h')
0 files changed, 0 insertions, 0 deletions