summaryrefslogtreecommitdiff
path: root/src/saveload/afterload.cpp
diff options
context:
space:
mode:
authorPatric Stout <truebrain@openttd.org>2021-06-18 13:27:59 +0200
committerPatric Stout <github@truebrain.nl>2021-07-02 22:21:58 +0200
commit4e645ce749904f736ccf2b5b9d400240ea420833 (patch)
tree48263c271be7db4fb1bc00f1046be616d8cea909 /src/saveload/afterload.cpp
parent9643a1b80ac9d5c2e3b2781e7536de874ee3f2bb (diff)
downloadopenttd-4e645ce749904f736ccf2b5b9d400240ea420833.tar.xz
Codechange: using "until" in function names can be confusing
IsSavegameVersionUntil() did a [0, N] check, not [0, N) as the name suggests. Until can be a confusing word, where people consider it to be including the upperbound. Dictionary states it means "before", excluding the upperbound. There are long debates about who is right. So, simply remove away from this ambiguity, and call it "before" and "before or at". This makes the world easier for everyone.
Diffstat (limited to 'src/saveload/afterload.cpp')
-rw-r--r--src/saveload/afterload.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/saveload/afterload.cpp b/src/saveload/afterload.cpp
index 83f3c6fc6..df1b4e44f 100644
--- a/src/saveload/afterload.cpp
+++ b/src/saveload/afterload.cpp
@@ -3106,7 +3106,7 @@ bool AfterLoadGame()
}
}
- if (IsSavegameVersionUntil(SLV_ENDING_YEAR)) {
+ if (IsSavegameVersionBeforeOrAt(SLV_ENDING_YEAR)) {
/* Update station docking tiles. Was only needed for pre-SLV_MULTITLE_DOCKS
* savegames, but a bug in docking tiles touched all savegames between
* SLV_MULTITILE_DOCKS and SLV_ENDING_YEAR. */