diff options
| author | Michael Lutz <michi@icosahedron.de> | 2019-04-02 21:31:24 +0200 |
|---|---|---|
| committer | Michael Lutz <michi@icosahedron.de> | 2019-04-09 22:45:15 +0200 |
| commit | c7b9987d081ae4e0103309b18c93deecc395dec9 (patch) | |
| tree | e5b1f9553d6399e2eed9c05a2d91673205f9c912 /src/music_gui.cpp | |
| parent | d3e113eb5f618ce0174fa0dfa2591cb96e999350 (diff) | |
| download | openttd-c7b9987d081ae4e0103309b18c93deecc395dec9.tar.xz | |
Codechange: Switch DropDownList to directly use std::vector, thus making AutoDeleteSmallVector obsolete.
DropDownListItem are strongly managed using std::unique_ptr to ensure leak-free handling. Appropriate use
of move-semantics make intent a lot clearer than parameter comments and allows the compiler to generate
copy-free code for most situations.
Diffstat (limited to 'src/music_gui.cpp')
| -rw-r--r-- | src/music_gui.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/music_gui.cpp b/src/music_gui.cpp index da63192e0..90fd47669 100644 --- a/src/music_gui.cpp +++ b/src/music_gui.cpp @@ -571,8 +571,7 @@ struct MusicTrackSelectionWindow : public Window { case WID_MTS_MUSICSET: { int selected = 0; - DropDownList *dropdown = BuildMusicSetDropDownList(&selected); - ShowDropDownList(this, dropdown, selected, widget, 0, true, false); + ShowDropDownList(this, BuildMusicSetDropDownList(&selected), selected, widget, 0, true, false); break; } |