diff options
| author | Michael Lutz <michi@icosahedron.de> | 2019-04-02 21:31:24 +0200 |
|---|---|---|
| committer | Michael Lutz <michi@icosahedron.de> | 2019-04-09 22:45:15 +0200 |
| commit | c7b9987d081ae4e0103309b18c93deecc395dec9 (patch) | |
| tree | e5b1f9553d6399e2eed9c05a2d91673205f9c912 /src/group_gui.cpp | |
| parent | d3e113eb5f618ce0174fa0dfa2591cb96e999350 (diff) | |
| download | openttd-c7b9987d081ae4e0103309b18c93deecc395dec9.tar.xz | |
Codechange: Switch DropDownList to directly use std::vector, thus making AutoDeleteSmallVector obsolete.
DropDownListItem are strongly managed using std::unique_ptr to ensure leak-free handling. Appropriate use
of move-semantics make intent a lot clearer than parameter comments and allows the compiler to generate
copy-free code for most situations.
Diffstat (limited to 'src/group_gui.cpp')
| -rw-r--r-- | src/group_gui.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/group_gui.cpp b/src/group_gui.cpp index ecc95064f..22604fdf3 100644 --- a/src/group_gui.cpp +++ b/src/group_gui.cpp @@ -768,8 +768,7 @@ public: break; case WID_GL_MANAGE_VEHICLES_DROPDOWN: { - DropDownList *list = this->BuildActionDropdownList(true, Group::IsValidID(this->vli.index)); - ShowDropDownList(this, list, 0, WID_GL_MANAGE_VEHICLES_DROPDOWN); + ShowDropDownList(this, this->BuildActionDropdownList(true, Group::IsValidID(this->vli.index)), 0, WID_GL_MANAGE_VEHICLES_DROPDOWN); break; } |