(svn r14958) -Codechange [FS#1923]: when checking for unique names, compare only with manually set names

There are situations that aren't solvable (because of different language files), so if the user really wants to have duplicated name, allow him to do so. It solves desyncs between server and clients using different languages. It behaves the same in SP and MP, so users won't see the different behaviour as a bug (and even checking in SP could be worked around by the user).

1 files changed, 1 insertions, 4 deletions

diff --git a/src/group_cmd.cpp b/src/group_cmd.cpp
index 44e3b6bb3..cea7d33ac 100644
--- a/src/group_cmd.cpp
+++ b/src/group_cmd.cpp
@@ -149,12 +149,9 @@ CommandCost CmdDeleteGroup(TileIndex tile, uint32 flags, uint32 p1, uint32 p2, c
 static bool IsUniqueGroupName(const char *name)
 {
 	const Group *g;
-	char buf[512];
 
 	FOR_ALL_GROUPS(g) {
-		SetDParam(0, g->index);
-		GetString(buf, STR_GROUP_NAME, lastof(buf));
-		if (strcmp(buf, name) == 0) return false;
+		if (g->name != NULL && strcmp(g->name, name) == 0) return false;
 	}
 
 	return true;