(svn r3187) Simplify overly complicated ifs, especially if (foo) return false; else return true; is confusing

1 files changed, 4 insertions, 5 deletions

diff --git a/command.c b/command.c
index 3a929c941..02569d01d 100644
--- a/command.c
+++ b/command.c
@@ -309,12 +309,11 @@ static const Command _command_proc_table[] = {
 /* This function range-checks a cmd, and checks if the cmd is not NULL */
 bool IsValidCommand(uint cmd)
 {
-	cmd = cmd & 0xFF;
+	cmd &= 0xFF;
 
-	if (cmd >= lengthof(_command_proc_table) || _command_proc_table[cmd].proc == NULL)
-		return false;
-
-	return true;
+	return
+		cmd < lengthof(_command_proc_table) &&
+		_command_proc_table[cmd].proc != NULL;
 }
 
 byte GetCommandFlags(uint cmd) {return _command_proc_table[cmd & 0xFF].flags;}