(svn r4586) - Codechange: Recursive commands that rely on _error_message to handle success/failure can fail if a recursive call fails but doesn't set the error message, thus resulting in an old, possibly erroneous being used (see FS#130 prior to r4585). Now properly reset the global variable _error_message in these cases.

1 files changed, 0 insertions, 1 deletions

diff --git a/clear_cmd.c b/clear_cmd.c
index 49197960a..259146965 100644
--- a/clear_cmd.c
+++ b/clear_cmd.c
@@ -197,7 +197,6 @@ int32 CmdTerraformLand(TileIndex tile, uint32 flags, uint32 p1, uint32 p2)
 
 	SET_EXPENSES_TYPE(EXPENSES_CONSTRUCTION);
 
-	_error_message = INVALID_STRING_ID;
 	_terraform_err_tile = 0;
 
 	ts.direction = direction = p2 ? 1 : -1;