summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLuke Shumaker <lukeshu@parabola.nu>2017-05-04 21:08:52 -0400
committerLuke Shumaker <lukeshu@parabola.nu>2017-05-04 21:08:52 -0400
commit855bccdbbc919396d17391337503e2bdc73c1cee (patch)
tree307abb14a866ac08982f246e8fecbb83797e0e5b
parent76d8d0e0e7bb5119654ef2f30ec2d220002af216 (diff)
downloaddevtools-855bccdbbc919396d17391337503e2bdc73c1cee.tar.xz
makechrootpkg: Add a comment warning about a bug in "sudo -i"
The bug isn't currently triggered, but I accidentally did trigger when I was trying to modify the command a bit. I figure a "caution" sign would be helpful to any future developers.
-rw-r--r--makechrootpkg.in4
1 files changed, 4 insertions, 0 deletions
diff --git a/makechrootpkg.in b/makechrootpkg.in
index d922fa0..2a19dbb 100644
--- a/makechrootpkg.in
+++ b/makechrootpkg.in
@@ -241,6 +241,10 @@ EOF
# so no global variables
_chrootbuild() {
. /etc/profile
+ # Beware, there are some stupid arbitrary rules on how you can
+ # use "$" in arguments to commands with "sudo -i". ${foo} or
+ # ${1} is OK, but $foo or $1 isn't.
+ # https://bugzilla.sudo.ws/show_bug.cgi?id=765
sudo -iu builduser bash -c 'cd /startdir; makepkg "$@"' -bash "$@"
}