1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
|
2003-07-19 Jim Meyering <jim@meyering.net>
* Version 5.0.90.
* tests/shred/remove: Don't open-code test for UID != 0.
Use priv-check's require-non-root instead.
Update to use newer framework.
* tests/help-version (expected_failure_status_expr): Record that
expr exits with status of 3 for e.g., a write error.
* tests/priv-check: Use `id -u' to see if we're running as root,
rather than trying go write to an write-protected file.
When running as root, ensure $NON_ROOT_USERNAME is valid.
When running as root with `require-non-root', ensure that `.'
is writable by $NON_ROOT_USERNAME, then reinvoke $0 set-user-ID
to $NON_ROOT_USERNAME. If `.' is not writable, then skip the test.
* src/printenv.c: Include "exitfail.h".
(main): Set exit_failure rather than calling close_stdout_set_status.
* src/date.c: Likewise.
* src/sort.c: Likewise.
* src/tty.c: Likewise.
2003-07-18 Jim Meyering <jim@meyering.net>
* tests/touch/not-owner: Update to use newer framework.
* tests/rm/fail-eperm: Use $srcdir/../priv-check, create a temporary
directory, and remove Perl-coded `you may not run as root' test.
* tests/cp/fail-perm: Use $srcdir/../priv-check, rather than
hard-coding something not quite equivalent.
Paul Jarc reported the inconsistent diagnostics.
* src/sort.c (main): Use close_stdout via atexit.
Now `sort --version' and `sort --help' fail, as they should
when their output is redirected to /dev/full.
* src/su.c (usage): Don't call close_stdout here.
(main): Use close_stdout via atexit.
Now `su --version > /dev/full' fails, as it should.
Somehow, the change of 2000-05-07 that purports to fix this
was not checked in.
* tests/help-version (--help/--version vs. /dev/full): Special-case
`[' to protect it from expected_failure_status-`eval'.
* src/uniq.c (writeline): Use a SPACE, not a TAB between the
count and the corresponding line, as required by POSIX.
Reported by Clement Wang.
* tests/uniq/Test.pm (101, 102): Update tests of -c accordingly.
* tests/expr/basic: Add tests for when exit status is 2.
* src/nohup.c (NOHUP_FOUND_BUT_CANNOT_INVOKE, NOHUP_FAILURE):
Use an anonymous `enum', rather than #define.
2003-07-17 Paul Eggert <eggert@twinsun.com>
* src/expr.c: Include "exitfail.h", "quotearg.h".
(EXPR_INVALID, EXPR_ERROR): New constants.
(nomoreargs, null, toarith, nextarg): Return bool, not int.
(syntax_error): New function, exiting with status 2. Use it
insteading of printing "syntax error" ourselves.
(main): Initialize exit_failure to EXPR_ERROR.
Exit with EXPR_INVALID on syntax error (too few arguments).
(nextarg): Use strcmp, not strcoll; strcoll might return
an undesirable 0, or might fail.
(docolon, eval4, eval3): Exit with status 3 on invalid argument type
or other such error.
(eval2): Report an error if strcoll fails in a string comparison.
* src/sort.c: Include "exitfail.h".
(main): Set exit_failure, not xalloc_exit_failure and
xmemcoll_exit_failure.
* tests/expr/basic: Invalid value exits with status 3, not 2.
2003-07-16 Jim Meyering <jim@meyering.net>
* configure.ac (AC_INIT): Use 5.0.90 as the version, rather than 5.0.2,
per GNU maintainer guidelines. The next non-beta release will be 5.1.
This script would have caught at least two recent bugs:
those in [ and kill.
* tests/help-version: Revive this script.
It wasn't doing anything useful, since $all_programs wasn't being
defined by the invoking Makefile.am.
Reflect that nohup is no longer a script, so don't exclude it.
Add framework to handle the programs added since it was last run:
kill, stat, unlink, [, link, readlink.
Fix path-related problems deriving from the move of this script
from src/ to its present location.
* tests/Makefile.am (all_programs): Define.
(TESTS_ENVIRONMENT): Use it.
* src/kill.c (main): Fix bug introduced on 2003-05-10 (for 5.0.1)
whereby kill would always attempt to operate on argv[0] and fail.
* src/test.c (integer_expected_error): Improve diagnostic -- now,
it also matches the one from bash's builtin test.
(binary_operator): Add \n at end of diagnostic.
* tests/rm/fail-2eperm: Remove setuidgid-related code. Move it to ...
* tests/priv-check: Move setuidgid-related and
NON_ROOT_USERNAME-checking code to this file.
* README: Update section on testing as `root'.
Suggestion from Paul Jarc.
* src/test.c (AUTHORS): Replace 3-letter usernames with the actual
names of authors that I just found in bash's builtins/test.def.
Running `[' with no arguments would evoke a segfault.
* src/test.c (main) [LBRACKET]: Move initialization of argv to
precede potential use via test_syntax_error.
* src/Makefile.am (AM_CPPFLAGS): Rename from `INCLUDES', to avoid
warning from automake -Wall.
2003-07-15 Jim Meyering <jim@meyering.net>
* Version 5.0.1.
* Makefile.maint (%.asc): Remove target first, so gpg doesn't
prompt us about it.
* announce-gen (print_changelog_deltas): Relax tests for matching
version-number line in NEWS.
Change the .sig suffix to .asc here, too.
2003-07-14 Jim Meyering <jim@meyering.net>
* Makefile.maint (%.asc): Renamed from %.sig.
Generate and use ascii-armored signatures.
Use gpg's -o option.
2003-07-13 Jim Meyering <jim@meyering.net>
* src/nohup.c (NOHUP_FAILURE, NOHUP_FOUND_BUT_CANNOT_INVOKE): Define.
(main): Use them.
* Makefile.maint (syntax-check): Move each individual check into
its own target.
(syntax-check-rules): This is the list of syntax-check targets.
(sc_unmarked_diagnostics, sc_cast_of_argument_to_free):
(sc_cast_of_x_alloc_return_value, sc_space_tab):
(sc_error_exit_success, sc_xalloc_h_in_src): New targets.
2003-07-12 Jim Meyering <jim@meyering.net>
* configure.ac: Remove uses of OPTIONAL_BIN_ZCRIPTS and last
traces of the nohup script.
* src/Makefile.am (bin_SCRIPTS): Remove use of just-removed
$(OPTIONAL_BIN_ZCRIPTS).
* src/Makefile.am (localedir.h): Put the `2>&1' after the redirect
target, not before the `>'.
* src/remove.c (remove_dir): Give a diagnostic upon failed save_cwd,
now that that function no longer calls `error'.
* src/df.c (find_mount_point): Emit a diagnostic for each
failed syscall, rather than relying on caller to do that.
The caller couldn't do a good job, anyhow -- too many different
ways to fail (each with a different referent).
Give a diagnostic upon failed save_cwd, now that that function
no longer calls `error'.
(show_point): Don't diagnose find_mount_point's errors, now that
it handles them itself.
* src/df.c (find_mount_point): Don't let free clobber errno upon
failed chdir.
* src/sys2.h: Remove alloca-related block.
* src/system.h: Include <alloca.h> here, instead.
It appears that the `#pragma alloca' included via "system.h" is
adequate, since join.c uses alloca, yet lacked an in-file #pragma.
* src/copy.c, src/cp.c, src/df.c, src/install.c, src/ln.c:
* src/ls.c, src/mv.c, src/remove.c: Remove `#pragma alloca'.
* src/chown-core.c (change_file_owner): Do not restore any special
permission bits (e.g., set-user-ID, set-group-ID) that are reset
by chown(2) on some systems. Suggestion and insistence :-) from
Michael Stone.
* tests/input-tty: Also check `test -t 1'.
This is necessary on linux-2.4.21. Otherwise, the stty/basic-1
test would block when run in the background.
2003-07-11 Jim Meyering <jim@meyering.net>
* tests/sample-test: Also fail if cat-to-create-expected-output
fails. Otherwise, if both `exp' and `out' were to end up empty
because of e.g., a full disk, they would mistakenly compare equal.
* src/nohup.c: New file. Rewrite of nohup.sh in C.
This solves a portability problem: on at least Solaris systems,
when nohup.sh used the vendor /bin/sh, it would exit with status
of `1' rather than the required 126 or 127 upon failure to exec
the specified program.
* src/Makefile.am (EXTRA_SCRIPTS): Remove definition.
(bin_PROGRAMS): Add nohup.
(EXTRA_DIST): Remove nohup.sh.
(all_programs): Remove use of $(EXTRA_SCRIPTS).
* src/nohup.sh: Remove file.
* man/Makefile.am (nohup.1): Depend on nohup.c, rather than nohup.sh.
* tests/misc/nohup: Tests for the above.
* tests/misc/Makefile.am (TESTS): Add nohup.
* src/head.c (diagnose_copy_fd_failure): New function, renamed from
the macro, COPY_FD_DIAGNOSE.
(diagnose_copy_fd_failure): Enclose diagnostic in _(...).
(head_file): Likewise.
* src/date.c: Include "quote.h".
(batch_convert): Use the quote function rather than using literal `...'
in a diagnostic.
* src/setuidgid.c (main): Enclose diagnostic in _(...).
* src/fmt.c (main): Likewise.
* src/mknod.c (main): Likewise.
* src/tac.c (tac_seekable): Likewise.
* src/yes.c (main): Likewise.
* src/od.c (main): Likewise.
* src/install.c (change_attributes): Likewise.
2003-07-10 Jim Meyering <jim@meyering.net>
* src/head.c (usage): Use 1024*1024 in place of 1048576.
* src/tail.c (usage): Likewise.
* tests/rm/fail-2eperm: Now that we have setuidgid, use it in
place of the kludge in this test. Suggestion from Paul Jarc.
* src/Makefile.am (noinst_PROGRAMS): Define to setuidgid.
* src/setuidgid.c: New program, solely for testing (not installed).
* src/chown-core.c (change_file_owner): Don't leak file descriptors
when dereferencing symlinks.
2003-07-09 Jim Meyering <jim@meyering.net>
* tests/du/slash: New file/test for today's lib/ftw.c fix.
* tests/du/Makefile.am (TESTS): Add slash
* src/tail.c (xlseek): Avoid warning about ``return without value
from function returning non-void''.
2003-07-08 Jim Meyering <jim@meyering.net>
* man/help2man: Update to version 1.29.
* man/help2man: Add END handler to close STDOUT and check for errors.
2003-06-30 Paul Eggert <eggert@twinsun.com>
Add support for a "[" that conforms to the GNU coding standards,
i.e., that does not depend on its name.
* src/lbracket.c: New file.
* README: Add "[".
* man/Makefile.am (programs): Ignore "[", since it doesn't have
a separate man page.
* src/Makefile.am (bin_PROGRAMS): Add "[".
(__SOURCES): New var.
* src/test.c (LBRACKET): Define to 0 if not defined.
(main): Use LBRACKET rather than argv[0].
* src/test.c (one_argument): Do not check for -t if POSIXLY_CORRECT.
Reported by Paul Jarc and Dan Jacobson.
* src/test.c (main): Do not recognize --help or --version if
POSIXLY_CORRECT, when invoked as "test". Handle "[ ]" correctly.
Do not bother testing that margv[margc] is non-null.
2003-07-04 Jim Meyering <jim@meyering.net>
* src/who.c (print_line): Rewrite to use asprintf, in order to be
able to avoid emitting trailing spaces. Reported by Dan Jacobson.
* tests/misc/head-elide-tail: Add tests of head's new --lines=-N
option, and perform the +1600 invocations of head IFF the envvar
RUN_EXPENSIVE_TESTS is set.
2003-07-03 Jim Meyering <jim@meyering.net>
* src/cp.c (do_copy): Give a better diagnostic when failing due
to nonexistent destination directory. Reported by Dmitry Rutsky.
See http://bugs.debian.org/199730 for details.
2003-06-27 Jim Meyering <jim@meyering.net>
split's --verbose option did nothing [broken in 4.5.10 and 5.0]
* src/split.c (longopts): Use `1', not `0' as the value for
for &verbose. Reported by Keith Thompson.
Test for the above fix.
* tests/misc/split-a: Also use --verbose and compare stderr
output with what we'd expect.
2003-06-20 Jim Meyering <jim@meyering.net>
* src/copy.c (copy_internal) [HAVE_STRUCT_STAT_ST_AUTHOR]:
Use `error_t' (rather than int) as type for local `err'.
From Alfred M. Szmidt.
2003-06-19 Marcus Brinkmann <marcus@gnu.org>
* src/copy.c (copy_internal) [HAVE_STRUCT_STAT_ST_AUTHOR]:
Fix author preservation code.
2003-06-19 Jim Meyering <jim@meyering.net>
* src/ln.c (ENABLE_HARD_LINK_TO_SYMLINK_WARNING): Define to 0.
(do_link): Don't warn about hard link to symlink.
2003-06-18 Jim Meyering <jim@meyering.net>
* src/cut.c: Include "getdelim2.h", not "getstr.h".
Reflect renaming: getstr -> getdelim2.
* src/comm.c, src/join.c, src/nl.c, src/uniq.c: Reflect renaming:
readline -> readlinebuffer.
2003-06-09 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
* src/readlink.c: Include <sys/types.h> before system.h (because
the latter includes <sys/stat.h>). Required on Ultrix 4.3.
2003-06-17 Jim Meyering <jim@meyering.net>
* src/system.h (initialize_main): Define.
Use it in every `main'. Applied via this:
p='initialize_main (&argc, &argv);'
perl -ni -e '/program_name.=.argv.0/ and print " '"$p"'\n"; print' \
$(grep -l program_name.=.argv.0 *.c)
test.c uses margc/margv, so I made the change manually for that file.
Based on a patch from Bernard Giroud.
2003-06-09 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
Fix for build failure on Ultrix 4.3.
* src/stat.c: Include sys/statvfs.h in preference to sys/vfs.h.
Include sys/param.h and sys/mount.h on ultrix.
2003-06-16 Jim Meyering <jim@meyering.net>
* src/touch.c (O_NDELAY, O_NONBLOCK, O_NOCTTY, EISDIR): Remove
definitions.
* src/system.h (O_NDELAY, O_NONBLOCK, O_NOCTTY, EISDIR): Define
them here instead, but with one change: define EISDIR to -1, not 0.
* src/cat.c (cat): Remove `#ifndef ENOSYS', now that it's
guaranteed to be defined.
* src/system.h (ENOSYS, ENOTSUP): Define to -1 if not defined.
* README: Mention the CVS repository.
Encourage addition of test cases.
2003-06-12 Jim Meyering <jim@meyering.net>
* src/touch.c (touch): Call close only if necessary.
From Bruno Haible.
* src/wc.c (usage): Correct wording: wc prints counts in the order
`newline, word, byte'. Reported by Keith M. Briggs.
* man/wc.x: Fix it here, too. And change `lines' to `newlines'.
2003-06-10 Jim Meyering <jim@meyering.net>
* tests/date/Test.pm: Add a test for the new format, e.g., May-23-2003.
2003-06-07 Jim Meyering <jim@meyering.net>
* Makefile.maint (syntax-check): Add commented-out (over-aggressive)
rule.
2003-06-06 Jim Meyering <jim@meyering.net>
* src/extract-magic (main): Avoid newer 3-arg form of open,
so this script works also with e.g., perl5.005_03.
Patch by John David Anglin.
2003-06-04 Paul Eggert <eggert@twinsun.com>
* src/system.h: Include <stdbool.h> unconditionally.
2003-06-04 Jim Meyering <jim@meyering.net>
* man/Makefile.am (check-programs-vs-x): Rename target
from check-programs-vs-1. Adjust rule to check for the
primary (.x) file, not the generated one (.1).
2003-06-03 Tim Mooney <mooney@dogbert.cc.ndsu.NoDak.edu>
* man/kill.x: New file.
* man/Makefile.am (dist_man_MANS): Add kill.1.
(kill.1): New rule.
2003-06-04 Jim Meyering <jim@meyering.net>
Ensure that the .x file for a new program is never forgotten again.
* man/Makefile.am (programs): Define.
(check-programs-vs-1): New phony target.
(check-local): Depend on it.
2003-06-03 Jim Meyering <jim@meyering.net>
Avoid unnecessary copying of environment.
* src/env.c (main): Rather than clearing the environment and --
unless told to ignore environment -- copying all settings from
the saved, original environment, clear the environment only when
that is requested. Suggested by Jens Elkner.
2003-06-02 Jim Meyering <jim@meyering.net>
* src/system.h: Always include <string.h>, since we assume C89.
Include <limits.h> without checking for HAVE_LIMITS_H.
* src/test.c [!TEST_STANDALONE]: Remove #if-0'd block.
(STREQ, S_IXUGO): Remove redundant (in system.h) definitions.
2003-06-01 Jim Meyering <jim@meyering.net>
Avoid a race condition in `tail -f' described by Ken Raeburn in
http://mail.gnu.org/archive/html/bug-textutils/2003-05/msg00007.html
* src/tail.c (file_lines): Add new parameter, *read_pos, and set it.
(pipe_lines, pipe_bytes, start_bytes, start_lines): Likewise.
(tail_bytes, tail_lines, tail): Likewise.
(tail_file): Use the new `read_pos' value as the size,
rather than stats.st_size from the fstat call.
2003-05-28 Jim Meyering <jim@meyering.net>
* src/extract-magic: Allow expansion of `$file' in the here-
document corresponding to the comment at the top of fs.h.
2003-05-26 Jim Meyering <jim@meyering.net>
* src/stat.c: Fix portability problem on FreeBSD5.0: don't include
<sys/statvfs.h> on systems without HAVE_STRUCT_STATVFS_F_BASETYPE.
Use #if/#elif/... cascade so we get only one set of include files.
Reported by Nelson Beebe.
2003-05-24 Jim Meyering <jim@meyering.net>
* src/md5sum.c (split_3): Accept the BSD format only when in MD5 mode.
* tests/sha1sum/basic-1: Make sure `sha1sum --check' doesn't
accept the BSD format.
2003-03-28 Joe Orton <jorton@redhat.com>
* src/md5sum.c (bsd_split_3): New function.
(split_3): Detect checksums from BSD 'md5' command and handle them
using bsd_split_3.
* tests/md5sum/basic-1: New tests for --check exit status, and for
BSD-style checksum files.
2003-05-21 Jim Meyering <jim@meyering.net>
* src/head.c (elide_tail_lines_pipe): Fix a thinko.
This sort of thing is why it'd be *Really Good* to factor
out the common code used here and in tail.c.
2003-05-14 Jim Meyering <jim@meyering.net>
* src/head.c (usage): Document new feature: --bytes=-N and --lines=-N.
* tests/du/slink: Skip this test if `.' is on an XFS file system.
* tests/du/fd-leak: New file. Test for the bug in du that
was fixed by the 2003-05-12 change to lib/ftw.c.
* tests/du/Makefile.am (TESTS): Add fd-leak.
* src/head.c (AUTHORS): Enclose string in N_(...), now that it
includes a translatable word, `and'.
* src/dd.c (usage): Don't use `,' as the thousands separator
in e.g. 1,000,000 and 1,048,576. Instead, do this:
`SIZE may be ..., MB 1000*1000, M 1024*1024 and so on...'
* src/df.c (usage): Likewise.
* src/du.c (usage): Likewise.
* src/ls.c (usage): Likewise.
* Makefile.maint (syntax-check): Add another check.
2003-05-13 Paul Eggert <eggert@twinsun.com>
Fix uniq to conform to POSIX, which requires that "uniq -d -u"
must output nothing. Problem reported by Josh Hyman.
* src/uniq.c (enum output_mode, mode): Remove, replacing with:
(output_unique, output_first_repeated, output_later_repeated):
New vars. All uses of "mode" changed to use these variables,
which are not mutually exclusive as "mode" was.
(writeline): New arg "match", used to control whether to
obey output_first_repeated or output_later_repeated.
All callers changed.
(check_file, main): Adjust to above changes.
* tests/uniq/Test.pm: Test that 'uniq -d -u' outputs nothing.
2003-05-14 Jim Meyering <jim@meyering.net>
* tests/rm/rm3: Use tr's \n notation rather than \012.
This package can afford to do that, since its tests are guaranteed use
GNU tr, which has accepted the more modern notation for 10 years.
* tests/rm/rm5: Likewise.
* tests/cp/same-file: Likewise.
* tests/stty/row-col-1: Likewise.
* tests/stty/basic-1: Likewise.
* tests/rm/deep-1: Likewise.
* tests/mv/part-symlink: Likewise.
* tests/mkdir/perm: Likewise.
* tests/misc/nice: Likewise.
2003-05-13 Jim Meyering <jim@meyering.net>
* src/copy.c (struct F_triple) [name]: Remove const attribute.
(triple_free): Don't apply cast to argument of free.
(seen_file): Add cast here instead.
* src/cp-hash.c (struct Src_to_dest) [name]: Remove const attribute.
(src_to_dest_free): Don't apply cast to argument of free.
* src/sort.c (zaptemp): Don't apply cast to argument of free.
* src/pr.c (init_fps, init_store_cols): Likewise.
* src/join.c (delseq, freeline): Likewise.
* src/expr.c (OLD): Likewise.
* src/sort.c (sort): Likewise.
* src/head.c (elide_tail_lines_pipe): Likewise.
* src/tail.c: Include "quote.h".
Use quote in diagnostics. Change many error format strings
from just `%s' to e.g., `error reading %s'.
(pipe_lines): Change type of parameter, n_lines, to uintmax_t.
Rewrite newline-counting loop to use memchr.
* src/head.c (elide_tail_lines_pipe): Use `if', not assert.
Now that assert is no longer used, don't include <assert.h>.
2003-05-12 Jim Meyering <jim@meyering.net>
* src/head.c: Include <assert.h>.
(AUTHORS): Add my name.
(elide_tail_lines_pipe): New function.
2003-05-10 Jim Meyering <jim@meyering.net>
* Makefile.maint (syntax-check): Check for `error (EXIT_SUCCESS,'.
* src/readlink.c (main): Set program_name before first use.
Remove that (redundant) first use.
Don't exit successfully just because --verbose was specified.
Pass 0, not EXIT_SUCCESS, as first argument to error; when that
parameter is 0, error does not exit.
* src/uname.c (main): When failing due to too many arguments, also say
that, rather than just "Try `uname --help' for more information.".
* src/comm.c (main): Likewise, but for too few arguments.
* src/logname.c: Include error.h.
(main): Say why we're failing.
* src/uniq.c (main): Don't segfault when argc < optind.
* src/who.c (main): Handle argc < optind.
* src/df.c (main): Likewise.
* src/install.c (main): Likewise.
* src/mv.c (main): Likewise.
* src/pwd.c (main): Likewise.
* src/tty.c (main): Likewise.
* src/chroot.c (main): Likewise.
* src/hostname.c: Likewise.
* src/du.c (main): Likewise.
* src/expand.c (main): Likewise.
* src/env.c (main): Likewise.
* src/unexpand.c (main): Likewise.
* src/printenv.c (main): Likewise.
* src/sync.c (main): Handle argc == 0.
* src/expr.c (main): Likewise.
* src/printf.c (main): Likewise.
* src/basename.c (main): Likewise.
* src/ln.c (main): Test for `missing argument' before computing n_files.
* src/tail.c (main): Test for the case of no arguments before
computing n_files.
* src/kill.c (send_signals): Don't check command line arguments here.
(main): Check them here instead. Handle argc < optind.
* src/logname.c (main): Use error, rather than fprintf, for the sake
of consistency.
* src/rm.c (main): Don't overrun array bound if argc is 0.
2003-05-09 Jim Meyering <jim@meyering.net>
* src/sort.c (main): Don't overrun array bound if argc is 0.
That would happen when invoked via: execl ("/usr/bin/sort", NULL);
Reported by Wartan Hachaturow.
2003-05-07 Jim Meyering <jim@meyering.net>
Implement support so that `head --lines=-N' works on seekable files.
* src/head.c (enum Copy_fd_status): Define.
(COPY_FD_DIAGNOSE): New macro.
(elide_tail_lines_seekable): New funtion.
(elide_tail_lines_file): Call it here.
2003-05-06 Jim Meyering <jim@meyering.net>
* src/sys2.h (CHAR_BIT): Remove duplicate definition.
2003-05-04 Jim Meyering <jim@meyering.net>
* tests/head/Test.pm: Remove tests of --bytes=-N; using that framework
caused the addition of thousands of small files to the tar archive.
* tests/misc/head-elide-tail: New file. Add them here instead.
* tests/misc/Makefile.am (TESTS): Add head-elide-tail.
2003-05-04 Paul Eggert <eggert@twinsun.com>
* src/remove.c (HAVE_WORKING_READDIR): Define to 0 if not defined.
(IF_READDIR_NEEDS_REWINDDIR): Remove.
(remove_cwd_entries): Rewrite to avoid IF_READDIR_NEEDS_REWINDDIR,
which was a bit weird because it couldn't be emulated by a function.
2003-05-03 Jim Meyering <jim@meyering.net>
Extend head to accept --lines=-N (--bytes=-N) and to print all
but the N lines (bytes) at the end of the file.
* src/head.c: Include full-write.h, full-read.h, inttostr.h, quote.h.
Use quote() in diagnostics, rather than literal `' marks.
(copy_fd, elide_tail_bytes_pipe, elide_tail_bytes_file):
New functions.
(elide_tail_lines_pipe, elide_tail_lines_file): New functions.
(head_file): Reorganize so as to call head from only one place.
(main): Likewise, for head_file.
Handle new, undocumented option, --presume-input-pipe.
Handle negative line and byte counts.
* tests/head/Test.pm: Add lots of tests to exercise --bytes=-N.
* tests/du/8gb: Skip test if the file system of `.' doesn't support
sparse files -- otherwise it'd create a file of size 8GB.
2003-05-02 Jim Meyering <jim@meyering.net>
* src/fmt.c (usage): Don't mention obsolescent -WIDTH option.
Instead explain about `-' and standard input.
(main): Give a proper diagnostic for e.g., `fmt -c -72'.
Reported by Keith Thompson.
* tests/fmt/basic: Add test for the above fix.
* src/fmt.c: Include "quote.h".
Use quote() in diagnostics, rather than literal `' marks.
(main): Exit nonzero when unable to open an input file.
* tests/fmt/basic: Add test for the above fix.
* src/fmt.c (main): Diagnose invalid suffix on obsolescent width
specifications like `-72x'.
* tests/fmt/basic: Add test for the above fix.
Work around nasty readdir bug on Darwin6.5.
* src/remove.c (IF_READDIR_NEEDS_REWINDDIR): Define.
[! HAVE_WORKING_READDIR] (remove_cwd_entries): If readdir has just
returned NULL and there has been at least one successful unlink or
rmdir call since the opendir or previous rewinddir, then call
rewinddir and reiterate the loop.
Factor out common code.
* src/remove.c (readdir_ignoring_dotdirs): New function.
(is_empty_dir): Use it here.
(remove_cwd_entries): Use it here.
2003-05-01 Jim Meyering <jim@meyering.net>
* tests/rm/r-3: Create 500 rather than just 300 files.
There's a bug in Darwin6.5's readdir that shows up only with
338 or more files.
Fix a bug in this test: `cd $pwd' (not to `..'), now that $tmp
has two components.
* src/tail.c:
Change type of n_units, n_bytes, n_lines to be `uintmax_t'.
(dump_remainder): Move two declarations `down' into the scope
where they are used.
(xlseek): Return the resulting offset.
(file_lines): Rename parameter, file_length, to end_pos.
(pipe_lines): Don't coerce safe_read return value to `int'.
Adapt tests accordingly.
(pipe_bytes) [struct charbuffer] (nbytes): Change type from `int'
to `unsigned int'.
Change type of `total_bytes' from `int' to `size_t',
since the former wouldn't always be wide enough.
Don't coerce safe_read return value to `int',
and adapt tests accordingly.
Now that testing for a read error no longer involves
using `tmp', handle that case *after* freeing `tmp'.
(start_bytes): Clean up.
(tail_bytes): Now that `n_bytes' may be larger than
OFF_T_MAX, test for that condition and, if it's true, don't
use lseek optimizations.
(parse_options): Don't fail just because N_UNITS is larger than
the maximum size of a file -- tail may be applied to an input
stream (e.g., a pipe) with more data than that.
* Makefile.maint (syntax-check): Rename from alloc-check.
Also check for SPACE-TAB sequences.
Also check for malloc/calloc/realloc casts.
2003-05-01 Jim Meyering <jim@meyering.net>
* src/tail.c (start_lines): Rewrite to use memchr. Clean up.
2003-04-28 Jim Meyering <jim@meyering.net>
* tests/misc/tty-eof: Send two tokens, not just one, so we don't
make the now-more-picky tsort fail.
2003-04-24 Jim Meyering <jim@meyering.net>
* src/tsort.c (tsort): Remove unnecessary test of have_read_stdin.
(main): Minor syntactic clean-up.
* src/tsort.c (tsort): Fail if the input contains an odd number of
tokens. Reported by junkio@cox.net.
* tests/tsort/basic-1: Test for the above fix.
2003-04-21 Jim Meyering <jim@meyering.net>
* tests/misc/printf: Add tests for the printf fixes below.
* Makefile.cfg (cvs_files): Add $(srcdir)/config/depcomp to the list.
2003-04-20 Paul Eggert <eggert@twinsun.com>
Fix printf POSIX compatibility bug reported by Ben Harris in
<http://mail.gnu.org/archive/html/bug-coreutils/2003-04/msg00070.html>.
* doc/coreutils.texi (printf invocation): It's \NNN in the format,
\0NNN in the %b operand.
* src/printf.c (usage): Likewise.
(print_esc): New arg OCTAL0 to specify whether \0NNN or \NNN
is desired. All uses changed. Behave like Bash printf if %b
operand uses \NNN where the initial N is not 0.
2003-04-17 Jim Meyering <jim@meyering.net>
* src/stty.c: Remove uses of PROTOTYPE macro.
2003-04-15 Jim Meyering <jim@meyering.net>
* Makefile.maint: Remove (or replace-with-TAB(s) to retain alignment)
each sequence of spaces before a TAB character.
2003-04-13 Jim Meyering <jim@meyering.net>
* src/remove.c (is_empty_dir): Don't closedir (NULL).
2003-04-12 Jim Meyering <jim@meyering.net>
Giving nl an invalid STYLE argument (in --header-numbering=STYLE (-h),
--body-numbering=STYLE (-b), or --footer-numbering=STYLE (-f)) or
FORMAT (--number-format=FORMAT (-n)) would not give a useful diagnostic.
* src/nl.c (main): Fix those problems and remove literal quote marks
(e.g., "`%s'") from format string; instead use "%s" in each format
string and `quote (optarg)' as the corresponding argument.
Also, diagnose all invalid command line options before failing.
* src/nl.c (proc_text): Fix a bug that would make nl output extra
newlines in some cases. Details here: http://bugs.debian.org/177256.
This bug was introduced on 2001-11-10 for textutils-2.0.17.
* tests/misc/nl: Add test for the above-fixed bug.
* tests/misc/readlink: New file. Test the --canonicalize option.
* tests/misc/Makefile.am (TESTS): Add readlink.
2003-04-11 Jim Meyering <jim@meyering.net>
Clean up.
* src/chown.c, src/cp.c, src/dircolors.hin, src/du.c, src/ln.c:
* src/mkfifo.c, src/ptx.c, src/spline.c, src/stty.c, src/tail.c:
* src/test.c, src/unexpand.c: Remove (or replace-with-TAB(s) to
retain alignment) each sequence of spaces before a TAB character.
* src/ls.c: Include <stdlib.h> unconditionally.
* Makefile.maint (xalloc-check): Rename from header-check.
* src/yes.c: Include error.h after system.h, not before.
Clean up.
* src/copy.c, src/cp-hash.c, src/cp.c, src/csplit.c, src/cut.c:
* src/date.c, src/df.c, src/du.c, src/expand.c, src/expr.c, src/id.c:
* src/join.c, src/md5sum.c, src/nl.c, src/od.c, src/paste.c, src/pr.c:
* src/ptx.c, src/sort.c, src/split.c, src/su.c, src/tail.c, src/tee.c:
* src/tr.c: * src/unexpand.c, src/users.c:
Remove anachronistic casts of xmalloc, xrealloc, and xcalloc
return values and of xrealloc's first argument.
Fix the former with this:
perl -pi -e 's/\([^(]*?\*\) *(x(m|c|re)alloc)\b/$1/'
2003-04-10 Jim Meyering <jim@meyering.net>
* src/stty.c (wrapf): Declare with format attribute.
The S_MAGIC_... names shouldn't be maintained in two places (prior
to this change, one would have to keep stat.c and fs.h in sync).
This change makes it so those names and the corresponding
hexadecimal constants all reside in stat.c. fs.h is now generated.
* src/Makefile.am (fs.h): New rule to generate fs.h from stat.c.
(BUILT_SOURCES): Add fs.h, now that it's generated.
(EXTRA_DIST): Add extract-magic.
* src/extract-magic: New script to extract fs.h definitions from stat.c.
* src/stat.c (human_fstype) [__linux__]: Append each hex constant from
fs.h in a comment after the corresponding `case S_MAGIC_...:' statement.
* tests/tail-2/big-4gb: Skip this test (don't fail) if creating a
file with nominal length > 4GB fails. Reported by Michael Deutschmann.
* man/unexpand.x: Add `SEE ALSO' reference to expand.
* man/expand.x: Add `SEE ALSO' reference to unexpand.
Suggestion from Dan Jacobson.
2003-04-10 Maciej W. Rozycki <macro@ds2.pg.gda.pl>
* src/fs.h (S_MAGIC_DEVPTS): New magic for Linux's devpts.
* src/stat.c (human_fstype): Handle Linux's devpts.
2003-04-09 Paul Eggert <eggert@twinsun.com>
* src/split.c (line_bytes_split): Arg is of type size_t, since
that's all that is supported for now.
(main): Check for overflow in obsolescent line count option.
2003-04-09 Jim Meyering <jim@meyering.net>
* tests/misc/split-fail: Add a new test for the above fix.
* src/split.c (bytes_split): Use size_t temporary (rather than
uintmax_t original) in remaining computations. From Paul Eggert.
Handle command line option arguments larger than 2^31.
This allows e.g., splitting into files of size 2GB and larger,
and running split --lines=N with N=2^31 or more.
But for --line-bytes=N, the restriction that N <= SIZE_MAX
remains (for now), due to the way it is implemented.
* src/split.c: Include "inttostr.h".
(bytes_split, lines_split, line_bytes_split, main):
Use uintmax_t, not size_t, for file sizes.
(main): Give a better diagnostic for option arguments == 0.
Use umaxtostr to print file sizes.
Reported by Luke Hassell.
2003-04-08 Jim Meyering <jim@meyering.net>
* src/rm.c (usage): Mention that --directory (-d) works only
on some systems. Suggestion from Samuel Tardieu.
* tests/basename/basic: Run $PERL to see if it is available,
rather than testing its value.
* tests/sum/sysv, tests/tsort/basic-1, tests/unexpand/basic-1:
* tests/basename/basic, tests/dd/skip-seek, tests/dircolors/simple:
* tests/expr/basic, tests/factor/basic, tests/fmt/basic:
* tests/ls-2/tests, tests/md5sum/basic-1, tests/md5sum/newline-1:
* tests/misc/sort, tests/misc/tty-eof, tests/mv/i-1:
* tests/rm/empty-name, tests/rm/fail-eperm, tests/rm/unreadable:
* tests/seq/basic, tests/sha1sum/basic-1, tests/sha1sum/sample-vec:
* tests/sum/basic-1, tests/seq/basic: Likewise.
* tests/misc/Makefile.am (TESTS): Add split-fail.
* tests/misc/split-fail: New file.
* src/split.c: Rename local variables: nchars -> n_bytes.
(lines_split): Rename local, nlines -> n_lines.
(main): Rename local variable: s/accum/n_units/.
(main): Use STDIN_FILENO, not literal `0'.
2003-04-07 Jim Meyering <jim@meyering.net>
* src/stat.c: Add #include directives for Ultrix 4.4.
Based on a suggested change from Bert Deknuydt.
2003-04-06 Jim Meyering <jim@meyering.net>
* Makefile.maint (makefile-check): New rule.
(local-check): Add it.
2003-04-05 Jim Meyering <jim@meyering.net>
* Makefile.am (nearly all of them):
Use $(VAR) rather than @VAR@, now that we can rely on automake to
emit a definition for each substituted variable.
* tests/Makefile.am.in: Likewise.
* tests/rm/rm5: Add a comment explaining why this test fails when
using Tru64's broken sed.
* tests/rm/rm3: Likewise.
Make `kill -t' output signal descriptions (not `?') on Tru64.
* src/kill.c (sys_siglist): Also check for __sys_siglist.
Patch by Tony Leneis.
* configure.ac: Also check for declaration of __sys_siglist.
Required for Tru64 4.0D, 4.0F, and 5.1.
Reported by Tony Leneis.
2003-04-04 Jim Meyering <jim@meyering.net>
* src/Makefile.am (PERL): Remove unnecessary definition.
Because of inappropriate (but POSIX-mandated) behavior of rename,
`mv a b' would not remove `a' in some unusual cases. Work around
this by unlinking `a' when necessary.
* src/copy.c (same_file_ok): Add an output parameter.
Set it in the offending case.
(copy_internal): When necessary, unlink SRC_PATH and inform caller.
Reported by Ed Avis.
* tests/mv/hard-4: New test for the above.
* tests/mv/Makefile.am (TESTS): Add hard-4.
Clean up rules for automatically generated sources:
* src/Makefile.am (dircolors.h, wheel-size.h, wheel.h, false.c):
Make each generated file be read-only.
Add each file name to BUILT_SOURCES separately.
(MAINTAINERCLEANFILES): Set to $(BUILT_SOURCES).
Put LOCALEDIR macro definition in new file: localedir.h.
* src/Makefile.am (DEFS): Remove definition.
(localedir.h): New rule.
(BUILT_SOURCES, DISTCLEANFILES): Add localedir.h.
* src/system.h: Include "localedir.h".
2003-04-02 Jim Meyering <jim@meyering.net>
* Version 5.0.
* tests/misc/Makefile.am (TESTS): Add false.
* Makefile.maint (TMPDIR): Make sure it's defined.
(my-distcheck): Build in $(TMPDIR), not `.'.
* src/Makefile.am (false.c): Change all occurrences of
`(EXIT_SUCCESS)' to `(EXIT_FAILURE)' so that false exits
unsuccessfully also with --help. Reported by Paul Jarc,
* tests/misc/false: New test for the above.
2003-03-30 Jim Meyering <jim@meyering.net>
* NEWS: Note the location of older NEWS files.
* src/remove.c (is_empty_dir): Don't let a failing closedir
clobber errno. Spotted by Arnold Robbins.
* src/env.c: Fix typo in comment. From Arnold Robbins.
2003-03-29 Jim Meyering <jim@meyering.net>
* Version 4.5.12.
* README: Note to expect build problems for stat.c on Ultrix 4.3.
Note that there are some harmless test failures when running
`make check' as root on some systems.
2003-03-28 Jim Meyering <jim@meyering.net>
* tests/stty/row-col-1: Skip this test if stty can't get window size.
This happens when connecting to sparc-solaris2.7 via ssh from within
emacs. Reported by Karl Berry.
* tests/du/basic: Use seq, not `yes' to generate 4KB of data.
Otherwise, on systems (DJGPP) that emulate pipes using files,
this test would never complete, waiting for `yes' to terminate.
* tests/du/slink: As above, use seq, not `yes' to generate link target.
* tests/rm/hash: As above, use seq, not `yes' to generate dir name.
Reported by Rich Dawe.
2003-03-27 Jim Meyering <jim@meyering.net>
* src/id.c: Remove Arnold Robbins' obsolete e-mail address
from `written by...' comment, at his request.
2003-03-24 Paul Eggert <eggert@twinsun.com>
Fix buffer overrun problem reported by TAKAI Kousuke, along
with some other POSIX incompatibilities.
* src/printf.c (print_esc): Do not treat \x specially if
POSIXLY_CORRECT. Avoid buffer overrun if the format ends
in backslash. Treat incomplete escape sequences as strings
of characters, as POSIX requires.
(print_formatted): Allow multiple flags. Avoid buffer overrun
if the format is incomplete.
2003-03-24 Jim Meyering <jim@meyering.net>
* tests/misc/printf: Add tests for the above fixes and changes.
2003-03-26 Jim Meyering <jim@meyering.net>
* src/copy.h (struct cp_options): Add a comment.
2003-03-23 Jim Meyering <jim@meyering.net>
* README: Describe problem with 64-bit mode on HPUX 11.x,
with patch for /usr/include/inttypes.h.
* TODO: Plan to add an autoconf test to work around the bug.
2003-03-22 Jim Meyering <jim@meyering.net>
* src/stat.c: Don't include <sys/sysmacros.h>.
That is already done via system.h. Otherwise, the multiple
inclusion would evoke redefinition warnings from Cray's /bin/cc,
aka Cray Standard C Version 4.0.3 (057126) Mar 22 2003 22:02:28.
(human_fstype): Factor some directives `up', out of this function.
Cast away `const' to avoid error from Cray's /bin/cc.
2003-03-20 Jim Meyering <jim@meyering.net>
* announce-gen (print_changelog_deltas): Ensure that a newline
precedes each row of `*'s.
2003-03-20 Jim Meyering <jim@meyering.net>
* Version 4.5.11.
* src/seq.c (valid_format): Also accept ` ' and `'' as valid
format flag characters.
Do not require that a field width be specified.
Do not fail when given a field width of `0'.
Reported by Dan Jacobson.
* tests/seq/basic: Add new tests for the above-fixed bug.
* src/Makefile.am (all-local): Append $(EXEEXT) to use of `su'
(install-root): Likewise.
(install-exec-local): Likewise.
Based on a patch from Richard Dawe.
2003-03-19 Jim Meyering <jim@meyering.net>
* man/Makefile.am (.x.1): Use $(LN_S) instead of 'ln -s',
because the DJGPP 2.03 port of 'ln -s' doesn't work.
Include $(EXEEXT) in program names.
Since $(LN_S) may degenerate to `cp -p', be careful
to invoke it from the destination directory.
Mostly from Richard Dawe.
* configure.ac: Use AC_PROG_LN_S.
* tests/mv/part-symlink: Unset CDPATH. Otherwise, having the
CDPATH shell variable set could cause this test to fail.
Reported by Karl Berry.
2003-03-18 Jim Meyering <jim@meyering.net>
* src/fmt.c [struct Word] (paren, period, punct, final): Change the
type of each member from bool <MEMBER>:1 to unsigned int <MEMBER>:1.
AIX 5.1's xlc could not compile the former.
Patch by Petter Reinholdtsen. Also reported by Mike Jetzer.
2003-03-17 Richard Dawe <rich@phekda.freeserve.co.uk>
* configure.ac: Include $(EXEEXT) in OPTIONAL_BIN_PROGS'
program names, since automake only adds $(EXEEXT) to programs
in its *_PROGRAMS.
2003-03-16 Jim Meyering <jim@meyering.net>
* src/remove.c (rm): Put two local variables in static storage,
so they can't be clobbered by the potential longjmp.
2003-03-15 Jim Meyering <jim@meyering.net>
* Makefile.cfg (gnu_rel_host): Fix code to match the comment
so that a version number with a two-digit component can still count
as an alpha release. Reported by Richard A Downing.
(gnu_rel_host): Define in terms of $(RELEASE_TYPE) instead.
2003-03-14 Jim Meyering <jim@meyering.net>
* src/ansi2knr.c: Remove no-longer-used file.
* src/ansi2knr.1: Likewise.
* Makefile.maint (prev_version_file): Don't use ?= for this particular
assignment, since it causes trouble with old versions of GNU make
(e.g. 3.76.1). The other uses of `?=' are inoffensive. Details here.
http://mail.gnu.org/archive/html/bug-coreutils/2003-03/msg00028.html
Patch from Alexandre Duret-Lutz.
* Use patched automake-1.7.3. Regenerate Makefile.in files in
subdirectories so that each includes a definition of ACLOCAL_M4.
* announce-gen (main): Label the compressed source URLs.
* Version 4.5.10.
* tests/du/slink: Relax the test for the `local'ness of a file system,
so that now it works also for tmpfs.
* tests/du/hard-link: Transform output from first du, so that this
test doesn't fail on file systems like tmpfs that order directory
entries differently.
2003-03-13 Jim Meyering <jim@meyering.net>
* tests/du/8gb: Work around what appears to be an NFS failure that
would make this test fail on some systems.
2003-03-11 Jim Meyering <jim@meyering.net>
* tests/du/basic: Make the test file exactly 4k bytes long.
* src/split.c (longopts): Don't hard-code `2' here.
Instead, just specify `&verbose', and ...
(main): ... remove the `case 2:' block for --verbose.
* tests/du/basic: Make the test file larger than 64 bytes, so that
we don't immediately disqualify file systems (e.g., NetApp) on which
smaller files take up zero disk blocks. Reported by Vin Shelton.
2003-03-10 Jim Meyering <jim@meyering.net>
Don't segfault for a negative field width or precision in format string.
Note that this is just a stopgap fix. The longer term solution may
involve adapting bash's builtins/printf.def.
* src/printf.c: (UNSPECIFIED): Define.
(print_direc): Use the special value, UNSPECIFIED, to indicate
that field_width or precision has not been specified.
(print_formatted): Fail if field_width or precision is the
special value, UNSPECIFIED.
Reported by Oliver Kiddle <okiddle@yahoo.co.uk>
* src/sys2.h (INT_MIN): Define, if necessary.
* tests/misc/printf: Add a test for the above-fixed bug.
2003-03-09 Jim Meyering <jim@meyering.net>
* src/remove.c (AD_stack_pop): Cast sizeof... to int before
changing its sign. This avoids a warning from gcc on 64-bit systems.
Reported by Bob Proulx.
(pop_dir): Reverse order of sign change and cast, to be consistent
with the above.
2003-03-08 Jim Meyering <jim@meyering.net>
* tests/Makefile.am (evar-check): Check for POSIXLY_CORRECT not as a
shell variable, but only in the environment. With /bin/sh->bash, the
shell variable is set to `y', and that would cause a spurious warning.
Reported by Bob Proulx.
* tests/Makefile.am (check-root): Remove touch/fifo.
It doesn't appear to have to be run as root.
* tests/rm/fail-2eperm: Rather than simply using the first non-root
user name, make sure that the selected user name has a usable shell.
Reported by Paul Jarc.
Before, when using shred on a device, one had to specify --exact,
or be careful to choose a size that would not be rounded up and
exceed the maximum value; that could result in a failure of
the final write.
* src/shred.c (do_wipefd): --exact is now the default for non-regular
files. Suggestion from Ben Elliston.
(usage): Say it.
* tests/misc/tty-eof: Require at least version 1.11 of Expect.pm.
Old versions of Expect.pm (e.g., 1.07) lack the log_user function.
Patch by Bob Proulx.
* src/Makefile.am (check-misc): Check for use of `defined' in
#define directives.
Change to $(srcdir) before running grep.
* src/sleep.c: Remove now-unused #include and #define directives.
* src/du.c (process_file): If a file's size is not being counted
e.g., because it's a hard link to a file we've already counted,
then don't print a line for it.
* tests/du/hard-link: New test for the above-fixed bug.
* tests/du/Makefile.am (TESTS): Add hard-link.
`du -S' didn't work
* src/du.c: Revert most of the `reorganization' change of 2003-02-20,
and make the two-array approach work.
* tests/du/basic: Correct/add tests for the above fix.
Set LC_ALL, etc., now that we use sort.
Check the block/size of a small file, too.
Correct expected results for simple dir1/dir2/file case.
Add another test of du -S.
2003-03-07 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
Avoid build failure with gcc on hppa1.1-hp-hpux10.20 (see GCC PR
middle-end/9986). As one of GCC's optimizations, it transforms a
fputs_unlocked call to a fputc_unlocked call when the string is
one character long. However, hpux doesn't have fputc_unlocked.
* expr.c (usage): Use putchar, not fputs, to output a single character.
* ls.c (dired_dump_obstack): Likewise.
* ptx.c (output_one_tex_line, output_one_dumb_line): Likewise.
* stat.c (print_it): Likewise.
2003-03-07 Jim Meyering <jim@meyering.net>
* src/cp.c: Remove everything associated with mmap-stack.c.
This reverts the two changes of 2003-02-21.
* src/du.c: Remove everything associated with mmap-stack.c.
This reverts the change of 2003-02-19.
2003-03-06 Jim Meyering <jim@meyering.net>
* tests/cp/same-file: Unset CDPATH. Otherwise, having the
CDPATH shell variable set could cause this test to fail.
Reported by Karl Berry.
2003-03-05 Jim Meyering <jim@meyering.net>
* Version 4.5.9.
* src/printf.c (print_esc): Remove pointless comparison of unsigned
integer with zero, to avoid a warning from Intel's ecc.
Reported by Nelson Beebe.
* src/du.c (process_file): Sizes must all be of type uintmax_t.
Otherwise, for files or totals that are too big, numbers would
be truncated. Patch mostly by Michael Stone.
Reported by Ingo Saitz as Debian bug #183210.
* tests/du/8gb: New test for the above-fixed bug.
* tests/du/Makefile.am (TESTS): Add 8gb.
* src/du.c (MAX_N_DESCRIPTORS): Use 3 * UTILS_OPEN_MAX / 4
rather than UTILS_OPEN_MAX - 10.
2003-03-04 Jim Meyering <jim@meyering.net>
* README: Refer new feature discussion to bug-coreutils@gnu.org,
rather than bug-gnu-utils, now that the former is better known.
Suggestion from Göran Uddeborg.
* src/stat.c (usage): Capitalize consistently.
Reported by Göran Uddeborg.
* Makefile.maint (rel-files): Include $(signatures), so that
those files are also copied into $(release_archive_dir).
* src/df.c (find_mount_point): Call error here, now that restore_cwd
no longer does it.
* src/remove.c (AD_pop_and_chdir): Likewise.
* tests/Makefile.am (check-root): Add fail-2eperm.
2003-03-03 Jim Meyering <jim@meyering.net>
* src/remove.c (remove_cwd_entries): Include the full filename of
the offending file, not just the basename.
* tests/misc/tty-eof: Set $ME properly.
* Makefile.maint (THIS_VERSION_REGEXP, PREV_VERSION_REGEXP):
Remove now-unused variables.
(tag-prev-version, prev-cvs-tag): Likewise.
* src/remove.c (remove_cwd_entries) [!ROOT_CAN_UNLINK_DIRS]: Give an
accurate diagnostic when failing to remove a file owned by some other
user. Reported by Ivo Timmermans via Michael Stone.
This fixes Debian bug# 178471.
* tests/rm/Makefile.am (TESTS): Add fail-2eperm.
* tests/rm/fail-2eperm: New test, for the above-fixed bug.
Based on a report from Ivo Timmermans.
2003-03-02 Jim Meyering <jim@meyering.net>
* src/copy.c (copy_internal) [un_backup]: When recovering from a
failure to create a hard link, do not remove the entry associating
the source dev/ino with the destination file name.
* tests/mv/Makefile.am (TESTS): Add hard-3.
* tests/mv/hard-3: New test, for the above-fixed bug.
Inspired by a report from Iida Yosiaki.
2003-03-01 Jim Meyering <jim@meyering.net>
* src/df.c (print_header): Don't embed spaces in a separate `Type'
header string. Instead, put `Filesystem' and `Type' headers in the
same string, so translators can use horizontal space as needed.
Reported by Jean Charles Delepine.
2003-02-28 Jim Meyering <jim@meyering.net>
* src/copy.c (copy_internal): When link fails because of an
existing destination file, unlink that file and try again.
Reported by Iida Yosiaki.
* tests/mv/Makefile.am (TESTS): Add hard-2.
* tests/mv/hard-2: New test for the above-fixed bug.
Based on a test case from Iida Yosiaki.
2003-02-26 Jim Meyering <jim@meyering.net>
* tests/du/basic: Don't test du's -b option here. Directory byte
counts are smaller (512 rather than 4096) on at least OSF/1 5.1
and IBM AIX 4.2. Reported by Nelson Beebe.
2003-02-25 Jim Meyering <jim@meyering.net>
* Makefile.maint (announcement): Now that ChangeLog entries
are output by announce-gen, don't do it here.
* announce-gen (print_changelog_deltas): New function.
(main): Use it.
2003-02-22 Jim Meyering <jim@meyering.net>
* announce-gen: New option: --release-type=TYPE
* Makefile.maint (beta, major): New targets. Remove `release'.
Put them all together on a line.
Pass the release type (via RELEASE_TYPE envvar) to the MAKE
invocation of `announcement'.
(announcement): Invoke announce-gen with --release-type=$RELEASE_TYPE.
* announce-gen: New option: --news=NEWS_FILE.
Extract NEWS entries here, not via rules in Makefile.maint.
* Makefile.maint (announcement): Now that NEWS entries are
extracted by announce-gen, don't do it here.
(news-r1, news-r2): Remove now-unused definitions.
2003-02-21 Jim Meyering <jim@meyering.net>
* Version 4.5.8.
Merge in changes from autoconf's version of this file.
* Makefile.maint (www-gnu): Define.
(standards.texi-url_prefix): Use $(www-gnu).
(make-stds.texi-url_prefix): Likewise.
* src/cp.c: Include "mmap-stack.h".
(main): Invoke `run' through a macro that (when possible) runs it
with a large, mmap'd stack.
* src/cp.c (run): New function, preparing for the above.
Exit from this function, not from main
(main): Call run.
* src/du.c: New option: --apparent-size.
(enum) [APPARENT_SIZE_OPTION]: New member.
(long_options): Add it.
(usage): Describe it.
(main): Handle it.
['b']: Set apparent_size.
David Eisner reported that the behavior of --bytes had changed.
Paul Eggert proposed the use of a new option, --apparent-size.
* src/du.c (apparent_size): New global.
(print_only_size): Reflect the fact that we're printing byte counts,
not ST_NBLOCKSIZE-byte-block counts.
(print_size): Call print_only_size rather than duplicating its code.
(process_file): Accumulate byte counts, rather than block counts.
* src/du.c (process_file): Always reset size_to_propagate_to_parent
for --separate-dirs (-S).
2003-02-20 Jim Meyering <jim@meyering.net>
* Use automake-1.7.3. Regenerate dependent files.
* src/stat.c (print_stat): New format: %B (to print ST_NBLOCKSIZE).
This makes %b (number of ST_NBLOCKSIZE-byte blocks) more useful.
(usage) [%B]: Describe it.
[%b]: Refer to %B.
* src/du.c (process_file): Reorganize the code to use only
one `sum' array, and change how -S works back to the way it was
before 2003-01-31. Patch by Bruno Haible.
* tests/du/basic: New test.
* tests/du/Makefile.am (TESTS): Add basic.
* tests/envvar-check: Add checks for the following:
BLOCK_SIZE, DU_BLOCK_SIZE, DF_BLOCK_SIZE, LS_BLOCK_SIZE.
* tests/Makefile.am: Rename phony target envvar-check to evar-check
so as not to conflict with the distributed file by the same name.
* src/du.c (process_file): Set info->skip before any possible return.
Report correct usage for directories, not 0.
* src/du.c (process_file): Return for `file_type == FTW_DPRE'
_before_ recording the dev/ino of a directory.
Reported by Bruno Haible.
Now, df always displays the device file name corresponding to the
listed mount point under `Filesystem'. Before, for an unmounted
block- or character-special file argument, it would display the
command-line argument instead.
* src/df.c (show_disk): Return a value indicating whether
there was a match. Don't try to find a mount point here.
(show_entry): If show_disk doesn't find a match, call show_point.
2003-02-19 Jim Meyering <jim@meyering.net>
* src/du.c: Include "mmap-stack.h".
(du_files): Add prototype with ATTRIBUTE_NORETURN.
Exit from this function, not from...
(main): ...here.
Instead, if possible, invoke du_files through a macro that
runs it with a large, mmap'd stack.
* src/join.c (usage): Change wording in --help output:
use FILENUM instead of `SIDE' and say what FILENUM means.
Reported by Bernhard Gabler.
* src/df.c (print_header): Rather than using a hard-coded literal
string of spaces matching the length of the English `...Type' header,
output the right number of spaces to match the selected translation.
Reported by Yann Dirson and Jean Charles Delepine as Debian bug 131113.
* src/split.c (bytes_split): Remove unnecessary `else' after break.
(lines_split): Likewise. and correct misleading indentation.
* src/split.c: Include "full-read.h".
(bytes_split, lines_split, line_bytes_split): Use full_read,
not safe_read. The way split was using the latter, a short read
could cause split to terminate before EOF.
* tests/misc/tty-eof: Test all programs that can read stdin,
requiring no arguments and that write to standard output.
* tests/misc/tty-eof: New file. Renamed from ...
* tests/misc/cat-tty-eof: Remove file. Rename to tty-eof.
* tests/misc/Makefile.am (TESTS): Reflect renaming.
2003-02-18 Jim Meyering <jim@meyering.net>
cksum would perform an extra read after encountering EOF
* src/cksum.c (cksum): Exit the loop upon EOF, too.
Patch by Michael Bacarella.
Test for the bug fixed today in cksum, md5sum, and sha1sum.
* tests/misc/cat-tty-eof: Generalize, clean-up, and test for
cat, cksum, md5sum, and sha1sum all in the same loop.
2003-02-14 Jim Meyering <jim@meyering.net>
* src/remove.c: Include "euidaccess.h".
Remove declaration of euidaccess.
2003-02-12 Jim Meyering <jim@meyering.net>
* src/pathchk.c (portable_chars_only): Remove unnecessary `const'
in cast to avoid warning from icc. Reported by Alexandre Duret-Lutz.
2003-02-10 Jim Meyering <jim@meyering.net>
* src/test.c: Don't include group-member.h.
Include euidaccess.h.
(eaccess): Rewrite function to set the real uid and gid temporarily
to the effective uid and gid, then invoke 'access', and then set the
real uid and gid back. On systems that lack setreuid or setregid,
fall back on the kludges in euidaccess. Before, it would not work
for e.g., files with ACLs, files that were marked immutable,
or on file systems mounted read-only. Nelson Beebe raised the issue.
Paul Eggert suggested the new implementation.
2003-02-09 Jim Meyering <jim@meyering.net>
* src/test.c (test_stat): Remove function. It's job is done (only
when necessary) by the wrapper in lib/stat.c. Adjust all uses.
2003-02-08 Jim Meyering <jim@meyering.net>
* Version 4.5.7.
* tests/mv/part-symlink: Don't assume that the file owner username
length is less than 9 in ls output: instead, omit that field
altogether. Reported by, and suggested fix from, Ferdinand.
* tests/du/restore-wd: New test for just-fixed bug in ftw.c.
* tests/du/Makefile.am (TESTS): Add restore-wd.
* src/rm.c: Correct now-invalid comment about cycle-detection.
2003-02-06 Jim Meyering <jim@meyering.net>
* NEWS: Add entries from old/*/NEWS
from fileutils-4.1 through 4.1.11 and
from sh-utils-2.0 through 2.0.15. Suggestion from Karl Berry.
* Version 4.5.6.
* src/du.c (process_file): Don't return early for excluded files
or for files whose dev/inode we've already seen.
2003-02-05 Jim Meyering <jim@meyering.net>
* tests/du/exclude: New file.
* tests/du/Makefile.am (TESTS): Add exclude.
2003-02-04 Dmitry V. Levin <ldv@altlinux.org>
* src/who.c (print_boottime, print_deadprocs, print_runlevel):
Fix memory allocation arithmetic.
2003-02-04 Jim Meyering <jim@meyering.net>
`df /dev/block-or-char-device-file--not-mounted' now reports
the name of the file system on which the file resides, usually `/'.
Before, it would leave the `Mounted on' field blank.
* src/df.c (show_disk): Move function to precede find_mount_point.
(show_disk): Add parameter: STATP.
If we don't find a matching device name, then resort to calling
find_mount_point. Reported by Bob Proulx.
2003-02-03 Andreas Schwab <schwab@suse.de>
* tests/rm/cycle: Require non-root.
* tests/rm/isatty: Likewise.
2003-02-02 Jim Meyering <jim@meyering.net>
* Version 4.5.5.
* man/Makefile.am (check-x-vs-1): Use @PATH_SEPARATOR@, not `:'.
Ensure that there are no offending uses of `:'.
* Makefile.maint (makefile_path_separator_check): New rule.
(local-check): Add it to the list.
2003-02-01 Jim Meyering <jim@meyering.net>
* src/du.c (MAX_N_DESCRIPTORS): Define.
* src/stat.c (G_fail): New global.
(human_time): Diagnose failed localtime, not failed nstrftime.
(main): Fail if G_fail is set.
2003-01-31 Richard Dawe <rich@phekda.freeserve.co.uk>
* tests/basename/Makefile.am: Use @PATH_SEPARATOR@ instead of
hard-coding the path-separator. Also double-quote the new PATH,
to avoid problems when the path-separator is a semi-colon or when
`pwd` contains e.g. a space.
* tests/chgrp/Makefile.am: Likewise.
* tests/chmod/Makefile.am: Likewise.
* tests/chown/Makefile.am: Likewise.
* tests/cp/Makefile.am: Likewise.
* tests/dd/Makefile.am: Likewise.
* tests/dircolors/Makefile.am: Likewise.
* tests/du/Makefile.am: Likewise.
* tests/expr/Makefile.am: Likewise.
* tests/factor/Makefile.am: Likewise.
* tests/fmt/Makefile.am: Likewise.
* tests/install/Makefile.am: Likewise.
* tests/ln/Makefile.am: Likewise.
* tests/ls/Makefile.am: Likewise.
* tests/ls-2/Makefile.am: Likewise.
* tests/md5sum/Makefile.am: Likewise.
* tests/misc/Makefile.am: Likewise.
* tests/mkdir/Makefile.am: Likewise.
* tests/mv/Makefile.am: Likewise.
* tests/od/Makefile.am: Likewise.
* tests/rm/Makefile.am: Likewise.
* tests/rmdir/Makefile.am: Likewise.
* tests/seq/Makefile.am: Likewise.
* tests/sha1sum/Makefile.am: Likewise.
* tests/shred/Makefile.am: Likewise.
* tests/stty/Makefile.am: Likewise.
* tests/sum/Makefile.am: Likewise.
* tests/tail-2/Makefile.am: Likewise.
* tests/touch/Makefile.am: Likewise.
* tests/tsort/Makefile.am: Likewise.
* tests/unexpand/Makefile.am: Likewise.
2003-01-31 Jim Meyering <jim@meyering.net>
* src/stat.c: Include "file-type.h"
(print_human_type): Remove function.
(human_access): Rename from print_human_access. Return a string.
(human_time): Rename from print_human_time. Return a string.
(print_stat): Arrange so that field width and an alignment specifier
are honored for the %A, %F, %x, %y, and %z formats.
[%F]: Use file_type; this gives slightly different file type strings,
e.g., `directory' instead of `Directory' and `regular file' or
`regular empty file' instead of `Regular file'.
Prompted by a report from Richard Dawe that the uses of
S_IFSOCK and S_IFIFO in print_human_time were not portable
to systems using e.g., DJGPP.
2003-01-31 Richard Dawe <rich@phekda.freeserve.co.uk>
* src/stat.c (print_stat): Use S_ISLNK rather than an explicit
test using S_IFMT and S_IFLNK. S_IFLNK may not be defined.
2003-01-31 Jim Meyering <jim@meyering.net>
* src/du.c (main): Upon processing an invalid option or an invalid
--exclude-from or --max-depth option argument, don't exit right away,
in case there are others. Rather record the failure and exit after
processing other options.
* GNUmakefile (TAR_OPTIONS): Set and export, in order to make
tar archive easier to reproduce.
Rewrite to perform directory traversal using nftw.
* src/du.c: Include "dirname.h", "ftw.h", and "quotearg.h".
(AUTHORS): Add self.
(opt_one_file_system): Move global into `main'.
(path, xstat, exit_status): Remove declarations.
(arg_length, suffix_length): New globals.
(G_fail): New global, sort of like the old `exit_status'.
(IS_FTW_DIR_TYPE): Define.
(print_only_size): New function.
(process_file): New function.
(str_init, ensure_space, str_copyc, str_concatc): Remove functions.
(str_trunc, pop_dir, count_entry): Likewise.
(du_files): Rewrite to use nftw.
2003-01-30 Jim Meyering <jim@meyering.net>
* tests/du/trailing-slash: Ensure that du/ftw follows a command-line
symlink-to-directory with -L, even without the trailing slash.
2003-01-27 Jim Meyering <jim@meyering.net>
* src/Makefile.am (check-misc): Check for st_blocks, too.
* src/stat.c (print_stat): Use ST_NBLOCKS rather than `->st_blocks'.
Reported by Richard Dawe.
2003-01-27 Andreas Schwab <schwab@suse.de>
* src/ls.c (quote_name): Add fourth parameter, width, into which to
store the screen columns, and return the number of bytes instead.
(print_dir): Pass NULL as fourth parameter of quote_name.
(print_name_with_quoting): Likewise.
(length_of_file_name_and_frills): Get the width from the fourth
parameter of quote_name instead of return value.
2003-01-27 Jim Meyering <jim@meyering.net>
* src/ls.c (decode_switches): If `dired' is set without
`format == long_format', then silently reset dired. This doesn't
change the behavior of ls (all prior uses of dired were protected
by `&& format == long_format'), and lets us...
(DIRED_INDENT): ... remove the `format == long_format' conjunct.
(PUSH_CURRENT_DIRED_POS): Likewise.
(main): Likewise.
2003-01-22 Jim Meyering <jim@meyering.net>
* tests/du/no-x: New test, for functionality added to lib/ftw.c.
* tests/du/Makefile.am (TESTS): Add no-x.
2003-01-21 Jim Meyering <jim@meyering.net>
* src/remove.c (remove_entry) [ROOT_CAN_UNLINK_DIRS
&& HAVE_STRUCT_DIRENT_D_TYPE]: If a file has d_type == DT_UNKNOWN
it may still be a directory -- or not (e.g., with FreeBSD on an
NFS-mounted file system), so resort to calling lstat to find out.
Based on a patch by Michael van Elst.
* tests/cp/same-file: Don't assume that the file owner username
length is less than 9 in ls output: instead, omit that field
altogether. Reported by, and suggested fix from, Ferdinand.
2003-01-20 Jim Meyering <jim@meyering.net>
* tests/date/Test.pm (wide-fmt): New test to demonstrate that
large format widths no longer cause strftime to infloop.
* Makefile.maint (mail_gpg_sign_cookie): Remove now-unused definition.
2003-01-19 Jim Meyering <jim@meyering.net>
* src/readlink.c: Include "canonicalize.h".
2003-01-18 Jim Meyering <jim@meyering.net>
* src/ls.c (Dereference_symlink) [DEREF_COMMAND_LINE_SYMLINK_TO_DIR]:
New member.
(enum) [DEREFERENCE_COMMAND_LINE_SYMLINK_TO_DIR_OPTION]: New member.
(long_options): Add option --dereference-command-line-symlink-to-dir.
(main): Make DEREF_COMMAND_LINE_SYMLINK_TO_DIR be the default,
rather than DEREF_COMMAND_LINE_ARGUMENTS, when none of the
-d, -F, -l options is specified.
(decode_switches): Handle --dereference-command-line-symlink-to-dir.
(gobble_file): Honor DEREF_COMMAND_LINE_SYMLINK_TO_DIR.
Change --dereference-command-line (-H) to dereference *all*
command line arguments, including broken symlinks.
2003-01-15 Paul Eggert <eggert@twinsun.com>
Change ls -H back to the way it was yesterday, since this is
compatible with FreeBSD and the POSIX spec is confusing
and somewhat contradictory.
* src/ls.c (DEREF_COMMAND_LINE_ARGUMENTS): Change name back
from DEREF_COMMAND_LINE_SYMLINK_TO_DIR, updating all uses.
(long_options): Change the long option name back.
(usage): Change the usage back.
(gobble_file): When -H is specified, dereference a top-level
arg even if it points to a non-directory.
2003-01-15 Jim Meyering <jim@meyering.net>
* src/ls.c (gobble_file): Fall back on using lstat when required:
when --dereference (-L) is not specified, and
- when operating on a dangling symlink
- when operating on command-line-symlink-to-directories
This fixes numerous problems. Here are examples:
- `ls dangling-symlink' would fail with `no such file...'
Now it prints `dangling-symlink'.
- `ls -i symlink' would mistakenly print the inode of the referent.
Now it prints the inode of the symlink. Likewise for --size (-s).
Based on a patch from Michael Stone.
Reported by Deepak Goel as Debian bug #173793.
Rename ls's --dereference-command-line (-H)
option to --dereference-command-line-symlink-to-dir.
* src/ls.c [enum Dereference_symlink]
(DEREF_COMMAND_LINE_SYMLINK_TO_DIR): Rename from
DEREF_COMMAND_LINE_ARGUMENTS. Update all uses.
(long_options): Rename the long option.
(usage): Say that --dereference-... changes how ls treats
only symlinks to directories specified on the command line.
2003-01-14 Jim Meyering <jim@meyering.net>
* tests/ls/dangle: New file/test, for the above fix.
* tests/ls/inode: Another new file/test, for the above fix.
* tests/ls/Makefile.am (TESTS): Add dangle and inode.
* src/ls.c (gobble_file): Fix a bug introduced in 4.5.4 that made it
so that ls --color would no longer highlight the names of files with
the execute bit set when not specified on the command line.
Patch by Michael Stone. Reported by Stephen Depooter as
Debian bug 175135.
* tests/ls-2/tests (color-exe): New test, for the above fix.
2003-01-13 Jim Meyering <jim@meyering.net>
* tests/shred/exact: Also test for just fixed bug with --zero.
* src/shred.c (long_opts): --zero does not require an argument.
Patch by Michael Stone. Reported by Roland Turner as Debian bug 172019.
2003-01-12 Jim Meyering <jim@meyering.net>
* Makefile.maint (cvs-update): Skip any file with local modifications.
* src/unexpand.c (usage): Document --first-only and mention that
--tabs=N (-t) enables --all (-a). Reported by wiregauze@yahoo.com.
2002-12-01 Dmitry V. Levin <ldv@altlinux.org>
* src/df.c: Include "canonicalize.h".
Use canonicalize_file_name unconditionally.
2003-01-09 Jim Meyering <jim@meyering.net>
* README: Add readlink.
2002-11-30 Dmitry V. Levin <ldv@altlinux.org>
* src/df.c: Include "xgetcwd.h".
* src/pwd.c: Likewise.
2002-11-30 Dmitry V. Levin <ldv@altlinux.org>
* src/shred.c: Remove declaration of xstrdup.
We already get it via xalloc.h which is included via system.h.
2002-08-27 Dmitry V. Levin <ldv@altlinux.org>
New program: readlink.
* src/Makefile.am (bin_PROGRAMS): Add readlink.
* src/readlink.c: New file.
* man/readlink.x: New file.
* man/Makefile.am (dist_man_MANS): Add readlink.1.
(readlink.1): New rule.
2003-01-09 Jim Meyering <jim@meyering.net>
When selecting ranges of byte offsets (as opposed to ranges of fields)
and when --output-delimiter=STRING is specified, output STRING between
ranges of selected bytes.
* src/cut.c (RANGE_START_SENTINEL): Define.
(output_delimiter_specified): New global.
(print_kth): Add parameter. Adjust all callers.
(set_fields): Mark each range-start index with RANGE_START_SENTINEL.
(cut_bytes): When requested, output STRING between ranges of
selected bytes.
(main): Make a diagnostic a little clearer.
Based on a patch from Jan Nieuwenhuizen.
* tests/cut/Test.pm: New tests for the above.
* src/cut.c (set_fields): Make code agree with comment:
Don't merge abutting ranges like 4- and 2-3. This makes no
difference currently, but is required to support an upcoming change.
2003-01-07 Jim Meyering <jim@meyering.net>
* src/cut.c (set_fields): Fix typo in comment.
* tests/touch/not-owner: New test, mostly extracted from fail-diag.
* tests/touch/Makefile.am (TESTS): Add not-owner.
* tests/touch/fail-diag: Remove the test for non-owner diagnostic.
Now, this tests only the nonexistent-directory diagnostic.
Suggestion from Michael Stone.
* tests/touch/fail-diag: Fix typo: s/ld/ls/.
2003-01-04 Jim Meyering <jim@meyering.net>
* src/copy.h: Remove use of PARAMS.
* src/remove.h: Likewise.
* src/chown-core.h: Likewise.
rm could be tricked into mistakenly reporting a cycle.
* src/remove.c: [cycle_check_state]: New global.
(remove_cwd_entries): Adapt to new semantics of cycle_check.
(rm): Call cycle_check_init and cycle_check_free for each file.
* tests/rm/cycle (rm): New test, for the above fix.
* tests/rm/Makefile.am (TESTS): Add cycle.
When rm detects a cycle, don't abort the entire command,
but rather just the affected command line argument.
* src/remove.c: Include <setjmp.h>
(struct dirstack_state) [current_arg_jumpbuf]: New member.
(remove_cwd_entries): Call longjmp if we detect a cycle.
(rm): Call setjmp here.
* src/remove.c (cycle_check, is_power_of_two): Remove functions.
Instead, include cycle-check.h and use it.
* src/remove.h (struct dev_ino): Remove declaration.
* src/remove.c (remove_cwd_entries): Fix typos in comment.
Don't include trailing /. in diagnostics about directories.
* src/remove.c (full_filename_): When FILENAME is just `.'
and there is a nonempty directory-name part, don't append `/.'.
* tests/rm/unread2: Remove trailing /. from diagnostic.
* tests/rm/rm2: Likewise.
* src/remove.c (struct dirstack_state): Define.
To be used in place of these file-scoped globals ...
(dir_stack, len_stack, Active_dir): Remove globals.
(ds_init, ds_free): New functions.
(full_filename): Define.
(full_filename_): Rename from full_filename.
Begin to make AD_* functions more generic.
* src/remove.c (AD_push_initial): Don't set status to RM_OK here.
(AD_push): Likewise.
(AD_INIT_OTHER_MEMBERS): Define.
(remove_dir): Define the `status' member manually after each
call to AD_push or AD_push_initial.
* src/Makefile.am (check-misc): New rule, to ensure that no more
S_IS* macro definitions sneak into the code.
(check): Depend on check-misc.
* src/remove.c [S_ISLNK]: Don't define. It's already defined in sys2.h.
* src/du.c (count_entry) [S_ISLNK]: Don't define.
* src/shred.c [S_ISLNK, S_ISFIFO, S_ISSOCK]: Don't define.
2003-01-03 Jim Meyering <jim@meyering.net>
* src/true.c: Add copyright.
(AUTHORS): I suppose I've written it.
* src/Makefile.am (false.c): Make the generated file be read-only.
2003-01-04 Jim Meyering <meyering@lucent.com>
* src/ls.c: Include "dev-ino.h".
[struct dev_ino]: Remove declaration.
2003-01-02 Jim Meyering <meyering@lucent.com>
* src/cp.c (do_copy): Tweak diagnostic to be consistent with the one
from mv: s/missing file arguments/missing file argument/.
With --target-directory=DIR, cp and mv work with a single file argument.
Reported by Karl Berry.
* tests/rm/isatty: Enable this test.
2002-12-31 Jim Meyering <meyering@lucent.com>
* src/remove.c (AD_push_initial): Don't set status to RM_OK here.
(AD_push): Likewise.
(AD_INIT_OTHER_MEMBERS): Define.
(remove_dir): Define the `status' member manually after each
call to AD_push or AD_push_initial.
* src/ls.c [struct dev_ino]: Remove definition.
Include "dev-ino.h" instead.
2002-12-28 Jim Meyering <meyering@lucent.com>
* tests/du/Makefile.am (TESTS): Add no-deref.
* tests/du/no-deref: New script.
2002-12-23 Jim Meyering <meyering@lucent.com>
* src/remove.c (remove_cwd_entries): Fix typo in comment.
2002-12-21 Jim Meyering <jim@meyering.net>
* announce-gen: Generate MML-formatted announcement.
This makes it a *lot* harder to send stale MD5/SHA1 signatures.
2002-12-20 Jim Meyering <jim@meyering.net>
* src/touch.c (touch): Change the wording of a diagnostic so
that it makes sense both when the file exists and when it doesn't.
Suggestion from Michael Stone.
2002-12-18 Jim Meyering <jim@meyering.net>
* src/stty.c (valid_options): Declare to be static.
2002-12-15 Jim Meyering <jim@meyering.net>
* Makefile.cfg: Remove rules related to generating m4/jm-glibc-io.m4.
* src/chmod.c, src/copy.c, src/copy.h, src/cp-hash.h, src/csplit.c:
* src/date.c, src/expr.c, src/fmt.c, src/id.c, src/install.c:
* src/ls.c, src/od.c, src/pathchk.c, src/pr.c, src/remove.c:
* src/shred.c, src/sort.c, src/stat.c, src/stty.c, src/sum.c:
* src/tee.c, src/test.c: Remove all uses of `PARAMS'.
* src/remove.c (PARAMS): Remove definition.
* src/sys2.h: Likewise.
* src/ls.c, src/stat.c, src/date.c: Remove declaration of nstrftime.
Include strftime.h instead.
2002-12-14 Jim Meyering <jim@meyering.net>
* Makefile.cfg ($(url_dir_list)): Use .../coreutils, not .../fetish.
* src/system.h [! HAVE_DECL_MEMRCHR]: Declare memrchr.
This is necessary at least for Irix6.5 when using c89.
Reported by Nelson Beebe.
* tests/misc/Makefile.am (TESTS): Add cat-tty-eof.
* tests/misc/cat-tty-eof: New test.
* src/mknod.c (usage): Specify how major and minor mode numbers
are interpreted. Report forwarded by Kristin E Thomas.
* src/mknod.c: Remove now-redundant usage-specifying comment.
2002-12-13 Jim Meyering <jim@meyering.net>
* Version 4.5.4.
* tests/du/trailing-slash: Allow for a directory of size `0'.
That happens at least on file systems of type tmpfs on linux-2.4.18.
* announce-gen: New script to begin replacing the commands
associated with the rule here...
* Makefile.maint (announcement): Invoke announce-gen.
* Makefile.am (EXTRA_DIST): Add announce-gen.
* tests/cp/preserve-2: New file/test, for latest fix.
* tests/cp/Makefile.am (TESTS): Add preserve-2.
2002-12-11 TAKAI Kousuke <takai@vlsi.kuee.kyoto-u.ac.jp>
Fix a bug whereby cp would fail to parse an option like
--preserve=mode,ownership.
* src/cp.c (decode_preserve_arg): Advance `comma' to
point the character following the comma.
2002-12-11 Jim Meyering <jim@meyering.net>
* src/pathchk.c (NEED_PATHCONF_WRAPPER): Undefine before defining,
in case it's already defined.
2002-12-09 Jim Meyering <jim@meyering.net>
* tests/touch/fail-diag: Don't get a test failure if /no exists.
Instead, evoke a framework failure if /no-$$ exists.
Reported by Michael Stone.
2002-12-08 Jim Meyering <jim@meyering.net>
* src/du.c (lstat) [! LSTAT_FOLLOWS_SLASHED_SYMLINK]:
Define to rpl_lstat, so that even on systems like Solaris 2.8,
du honors (per POSIX) the trailing slash on an argument referring
to a symlink-to-directory.
2002-12-06 Jim Meyering <jim@meyering.net>
* Use autoconf-2.57. Regenerate dependent files.
* Use automake-1.7.2. Regenerate dependent files.
* src/ls.c (gobble_file): Also stat the file if it's a
regular file and --indicator-style=classify (aka -F).
Thanks to Ed Santiago for opening my eyes.
* tests/ls/file-type: New file. Test for the above.
A test to contrast ls -F and ls --indicator-style=file-type.
* tests/ls/Makefile.am (TESTS): Add file-type.
2002-12-04 Jim Meyering <jim@meyering.net>
* tests/ls/follow-slink: Make sure the symlink was created.
Richard Dawe reported that `ln -s link link' succeeds, but creates
no file on systems running some version of the DJGPP libc.
2002-12-03 Jim Meyering <jim@meyering.net>
* src/Makefile.am (AUTOMAKE_OPTIONS): Remove definition (to ansi2knr)
since this package no longer panders to K&R compilers.
2002-12-02 Jim Meyering <jim@meyering.net>
* tests/du/slink: Skip this test if `.' is on a non-local file system.
* tests/Fetish.pm (_at_replace): Do the substitution only if there's
something to replace.
2002-12-01 Jim Meyering <jim@meyering.net>
* src/stat.c: Don't include <string.h> or <ctype.h>.
That's already done via system.h.
* src/dircolors.c: Don't include <ctype.h>.
2002-11-30 Jim Meyering <jim@meyering.net>
* ls.c (gobble_file): Remove the block of code that caused
`ls --color -F symlink-to-dir' to list the files in
`symlink-to-dir/.'. Now, it prints `symlink-to-dir@', (just
like `ls -F symlink-to-dir') but with the addition of highlighting.
Similarly, `ls --color -dF symlink-to-dir' would print
`symlink-to-dir/'; now it prints `symlink-to-dir@'.
Reported by Jeff Sheinberg as Debian bug #168203.
* tests/ls-2/tests (sl-F-color, sl-dF-color): New tests for the above.
ls is now more efficient: with certain options, it no longer needs
to stat each directory entry on systems with valid dirent.d_type.
* src/ls.c (print_dir): Add DT_LNK and DT_REG.
(main): Make --recursive set format_needs_type, not format_needs_stat.
(gobble_file): Remove a FIXME comment, now that it's fixed.
2002-11-24 Jim Meyering <jim@meyering.net>
* src/du.c (du_files): Don't strip any trailing slash.
Rewrite so that `/' is no longer represented internally as
the empty string.
(count_entry): When appending a file name component,
account for the fact that the current path may end in `/'.
François Pinard reported that `du symlink-to-dir/' was not
equivalent to `du symlink-to-dir/.'. Now it is.
* tests/du/trailing-slash: New file/test, for the above fix.
* tests/du/Makefile.am (TESTS): Add trailing-slash.
2002-11-23 Jim Meyering <jim@meyering.net>
* src/tac.c (output): Declare some local variables to be of type size_t,
rather than `int' to avoid warnings from gcc.
2002-11-21 Paul Eggert <eggert@twinsun.com>
* src/ls.c (decode_switches): Use case-sensitive matching to
decode the QUOTING_STYLE environment variable. This is more
consistent with the documentation, and with --quoting-style.
2002-11-21 Martin Buck <martin.buck@ascom.ch
* src/stty.c (struct speeds): Add support for all baud rates defined
in linux-2.4.19.
2002-11-19 Jim Meyering <jim@meyering.net>
* tests/sum/sysv: Export LC_ALL=C, to avoid failure when
run in a UTF locale. Report and suggested fix by Bruno Haible.
* tests/fmt/basic: Likewise.
2002-11-17 Jim Meyering <jim@meyering.net>
* configure.ac: Update via autoupdate.
Add `AM_GNU_GETTEXT_VERSION(0.11.5)'.
* src/mv.c (movefile): Don't remove trailing slashes from SOURCE.
Reported by Hans Ginzel.
2002-11-15 Jim Meyering <jim@meyering.net>
* Makefile.cfg (gnu_rel_host): Define.
(url_dir_list): Choose from (alpha|ftp).gnu.org depending
on whether $(VERSION) looks like a major release number.
* Makefile.maint (mail_gpg_sign_cookie): Backslash-escape `#'.
(release): Rename from `alpha'.
(alpha): Depend on release.
* Makefile.maint (signatures): Define with ?=, so it's easy to override.
2002-11-14 Jim Meyering <jim@meyering.net>
* Makefile.maint (mail_gpg_sign_cookie): Make optional.
(announcement): Use the new variable.
* Makefile.maint: Sync with Bison, i.e.:
(po-check): Scan .l and .y files instead of the
.c and the .h files that they generate. This fixes the bug
reported by Tim Van Holder in:
<http://mail.gnu.org/pipermail/bison-patches/2002-November/001352.html>
Look for N_ as well as for _. Try to avoid matching #define for
N_ and _.
From Paul Eggert.
2002-11-12 Jim Meyering <jim@meyering.net>
* src/ls.c (HAVE_SYMLINKS): Remove unnecessary macro definition.
Replace sole use with equivalent `#ifdef S_ISLNK'.
Inconsistency reported by Dmitry V. Levin.
2002-11-11 Jim Meyering <jim@meyering.net>
* src/stat.c (usage): Transform --help items output via s/ - / /,
so that help2man produces properly formatted man pages.
Reported by Herbert Xu as Debian bug #168400.
2002-11-10 Jim Meyering <jim@meyering.net>
* src/ls.c (sighandler): Handle SIGTSTP specially.
Based on suggestions from Solar Designer and Dmitry V. Levin.
Add comments.
* Makefile.cfg (cvs_files): Define. From autoconf.
(local_updates): Likewise.
* src/ls.c (restore_default_color_handler, sigtstp_handler):
Remove functions.
(sighandler): New function, based on the one in sort.c.
(main): Use sigaction, if possible; otherwise signal.
Handle these signals:
SIGHUP, SIGINT, SIGPIPE, SIGQUIT, SIGTERM, SIGTSTP.
Don't register our handler if the signal is already being ignored.
* src/dd.c (interrupt_handler): Use raise, rather than kill+getpid.
* src/csplit.c (interrupt_handler): Likewise.
* src/sort.c (sighandler): Likewise.
(main): Declare `i' and `nsigs' to be unsigned, not int.
2002-11-09 Jim Meyering <jim@meyering.net>
ls --color: restore terminal text color upon signal.
* src/ls.c: Include "full-write.h" and <signal.h>.
(restore_default_color, restore_default_color_handler): New functions.
(sigtstp_handler, put_indicator_direct): New functions.
(main) [print_with_color]: Register signal handlers.
Patch mostly by Solar Designer and Stanislav Ievlev.
Update from autoconf.
* Makefile.maint (AMTAR): Remove definition.
(update, cvs-update, po-update, do-po-update): New rules.
(wget-update): Update (thus renaming to cvs-update).
(automake_repo): Use anoncvs@sources.redhat.com.
2002-11-06 Jim Meyering <jim@meyering.net>
* tests/misc/Makefile.am (TESTS): Add printf-hex.
* tests/misc/printf: Be careful to test the code in this package,
not the shell built-in function.
* src/printf.c (print_esc): A hexadecimal escape sequence has
at most two hex. digits, not three. Reported by Padraig Brady.
(usage): Update description.
* tests/misc/printf-hex: New file/test, for the above fix.
2002-10-07 Paul Eggert <eggert@twinsun.com>
Add support for locale-specific size indications (e.g.,
thousands-separators) and for explicit size suffixes on output.
* doc/coreutils.texi (Block size): Say that:
This affects display format as well as block size.
Fractional block counts are rounded up.
ls file size blocksize defaults to 1.
A block size spec preceded by ' generates thousands separators.
A suffix without a preceding integer generates suffixes.
(tail invocation): 32k -> 32 KiB.
(What information is listed): ls -h is now equivalent to
ls --block-size=human, and ls -H is now equivalent to
ls --block-size=si. Displayed file size is now always affected by
--block-size.
* lib/inttostr.c, lib/inttostr.h, lib/imaxtostr.c, lib/offtostr.c,
lib/umaxtostr.c: New files, taken from GNU tar.
* lib/Makefile.am (libfetish_a_SOURCES): Add imaxtostr.c, offtostr.c,
umaxtostr.c.
(EXTRA_DIST): Add inttostr.c.
* lib/human.c, lib/human.h: Rewrite to support locale-specific
notations like thousands separators.
Specify what includer of include.h must include beforehand.
(human_group_digits, human_suppress_point_zero, human_autoscale,
human_base_1024, human_SI, human_B): New enum values.
(human_readable): Rename from human_readable_inexact; put the
options before the sizes. All uses changed. The old human_readable
function has been removed; use inttostr.h instead.
(human_options): Renamed from human_block_size, with new signature
that allows block sizes up to UINTMAX_MAX. All callers changed.
* m4/prereq.m4 (jm_PREREQ_HUMAN): Check for locale.h, localeconv,
AC_HEADER_STDBOOL. No need to check for limits.h since it's in
freestanding C89. No need to check for stdlib.h or string.h since
autoconf does this now.
* src/cksum.c (cksum): Use primitives from inttostr.h, not
human.h, to print large numbers simply.
* src/csplit.c (handle_line_error, parse_patterns): Likewise.
* src/dd.c (print_stats, main): Likewise.
* src/df.c (print_header): Likewise.
* src/factor.c (print_factors): Likewise.
* src/ls.c (print_long_format, print_file_name_and_frills): Likewise.
* src/shred.c (dopass): Likewise.
* src/sort.c (checkfp): Likewise.
* src/sum.c (bsd_sum_file, sysv_sym_file): Likewise.
* src/tail.c (xlseek): Likewise.
* src/wc.c (write_counts, wc): Likewise.
* src/df.c (human_output_opts): New var.
(output_block_size): Now uintmax_t, not int, to handle larger
block sizes. All uses changed.
* src/du.c: Likewise.
* src/ls.c: Likewise.
* src/df.c (print_header): In the header line, prefer SI to human
representation if it's shorter; if neither is shorter, try to
intuit what the user would prefer.
* src/expr.c (inttostr): Remove; use new imaxtostr library
function instead.
* src/ls.c (file_output_block_size): New var, to distinguish
file sizes from other sizes.
(decode_switches): Set it.
* src/shred.c (OUTPUT_BLOCK_SIZE): remove.
(dopass): When printing progress, use floor for what has been done
so far (since we should be conservative there), and ceiling for
what needs to be done (since that's what other programs use).
2002-10-19 Jim Meyering <jim@meyering.net>
* src/pinky.c (print_heading): Align TTY and Name headings.
Reported by Karl Eichwalder.
2002-10-18 Jim Meyering <jim@meyering.net>
* src/split.c (cwrite): Change type of `bytes' parameter to size_t
Remove now-useless cast.
(stdread): Remove function.
(bytes_split): Use size_t instead of int.
Use safe_read, not stdread.
(lines_split): Likewise.
Use memchr rather than a `while' loop.
(line_bytes_split): Use size_t instead of int.
Use safe_read, not stdread.
(main): Add some FIXME comments to remind me to remove casts.
* src/system.h (ST_BLKSIZE): Correct comment describing how to
reproduce HPUX-11 cat failure. From Petter Reinholdtsen.
2002-10-17 Jim Meyering <jim@meyering.net>
Fix a problem that could make e.g., `cat' misbehave on systems which
give invalid (unreasonably large) values for stat.st_blksize.
* src/system.h (ST_BLKSIZE): Ensure that the result is in [1..4MB].
Reported by Petter Reinholdtsen.
2002-10-14 Jim Meyering <jim@meyering.net>
Specifying a printf conversion specifer as nl's separator string
could cause nl to segfault.
* src/nl.c (build_print_fmt): Don't include separator string
in the printf format; it might contain `%'.
Use a better bound on the length of the print_fmt buffer.
(print_lineno): Print the separator here instead.
Reported by Doug Coleman.
* tests/misc/nl: New file/tests, including a test for the above.
* tests/misc/Makefile.am (TESTS): Add nl.
* tests/misc/split-l: New test, to make sure `split --lines=N' works.
* tests/misc/Makefile.am (TESTS): Add split-l.
2002-10-13 Jim Meyering <jim@meyering.net>
* Version 4.5.3.
* src/du.c (usage): Tweak description of --dereference-args/-D.
* src/du.c (count_entry): Also save cwd when dereferencing (via
--dereference-args, -D) a command-line argument.
Reported by Michal Svec. Based on a patch by Andreas Schwab.
* src/Makefile.am (../AUTHORS): New target/rule.
2002-10-12 Jim Meyering <jim@meyering.net>
* src/paste.c (paste_parallel): Declare local, `delims_saved', to be
of type size_t, since that's the way it's used and avoids a warning.
* src/csplit.c (struct cstring) [len]: Declare to be unsigned int,
since that's how it's always used and avoids a new warning from gcc.
(read_input): Adapt to new safe_read ABI.
* src/cut.c (cut_fields): Add a temporary size_t variable, n_bytes,
to avoid warnings.
* src/pinky.c (print_long_entry): fread returns size_t.
Declare local `bytes' accordingly, to avoid warning.
tail -c +N would perform an extra read after encountering EOF
[this change is analogous (bytes vs. lines) to the one of 2002-01-27]
* src/tail.c (start_bytes): Detect EOF, inform caller.
(tail_bytes): Upon EOF in start_bytes, return immediately.
(file_lines): Reorganize to use memrchr rather than an explicit loop.
Adapt to new safe_read ABI.
2002-10-11 Jim Meyering <jim@meyering.net>
* tests/du/deref: New file/test, for the above fix.
* tests/du/Makefile.am (TESTS): Add deref.
2002-10-10 Jim Meyering <jim@meyering.net>
* tests/ln/Makefile.am (TESTS): Add target-1.
* tests/ln/target-1: New file/test, for the fix on 2002-10-08.
2002-10-09 Jim Meyering <jim@meyering.net>
* tests/cp/backup-is-src: Ensure that certain environment variables
are not set (e.g., SIMPLE_BACKUP_SUFFIX). Reported by Duncan Roe.
* tests/tail-2/big-4gb: Mark this as an expensive test; it would
consume 4GB of disk space on systems without support for sparse files.
Fix a logic error that'd make it `cat err' even though dd didn't fail.
* src/dircolors.hin (.jar): Fix typo: s/;3$/;31/.
Patch by steven@magelico.net, forwarded by Michael Stone.
* tests/ls/dired: Ensure that ls produces English messages.
Patch by Alexey Vyskubov, forwarded by Michael Stone.
2002-10-08 Dmitry V. Levin <ldv@altlinux.org>
* src/ln.c (main): Fix target_directory parsing when n_files == 1.
2002-10-08 Jim Meyering <jim@meyering.net>
* tests/tail-2/big-4gb: Use double quotes around diagnostic.
Fix syntax in test: use =, not ==.
Reported by Bob Proulx.
Change all the rest like this: grep -lR "testing framework'" .\
|xargs perl -pi -e 's/'\''(\$0: failure in testing framework)'\''/"$1"/'
* src/sum.c (sysv_sum_file): Adapt to new safe_read ABI.
* src/tr.c (squeeze_filter, read_and_delete, read_and_xlate): Likewise.
* src/tac.c (save_stdin, tac_stdin_to_mem): Likewise.
* src/wc.c (wc): Likewise.
2002-10-07 Paul Eggert <eggert@twinsun.com>
* src/cat.c (cat):
Don't advance the write pointer past the end of the write buffer.
* src/sort.c (begfield, limfield): Likewise.
2002-10-07 Jim Meyering <jim@meyering.net>
* src/cat.c (simple_cat, cat): Adapt to new safe_read ABI.
* src/head.c (head_bytes, head_lines): Likewise.
2002-10-06 Jim Meyering <jim@meyering.net>
* src/dd.c (scanargs): Ensure that specified block sizes (specified
via ibs=N, obs=N, and bs=N) are no larger than SSIZE_MAX.
(skip, dd_copy): Adapt to new safe_read ABI.
* Makefile.maint (signatures): Define.
(%.sig): New rule.
(announcement): Depend on $(signatures).
* Makefile.maint (announcement): Output all URLs for detached
signatures, not just the last one from the previous loop.
2002-10-05 Jim Meyering <jim@meyering.net>
* Version 4.5.2.
* src/remove.c (remove_entry) [ROOT_CAN_UNLINK_DIRS]: With `rm -i DIR',
don't recurse into directory, DIR. Prompted by a report from
Leonardo Milano.
* tests/rm/i-no-r: New file/test, for the above fix.
* tests/rm/Makefile.am (TESTS): Add i-no-r.
* tests/tail-2/big-4gb: New file/test, for the fix of 2002-09-27.
* tests/tail-2/Makefile.am (TESTS): Add big-4gb.
2002-10-03 Jim Meyering <jim@meyering.net>
* src/rm.c (AUTHORS): Mark translatable string with `N_ (...)'.
* src/df.c (AUTHORS): Likewise.
* src/du.c (AUTHORS): Likewise.
* src/tail.c (AUTHORS): Likewise.
* src/touch.c (AUTHORS): Likewise.
2002-10-02 Jim Meyering <jim@meyering.net>
* Makefile.am (SUBDIRS): Remove `old'.
(EXTRA_DIST): List the files in old/.
* configure.ac (AC_CONFIG_FILES): Remove old/* names.
Suggestion from Akim Demaille.
2002-10-01 Jim Meyering <jim@meyering.net>
* src/sys2.h (SSIZE_MAX): Define.
2002-09-30 Jim Meyering <jim@meyering.net>
* src/csplit.c: Don't include stdlib.h here. It's already included
via system.h.
2002-09-29 Jim Meyering <jim@meyering.net>
* src/tr.c (find_bracketed_repeat): Rearrange pointer/integer
expression to avoid bogus warning from gcc.
* src/cat.c (simple_cat): Use a temporary to avoid bogus warnings.
(cat): Declare insize and outsize to be of type size_t, not int.
Rearrange pointer/integer expressions to avoid bogus warnings.
(main): Declare insize and outsize to be of type size_t, not int.
* src/tail.c (parse_options): Give a sensible diagnostic for
an invalid byte or line count. Reported by Mikko Tuumanen.
* src/touch.c (main): Split a long line.
* tests/du/Makefile.am (TESTS): Add slink.
* tests/du/slink: New test for system.h change of 2002-08-31.
In move mode, always first try to rename. Before, upon failure to
rename a directory, this code would never attempt to rename any
other file in that directory, but would thenceforth always copy.
On some systems (e.g., NetApp's OnTap-6.4), renaming a directory
may fail with EXDEV, yet renaming files within that directory to
a newly-created destination directory succeeds.
* src/copy.c (copy_internal): Remove local, move_mode;
use x->move_mode instead. Based on a patch from Tom Haynes.
2002-09-28 Jim Meyering <jim@meyering.net>
* src/split.c (FAIL_ONLY_ONE_WAY): New macro.
Factor out some duplication.
(main): Use it.
[case 'a']: Use strtoul rather than strtol to avoid compiler warnings.
* src/sort.c (begfield, limfield): Rearrange comparisons to avoid
compiler warnings.
(fillbuf, keycompare): Cast literal `-1' to size_t in comparisons,
to avoid compiler warnings.
* src/shred.c (dopass): Use a uintmax_t temporary to avoid bogus
compiler warnings.
Fix things so `mkdir -p' can create very deep directories, e.g.,
mkdir -p $(perl -e 'print "a/" x 40000') now works.
* src/mkdir.c (main): For --parents (-p), call make_path with the
entire directory name, so we don't ever require that file operations
like stat or chmod be performed on the entire command line argument.
* makepath.c (make_path): Restore umask *before* creating the final
component.
2002-09-27 Andreas Schwab <schwab@suse.de>
* src/tail.c (tail_bytes): Change type of bytes_remaining to off_t
to avoid overflow. Reported by Hans Lermen.
2002-09-26 Jim Meyering <jim@meyering.net>
* src/install.c (get_ids): Use strtoul, not strtol. Remove some casts.
2002-09-25 Jim Meyering <jim@meyering.net>
* src/test.c (eaccess): Change type of local `euid' from int to uid_t
and add a cast, to avoid a warning about `signed and unsigned type in
conditional expression'.
2002-09-22 Jim Meyering <jim@meyering.net>
* src/rmdir.c: Include "dirname.h", for declaration of
strip_trailing_slashes.
* src/stat.c (PRIdMAX, PRIuMAX): Remove definitions.
Now they're defined through system.h.
* src/cp-hash.c, src/dd.c, src/df.c, src/du.c, src/ls.c,
* src/stat.c, src/wc.c: Remove all inclusions of inttypes.h,
since it's already included from sys2.h via system.h.
* Use automake-1.6f. Regenerate dependent files.
* src/Makefile.am (PERL): Remove duplicate definition.
fmt's -s, -t, -c options didn't work properly for long lines.
Since get_line may end up calling put_paragraph (for long lines),
be sure to set global, `other_indent', before it is used there.
* src/fmt.c (set_other_indent): New function, factored out of...
(get_paragraph): ... here. Call it.
(get_line): Call set_other_indent before calling flush_paragraph,
which calls fmt_paragraph, which in turn calls put_paragraph,
which uses other_indent.
* tests/fmt/Makefile.am (TESTS): Add long-line.
* tests/fmt/long-line: New file/test, for the above fix.
2002-09-21 Jim Meyering <jim@meyering.net>
* src/od.c: No longer include deprecated <values.h>.
It was required solely for now-removed reference to BITSPERBYTE.
* src/install.c: Likewise.
Suggestion from Bruno Haible.
2002-09-06 Andreas Schwab <schwab@suse.de>
`rmdir -p dir-specified-with-trailing-slash/' would fail.
* src/rmdir.c (remove_parents): Strip trailing slashes.
2002-09-20 Jim Meyering <jim@meyering.net>
* tests/rmdir/t-slash: New file/test, for the above fix.
* tests/rmdir/Makefile.am (TESTS): Add t-slash.
* Makefile.maint (announcement): Arrange to gpg-sign the message.
Add a URL for each detached signature file.
2002-09-07 Bruno Haible <bruno@clisp.org>
* configure.ac: Add need-ngettext to AM_GNU_GETTEXT invocation.
2002-09-18 Jim Meyering <jim@meyering.net>
`od -t x8' used the wrong (`l'-prefixed) printf format.
Likewise for the o8 and u8 formats.
* src/od.c (ISPEC_TO_FORMAT): Define macro.
(decode_one_format): Use PRIdMAX, PRIoMAX, etc. for LONG_LONG.
Reported by Arun Sharma.
2002-09-17 Jim Meyering <jim@meyering.net>
* src/sys2.h (PRIdMAX, PRIoMAX, PRIuMAX, PRIxMAX): Define if necessary.
From gettext's intl/loadmsgcat.c.
* tests/od/x8: New file/test, for the above fix.
* tests/od/Makefile.am (TESTS): Add x8.
2002-09-15 Jim Meyering <jim@meyering.net>
* Use autoconf-2.54. Regenerate dependent files.
* src/csplit.c (get_format_width): Add cast to avoid
warning about `signed and unsigned type in conditional expression'.
2002-09-14 Jim Meyering <jim@meyering.net>
* src/who.c (print_user): Change type of local to size_t
to avoid warnings about `comparison between signed and unsigned'.
* src/ptx.c (generate_all_output): Likewise.
* src/dd.c (main, skip): Add casts to avoid warnings about
`comparison between signed and unsigned'.
* src/id.c (print_full_info, print_group_list): Add casts to avoid
warnings about `signed and unsigned type in conditional expression'.
* src/md5sum.c: Change type of global, digest_hex_bytes, to size_t
to avoid warnings about `comparison between signed and unsigned'.
(split_3): Change parameter names to be readable and add comment.
Clean up the test for whether a line may be ignored.
2002-09-13 Jim Meyering <jim@meyering.net>
* src/printf.c (main): Handle leading command line argument of `--'.
Reported by Raul: DervishD <raul@pleyades.net>
* tests/misc/printf: New file: test for the above.
* tests/misc/Makefile.am (TESTS): Add printf.
* src/date.c (usage): Explain that %S's range of [0..60] is required --
rather than 0..59 -- to accommodate the occasional positive leap second.
Reported by Richard Neill.
2002-09-12 Jim Meyering <jim@meyering.net>
* src/Makefile.am (nanosec_libs): Define.
(sleep_LDADD, tail_LDADD): Use it here.
Factor nanosleep-related code into ../lib/xnanosleep.c.
* src/sleep.c: Include xnanosleep.h.
Factor out fenv.h-related code.
(timespec_subtract): Remove function.
(main): Remove code that deals with computing start and stop times
as well as the loop around nanosleep. Now that's in xnanosleep.c.
Allow S (in --sleep-interval=S) to be a floating point value.
* src/tail.c: Include xnanosleep.h and xstrtod.h.
Move declaration of global variable, sleep_interval, to ...
(main): ...here.
(usage): Update description of --sleep-interval option.
(tail_forever): New parameter, sleep_interval. Update caller.
Use xnanosleep, rather than sleep.
(parse_options): New parameter, sleep_interval. Update caller.
Use xstrtod, now that we accept floating point values.
Prompted by a patch from Augey Mikus.
2002-09-06 Jim Meyering <jim@meyering.net>
* src/remove.c (prompt): Change comment to give a better note to
translators. From Michael Piefel.
2002-09-02 Jim Meyering <jim@meyering.net>
* README: A good problem report/patch includes diffs against
the most recent test release.
* src/pathchk.c (NEED_PATHCONF_WRAPPER): Define.
(pathconf_wrapper): Define only if NEED_PATHCONF_WRAPPER is set.
* src/kill.c (print_table_row): Use an unsigned type for widths
to avoid warning about comparison between signed and unsigned.
(list_signals): Likewise.
* src/od.c (skip): Add a cast to avoid warning about comparison
between signed and unsigned.
* src/install.c (get_ids): Likewise. Also rearrange range-checking
comparisons to make them more readable.
2002-09-01 Jim Meyering <jim@meyering.net>
* Version 4.5.1.
2002-08-31 Jim Meyering <jim@meyering.net>
Symlinks were always reported as using 0 blocks.
* src/system.h (ST_NBLOCKS): Don't depend on file type.
This reverts the change of 2000-01-30.
Based on a report and patch from Neil Brown via Michael Stone.
This fixes Debian Bug#156358.
* Most files: Change `exit (0)' to `exit (EXIT_SUCCESS)',
`exit (1)' to `exit (EXIT_FAILURE)', and
`usage (1)' to `usage (EXIT_FAILURE)'.
* chgrp.c, chmod.c, chown.c, chroot.c, cp.c, date.c, dd.c, du.c,
* hostname.c, id.c, install.c, ln.c, mkdir.c, mkfifo.c, mknod.c,
* nice.c, pinky.c, printf.c, pwd.c, shred.c, sleep.c, stty.c,
* su.c, tac-pipe.c, tail.c, tee.c, touch.c, uname.c, uptime.c,
* users.c, who.c: Change `error (1, ...' to `error (EXIT_FAILURE, ...'.
But don't change `error (0, ...' to `error (EXIT_SUCCESS, ...', since
error never exits successfully.
2002-08-29 Jim Meyering <jim@meyering.net>
* src/remove.c (remove_cwd_entries): Use closedir (not CLOSEDIR)
when ignoring any return value.
* src/remove.c (remove_cwd_entries): Detect and diagnose readdir
failures. On some systems (at least EMC Celerra and Solaris5.8),
this appears to be necessary.
(is_empty_dir): Likewise. Also, always close directory handle.
* src/ls.c (print_dir): Likewise.
(print_dir): Rename local variable: reading -> dirp.
Reported by Mike Coleman.
2002-08-28 Jim Meyering <jim@meyering.net>
* src/remove.c (remove_cwd_entries): Use CLOSEDIR, not closedir.
Give a diagnostic and fail if closedir fails.
2002-08-26 Jim Meyering <jim@meyering.net>
* Makefile.am (THANKS-to-translators): New rule.
(EXTRA_DIST): Add both THANKS-to-translators and THANKStt.in.
* THANKStt.in: New file.
* src/cat.c (close_stdout_wrapper): New, kludgey, function and
file-scoped global.
(main): Register it with atexit.
Close STDOUT_FILENO, to avoid a problem when writing to
/dev/audio on at least Solaris 2.7 and 2.8 systems.
Reported by Shing-Shong Shei.
2002-08-25 Jim Meyering <jim@meyering.net>
* src/cat.c (main): Close STDIN_FILENO rather than a literal `0'.
* src/tac.c (main): Likewise.
* src/tail.c (main): Likewise.
* src/tee.c (main): Likewise.
* src/tr.c (main): Likewise.
* src/wc.c (main): Likewise.
2002-08-20 Jim Meyering <jim@meyering.net>
* tests/mv/setup: Rewrite not to use `: ${VAR=not_set}' paradigm.
2002-08-10 Paul Eggert <eggert@twinsun.com>
* src/nohup.sh: Don't use "exec --"; it's not portable and
shouldn't be needed.
2002-08-09 Jim Meyering <jim@meyering.net>
* src/pr.c (main): Don't ignore -COLUMN if it's the last option.
(usage): Clarify help text for the -COLUMN option.
Patch by Padraig Brady.
* tests/pr/Test.pm [col-last]: New test for the above.
* configure.ac: Start with version 4.5.1, chosen so that it's larger
than the latest version numbers of the component packages.
* man/Makefile.am (check-x-vs-1): Set and export PATH so we use
programs in ../src.
2002-08-08 Jim Meyering <jim@meyering.net>
* src/date.c: Guard inclusion of <langinfo.h> with
`#if HAVE_LANGINFO_CODESET', not `#if HAVE_LANGINFO_H'.
* src/sort.c: Likewise.
Patch by GOTO Masanori.
2002-08-05 Paul Eggert <eggert@twinsun.com>
Fix some minor time-related bugs with POSIX time arguments.
Some valid time stamps were being rejected (notably -1, and
time stamps before 1900 on 64-bit hosts). And some invalid
time stamps were being accepted, e.g. September 31.
* src/date.c (main): Adjust to posixtime signature change.
* src/touch.c (main): Likewise. Remove unnecessary initialization.
Use localtime, not posixtm, to warn about obsolete "touch".
2002-08-05 Jim Meyering <jim@meyering.net>
* tests/misc/Makefile.am (TESTS): Add nice and pathchk1.
2002-08-04 Jim Meyering <jim@meyering.net>
* src/Makefile.am (check-README): New target/rule.
(check): Depend on it.
* configure.ac (AC_CONFIG_FILES): Add old/Makefile and old/*/Makefile.
2002-08-03 Jim Meyering <jim@meyering.net>
* Makefile.am (SUBDIRS): Add old.
* old/: New directory, containing legacy ChangeLog* and NEWS files
from the fileutils, sh-utils, and textutils packages.
* src/Makefile.am (AM_INSTALLCHECK_STD_OPTIONS_EXEMPT): Set to false.
2002-08-02 Paul Eggert <eggert@twinsun.com>
* NEWS, doc/coreutils.texi: uniq now obeys LC_COLLATE.
* src/uniq.c: Include hard-locale.h, xmemcoll.h.
(hard_LC_COLLATE): New var.
(different): Args are now char *, not const char *.
Use xmemcoll instead of memcmp to compare lines, so that
LC_COLLATE has effect. However, use memcmp if it is an
easy locale.
(check_file): Do not include newline in comparison, so that
xmemcoll has a byte to stomp on temporarily.
(main): Set hard_LC_COLLATE.
2002-07-29 Jim Meyering <jim@meyering.net>
* Makefile.am (SUBDIRS): Remove djgpp, for now.
2002-07-20 Jim Meyering <jim@meyering.net>
* Makefile.am (false.c): Convert only the final EXIT_SUCCESS
into EXIT_FAILURE. Otherwise, false --help and false --version
would fail.
2002-07-08 Jim Meyering <jim@meyering.net>
* src/Makefile.am (uninstall-local): Search for @GNU_PACKAGE@,
rather than the hard-coded `sh-utils'.
2002-07-01 Jim Meyering <jim@meyering.net>
* configure.ac: Merge the three files from fileutils,
textutils, and sh-utils.
* Makefile.am: Likewise.
* src/Makefile.am: Likewise.
Local Variables:
version-control: never
End:
|