diff options
| author | Pádraig Brady <P@draigBrady.com> | 2009-10-20 19:19:58 +0100 |
|---|---|---|
| committer | Pádraig Brady <P@draigBrady.com> | 2009-10-21 16:56:00 +0100 |
| commit | 710fe413fed61aacad4e0124eb7fcebc3a20fb6c (patch) | |
| tree | 20cfd9192502f671e501cbffcc300f40a5b4f10e /tests | |
| parent | 71adb516deee94274669f968636194bf261b1207 (diff) | |
| download | coreutils-710fe413fed61aacad4e0124eb7fcebc3a20fb6c.tar.xz | |
md5sum, sha*sum, sum: line-buffer the printed checksums
* src/md5sum.c (main): Set stdout to line buffered mode
to ensure parallel running instances don't intersperse
their output. This adds 5% to the run time in the worst case
of many zero length files, or 2% with standard file sizes.
* src/sum.c (main): Likewise.
* tests/misc/md5sum-parallel: New test for atomic output.
* tests/Makefile.am: Reference it.
* NEWS: Mention the fix
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/Makefile.am | 1 | ||||
| -rwxr-xr-x | tests/misc/md5sum-parallel | 38 |
2 files changed, 39 insertions, 0 deletions
diff --git a/tests/Makefile.am b/tests/Makefile.am index 751db1cee..4d8415f0e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -178,6 +178,7 @@ TESTS = \ misc/id-groups \ misc/md5sum \ misc/md5sum-newline \ + misc/md5sum-parallel \ misc/mknod \ misc/nice \ misc/nl \ diff --git a/tests/misc/md5sum-parallel b/tests/misc/md5sum-parallel new file mode 100755 index 000000000..f37631f69 --- /dev/null +++ b/tests/misc/md5sum-parallel @@ -0,0 +1,38 @@ +#!/bin/sh +# Ensure that md5sum prints each checksum atomically +# so that concurrent md5sums don't intersperse their output + +# Copyright (C) 2009 Free Software Foundation, Inc. + +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +. $srcdir/test-lib.sh + +if test "$VERBOSE" = yes; then + set -x + md5sum --version +fi + +fail=0 + +(mkdir tmp && cd tmp && seq 500 | xargs touch) + +# This will output at least 16KiB per process +# and start 3 processes, with 2 running concurrently, +# which triggers often on Fedora 11 at least. +(find tmp tmp tmp -type f | xargs -n500 -P2 md5sum) | +sed -n '/[0-9a-f]\{32\} /!p' | +grep . > /dev/null && fail=1 + +Exit $fail |