diff options
| author | Pádraig Brady <P@draigBrady.com> | 2016-04-20 14:03:05 +0100 |
|---|---|---|
| committer | Pádraig Brady <P@draigBrady.com> | 2016-04-21 19:34:18 +0100 |
| commit | ff6cc22d062c493c9fee27cfe1d2e6328d502a43 (patch) | |
| tree | df43a7f32e55778478f5b3833373066c8469b0e0 /tests/dd | |
| parent | 163c70d970ca3e216e24970fc5ebb1b48fdb855e (diff) | |
| download | coreutils-ff6cc22d062c493c9fee27cfe1d2e6328d502a43.tar.xz | |
tests: avoid potential overflows with `expr`
* cfg.mk (sc_prohibit_expr_unsigned): expr uses intmax_t internally
when GMP is not available, so flag any uses of unsigned limits.
* tests/misc/timeout-parameters.sh: Remove the overflow related
to UINT_MAX as it's handled by the following case. Change the
following case from 99... to $TIME_T_OFLOW to be more expressive
in what it's actually testing. Directly check that commands succeed,
rather than inspecting $? afterwards.
* tests/dd/skip-seek-past-dev.sh: Guard against large device sizes.
* tests/id/setgid.sh: Protect: Guard against large group IDs.
* tests/misc/cut-huge-range.sh: Tweak comment to avoid syntax check.
It's tempting to simplify to just skip the test if expr fails,
but SIZE_MAX > INTMAX_MAX is the common case.
Diffstat (limited to 'tests/dd')
| -rwxr-xr-x | tests/dd/skip-seek-past-dev.sh | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tests/dd/skip-seek-past-dev.sh b/tests/dd/skip-seek-past-dev.sh index c24bbb79c..2174985a7 100755 --- a/tests/dd/skip-seek-past-dev.sh +++ b/tests/dd/skip-seek-past-dev.sh @@ -39,7 +39,8 @@ dev_size=$(get_device_size "$device") || skip_ "failed to determine size of $device" # Don't use shell arithmetic as older versions of dash use longs -DEV_OFLOW=$(expr $dev_size + 1) +DEV_OFLOW=$(expr $dev_size + 1) || + skip_ "failed to adjust device size $dev_size" timeout 10 dd bs=1 skip=$DEV_OFLOW count=0 status=noxfer < "$device" 2> err test "$?" = "1" || fail=1 |