summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorJim Meyering <meyering@fb.com>2014-05-10 12:36:16 -0700
committerJim Meyering <meyering@fb.com>2014-05-10 12:36:16 -0700
commitd7cfcbef7eb2cd12ac83e5c1c123de2015adbef9 (patch)
treeb3c6bf4e193a230a32986e973caf56116e516c95 /src
parenta7603fa6527cf53a22d5072acb454f65303a3874 (diff)
downloadcoreutils-d7cfcbef7eb2cd12ac83e5c1c123de2015adbef9.tar.xz
shred: don't infloop upon negative size
* src/shred.c (main): With the preceding change, shred -s-2 FILE would write 64KB blocks forever -- or until disk full. This change makes shred reject a negative size. * tests/misc/shred-negative.sh: New file. * tests/local.mk (all_tests): Add it.
Diffstat (limited to 'src')
-rw-r--r--src/shred.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/shred.c b/src/shred.c
index f4347e002..bd88e3831 100644
--- a/src/shred.c
+++ b/src/shred.c
@@ -1256,8 +1256,8 @@ main (int argc, char **argv)
case 's':
{
- intmax_t tmp;
- if ((xstrtoimax (optarg, NULL, 0, &tmp, "cbBkKMGTPEZY0")
+ uintmax_t tmp;
+ if ((xstrtoumax (optarg, NULL, 0, &tmp, "cbBkKMGTPEZY0")
!= LONGINT_OK)
|| OFF_T_MAX < tmp)
{