diff options
| author | Jim Meyering <meyering@redhat.com> | 2008-05-05 00:07:08 +0200 |
|---|---|---|
| committer | Jim Meyering <meyering@redhat.com> | 2008-05-05 13:15:32 +0200 |
| commit | d701f6abb73e36721de5df083df4769786a14528 (patch) | |
| tree | 59a55d0b47021f52683d2ef97de03ff2258baecb /src | |
| parent | a892af0d48b47a445fda12a1e889f1a7f3cd5907 (diff) | |
| download | coreutils-d701f6abb73e36721de5df083df4769786a14528.tar.xz | |
tac: avoid segfault for e.g., "echo > x; tac -r x x"
* src/tac.c (tac_seekable): Move local "regs" declaration out
to file scope, so its values aren't clobbered between calls.
Discovered by Cristian Cadar, Daniel Dunbar and Dawson Engler,
reported in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/13501
* NEWS: Mention the bug fix.
* tests/Makefile.am (TESTS): Add misc/tac.
* tests/misc/tac: New file. Test for the above.
Diffstat (limited to 'src')
| -rw-r--r-- | src/tac.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -110,6 +110,7 @@ static size_t G_buffer_size; /* The compiled regular expression representing `separator'. */ static struct re_pattern_buffer compiled_separator; static char compiled_separator_fastmap[UCHAR_MAX + 1]; +static struct re_registers regs; static struct option const longopts[] = { @@ -212,7 +213,6 @@ tac_seekable (int input_fd, const char *file) char first_char = *separator; /* Speed optimization, non-regexp. */ char const *separator1 = separator + 1; /* Speed optimization, non-regexp. */ size_t match_length1 = match_length - 1; /* Speed optimization, non-regexp. */ - struct re_registers regs; /* Find the size of the input file. */ file_pos = lseek (input_fd, (off_t) 0, SEEK_END); |