From d701f6abb73e36721de5df083df4769786a14528 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 5 May 2008 00:07:08 +0200 Subject: tac: avoid segfault for e.g., "echo > x; tac -r x x" * src/tac.c (tac_seekable): Move local "regs" declaration out to file scope, so its values aren't clobbered between calls. Discovered by Cristian Cadar, Daniel Dunbar and Dawson Engler, reported in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/13501 * NEWS: Mention the bug fix. * tests/Makefile.am (TESTS): Add misc/tac. * tests/misc/tac: New file. Test for the above. --- src/tac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/tac.c b/src/tac.c index 262bf875e..e9ba10d73 100644 --- a/src/tac.c +++ b/src/tac.c @@ -110,6 +110,7 @@ static size_t G_buffer_size; /* The compiled regular expression representing `separator'. */ static struct re_pattern_buffer compiled_separator; static char compiled_separator_fastmap[UCHAR_MAX + 1]; +static struct re_registers regs; static struct option const longopts[] = { @@ -212,7 +213,6 @@ tac_seekable (int input_fd, const char *file) char first_char = *separator; /* Speed optimization, non-regexp. */ char const *separator1 = separator + 1; /* Speed optimization, non-regexp. */ size_t match_length1 = match_length - 1; /* Speed optimization, non-regexp. */ - struct re_registers regs; /* Find the size of the input file. */ file_pos = lseek (input_fd, (off_t) 0, SEEK_END); -- cgit v1.2.3-70-g09d2