all: use die() rather than error(EXIT_FAILURE)

die() has the advantage of being apparent to the compiler
that it doesn't return, which will avoid warnings in some cases,
and possibly generate better code.
* cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to
catch any new uses of error (CONSTANT, ...);

1 files changed, 2 insertions, 1 deletions

diff --git a/src/sum.c b/src/sum.c
index 04e393163..d2cd80f2b 100644
--- a/src/sum.c
+++ b/src/sum.c
@@ -24,6 +24,7 @@
 #include <sys/types.h>
 #include <getopt.h>
 #include "system.h"
+#include "die.h"
 #include "error.h"
 #include "fadvise.h"
 #include "human.h"
@@ -270,6 +271,6 @@ main (int argc, char **argv)
       ok &= sum_func (argv[optind], files_given);
 
   if (have_read_stdin && fclose (stdin) == EOF)
-    error (EXIT_FAILURE, errno, "%s", quotef ("-"));
+    die (EXIT_FAILURE, errno, "%s", quotef ("-"));
   return ok ? EXIT_SUCCESS : EXIT_FAILURE;
 }