From 492dcb2eb191b844a2fd5e51db3eed85289bea1f Mon Sep 17 00:00:00 2001 From: Pádraig Brady Date: Sat, 15 Oct 2016 23:10:35 +0100 Subject: all: use die() rather than error(EXIT_FAILURE) die() has the advantage of being apparent to the compiler that it doesn't return, which will avoid warnings in some cases, and possibly generate better code. * cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to catch any new uses of error (CONSTANT, ...); --- src/sum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/sum.c') diff --git a/src/sum.c b/src/sum.c index 04e393163..d2cd80f2b 100644 --- a/src/sum.c +++ b/src/sum.c @@ -24,6 +24,7 @@ #include #include #include "system.h" +#include "die.h" #include "error.h" #include "fadvise.h" #include "human.h" @@ -270,6 +271,6 @@ main (int argc, char **argv) ok &= sum_func (argv[optind], files_given); if (have_read_stdin && fclose (stdin) == EOF) - error (EXIT_FAILURE, errno, "%s", quotef ("-")); + die (EXIT_FAILURE, errno, "%s", quotef ("-")); return ok ? EXIT_SUCCESS : EXIT_FAILURE; } -- cgit v1.2.3-54-g00ecf