diff options
| author | Bernhard Voelker <mail@bernhard-voelker.de> | 2015-02-17 08:46:56 +0100 |
|---|---|---|
| committer | Bernhard Voelker <mail@bernhard-voelker.de> | 2015-02-17 08:50:34 +0100 |
| commit | 9f5dce80702d494535ab332273d20da1f9ca4365 (patch) | |
| tree | 6b86c2256ba1d4675513f62bb2454d6eec80c998 /src/pinky.c | |
| parent | 321bd11352d1f378128d65746852e073f86319d3 (diff) | |
| download | coreutils-9f5dce80702d494535ab332273d20da1f9ca4365.tar.xz | |
maint: prefer STREQ_LEN and STRPREFIX over strncmp in all cases
* cfg.mk (sc_prohibit_strncmp): Improve the search pattern: use
_sc_search_regexp to find all invocations of strncmp except when
used on a macro definition line; just match the function name with
an opening parenthesis. Before, the expression missed places where
the comparison against 0 was in a subsequent line.
* src/system.h (STRNCMP_LIT): Shorten 'literal' to 'lit' to move
the whole definition of the macro into one line - thus making
sc_prohibit_strncmp pass.
(STRPREFIX): Add space before parenthesis.
* src/du.c (main): Prefer STREQ_LEN over strncmp.
* src/pinky.c (scan_entries): Likewise.
* src/tac.c (tac_seekable): Likewise.
* src/who.c (scan_entries): Likewise.
Diffstat (limited to 'src/pinky.c')
| -rw-r--r-- | src/pinky.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/pinky.c b/src/pinky.c index f1bf3407c..71650bfae 100644 --- a/src/pinky.c +++ b/src/pinky.c @@ -445,8 +445,7 @@ scan_entries (size_t n, const STRUCT_UTMP *utmp_buf, int i; for (i = 0; i < argc_names; i++) - if (strncmp (UT_USER (utmp_buf), argv_names[i], UT_USER_SIZE) - == 0) + if (STREQ_LEN (UT_USER (utmp_buf), argv_names[i], UT_USER_SIZE)) { print_entry (utmp_buf); break; |