diff options
| author | Pádraig Brady <P@draigBrady.com> | 2016-10-15 23:10:35 +0100 |
|---|---|---|
| committer | Pádraig Brady <P@draigBrady.com> | 2016-10-16 12:23:55 +0100 |
| commit | 492dcb2eb191b844a2fd5e51db3eed85289bea1f (patch) | |
| tree | 910f93d88891b573520ebd5c812d61ddc7fbeed8 /src/chmod.c | |
| parent | d035eacfdeba2da0134e606c8a63b2f3c0bd05bb (diff) | |
| download | coreutils-492dcb2eb191b844a2fd5e51db3eed85289bea1f.tar.xz | |
all: use die() rather than error(EXIT_FAILURE)
die() has the advantage of being apparent to the compiler
that it doesn't return, which will avoid warnings in some cases,
and possibly generate better code.
* cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to
catch any new uses of error (CONSTANT, ...);
Diffstat (limited to 'src/chmod.c')
| -rw-r--r-- | src/chmod.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/chmod.c b/src/chmod.c index 3ea66ebf4..89e223239 100644 --- a/src/chmod.c +++ b/src/chmod.c @@ -23,6 +23,7 @@ #include "system.h" #include "dev-ino.h" +#include "die.h" #include "error.h" #include "filemode.h" #include "ignore-value.h" @@ -535,8 +536,8 @@ main (int argc, char **argv) { change = mode_create_from_ref (reference_file); if (!change) - error (EXIT_FAILURE, errno, _("failed to get attributes of %s"), - quoteaf (reference_file)); + die (EXIT_FAILURE, errno, _("failed to get attributes of %s"), + quoteaf (reference_file)); } else { @@ -554,8 +555,8 @@ main (int argc, char **argv) static struct dev_ino dev_ino_buf; root_dev_ino = get_root_dev_ino (&dev_ino_buf); if (root_dev_ino == NULL) - error (EXIT_FAILURE, errno, _("failed to get attributes of %s"), - quoteaf ("/")); + die (EXIT_FAILURE, errno, _("failed to get attributes of %s"), + quoteaf ("/")); } else { |