summaryrefslogtreecommitdiff
path: root/man/local.mk
diff options
context:
space:
mode:
authorAssaf Gordon <assafgordon@gmail.com>2014-07-15 12:25:03 -0400
committerPádraig Brady <P@draigBrady.com>2014-07-16 22:35:17 +0100
commit061882d73b4f11f7b7f7151754e617234edc6f7a (patch)
treed527f75dcf25f2ded0233eb0f7728b958c91a30c /man/local.mk
parent37b36018d3f5f276622a9888e32623f9410a80e0 (diff)
downloadcoreutils-061882d73b4f11f7b7f7151754e617234edc6f7a.tar.xz
numfmt: fix isblank() usage for some unibyte locales
* src/numfmt.c (simple_strtod_int): Replace isdigit() with c_isdigit() to avoid locale concerns and -Wchar-subscripts warnings on cygwin. Remove the now redundant locale guard. (simple_strtod_human): Cast characters to unsigned so that the promoted int value passed to isblank() is positive, allowing it to work correctly for all characters in unibyte locales. Previously character 0xA0, i.e. non-breaking space, would be misclassified for example. (process_suffixed_number): Likewise. (skip_fields): Likewise. Both issues were triggered by the -Wchar-subscripts warning on GCC 4.8.3 on cygwin, due to the is*() implementations used there, but the issue is present on all platforms defaulting to signed chars. * NEWS: Mention the bug fix. Reported by Eric Blake
Diffstat (limited to 'man/local.mk')
0 files changed, 0 insertions, 0 deletions