diff options
| author | Jim Meyering <meyering@redhat.com> | 2010-01-12 07:58:44 +0100 |
|---|---|---|
| committer | Jim Meyering <meyering@redhat.com> | 2010-01-12 08:06:47 +0100 |
| commit | 6beca4248f572c2503657fb16341bd43cfa7d254 (patch) | |
| tree | cc5512cc589f4f53b6d5b6f18417726221c44ee0 /m4 | |
| parent | 37b8bfda56adc0c633b041948ef78e53b8ce1add (diff) | |
| download | coreutils-6beca4248f572c2503657fb16341bd43cfa7d254.tar.xz | |
build: fix build failure due to missing libxattr
Configure is supposed to detect insufficient XATTR support.
However, if a system has the required headers, but no library,
the configure script would mistakenly enable USE_XATTR.
* m4/xattr.m4 (gl_FUNC_XATTR): If the attr_copy_file function
is not found, don't set USE_XATTR.
Nelson Beebe reported a link failure on RHEL 5.3.
Also, do not let the combination of --disable-xattr and
a stray LIB_XATTR environment setting perturb the build.
* NEWS (Build-related): Mention it.
Diffstat (limited to 'm4')
| -rw-r--r-- | m4/xattr.m4 | 32 |
1 files changed, 18 insertions, 14 deletions
diff --git a/m4/xattr.m4 b/m4/xattr.m4 index 377676a99..bf7e8725f 100644 --- a/m4/xattr.m4 +++ b/m4/xattr.m4 @@ -15,25 +15,29 @@ AC_DEFUN([gl_FUNC_XATTR], [do not support extended attributes]), [use_xattr=$enableval], [use_xattr=yes]) + LIB_XATTR= + AC_SUBST([LIB_XATTR]) + if test "$use_xattr" = "yes"; then AC_CHECK_HEADERS([attr/error_context.h attr/libattr.h]) + use_xattr=no if test $ac_cv_header_attr_libattr_h = yes \ - && test $ac_cv_header_attr_error_context_h = yes; then - use_xattr=1 - else - use_xattr=0 - AC_MSG_WARN([libattr development library was not found or not usable.]) - AC_MSG_WARN([AC_PACKAGE_NAME will be built without xattr support.]) + && test $ac_cv_header_attr_error_context_h = yes; then + xattr_saved_LIBS=$LIBS + AC_SEARCH_LIBS([attr_copy_file], [attr], + [test "$ac_cv_search_attr_copy_file" = "none required" || + LIB_XATTR=$ac_cv_search_attr_copy_file]) + AC_CHECK_FUNCS([attr_copy_file]) + LIBS=$xattr_saved_LIBS + if test $ac_cv_func_attr_copy_file = yes; then + use_xattr=yes + fi fi AC_DEFINE_UNQUOTED([USE_XATTR], [$use_xattr], [Define if you want extended attribute support.]) - LIB_XATTR= - xattr_saved_LIBS=$LIBS - AC_SEARCH_LIBS([attr_copy_file], [attr], - [test "$ac_cv_search_attr_copy_file" = "none required" || - LIB_XATTR=$ac_cv_search_attr_copy_file]) - AC_CHECK_FUNCS([attr_copy_file]) - LIBS=$xattr_saved_LIBS - AC_SUBST([LIB_XATTR]) + if test $use_xattr = no; then + AC_MSG_WARN([libattr development library was not found or not usable.]) + AC_MSG_WARN([AC_PACKAGE_NAME will be built without xattr support.]) + fi fi ]) |