summaryrefslogtreecommitdiff
path: root/lib/xreadlink.c
diff options
context:
space:
mode:
authorPaul Eggert <eggert@cs.ucla.edu>2004-11-03 07:44:15 +0000
committerPaul Eggert <eggert@cs.ucla.edu>2004-11-03 07:44:15 +0000
commit5a5367474b6808f488d4b0e74ba30bebfdc882f3 (patch)
treef52115c051496683e41fd9f7c1f9ad4935e66940 /lib/xreadlink.c
parent47bcfc54da3d26655f0c151f214a29cf58711765 (diff)
downloadcoreutils-5a5367474b6808f488d4b0e74ba30bebfdc882f3.tar.xz
Sync from gnulib.
Diffstat (limited to 'lib/xreadlink.c')
-rw-r--r--lib/xreadlink.c18
1 files changed, 12 insertions, 6 deletions
diff --git a/lib/xreadlink.c b/lib/xreadlink.c
index 2e66c07f2..c38e2d3aa 100644
--- a/lib/xreadlink.c
+++ b/lib/xreadlink.c
@@ -41,6 +41,8 @@
# define SSIZE_MAX ((ssize_t) (SIZE_MAX / 2))
#endif
+#define MAXSIZE (SIZE_MAX < SSIZE_MAX ? SIZE_MAX : SSIZE_MAX)
+
#include "xalloc.h"
/* Call readlink to get the symbolic link value of FILENAME.
@@ -56,14 +58,15 @@ xreadlink (char const *filename, size_t size)
{
/* The initial buffer size for the link value. A power of 2
detects arithmetic overflow earlier, but is not required. */
- size_t buf_size = size + 1;
+ size_t buf_size = size < MAXSIZE ? size + 1 : MAXSIZE;
while (1)
{
char *buffer = xmalloc (buf_size);
- ssize_t link_length = readlink (filename, buffer, buf_size);
+ ssize_t r = readlink (filename, buffer, buf_size);
+ size_t link_length = r;
- if (link_length < 0)
+ if (r < 0)
{
int saved_errno = errno;
free (buffer);
@@ -71,15 +74,18 @@ xreadlink (char const *filename, size_t size)
return NULL;
}
- if ((size_t) link_length < buf_size)
+ if (link_length < buf_size)
{
buffer[link_length] = 0;
return buffer;
}
free (buffer);
- buf_size *= 2;
- if (! (0 < buf_size && buf_size <= SSIZE_MAX))
+ if (buf_size <= MAXSIZE / 2)
+ buf_size *= 2;
+ else if (buf_size < MAXSIZE)
+ buf_size = MAXSIZE;
+ else
xalloc_die ();
}
}