diff options
author | Bernhard Voelker <mail@bernhard-voelker.de> | 2013-12-03 08:02:57 +0100 |
---|---|---|
committer | Bernhard Voelker <mail@bernhard-voelker.de> | 2013-12-03 10:03:51 +0100 |
commit | f65a3841606fcbc256c5dfcb7bd3ef90a7adec10 (patch) | |
tree | 12474791e834d18659a842e2f9107189ef541c07 /TODO | |
parent | 30384428a497bee7e04d493e4801d3b8297fe952 (diff) | |
download | coreutils-f65a3841606fcbc256c5dfcb7bd3ef90a7adec10.tar.xz |
maint: avoid '%s' quoting notation in diagnostic messages
Add a new rule to ensure the use of quote() instead of '%s' or `%s'
in format strings of diagnostics messages.
* cfg.mk (sc_prohibit_quotes_notation): Add rule.
* TODO: Remove the entry regarding the '%s' notation.
* src/mkfifo.c (main): Remove the offending and in this case even
duplicate quoting in the format string of the error diagnostic.
* src/mknod.c (main): Likewise.
* src/df.c (decode_output_arg): Change two invocations of error()
according to the above new rule.
* src/numfmt.c: Fix numerous wrong quote notations to fit the above
new rule, mostly in internal debugging diagnostic messages.
Diffstat (limited to 'TODO')
-rw-r--r-- | TODO | 4 |
1 files changed, 0 insertions, 4 deletions
@@ -130,10 +130,6 @@ Add a distcheck-time test to ensure that every distributed file is either read-only(indicating generated) or is version-controlled and up to date. -remove '%s' notation (now that they're all gone, add a maint.mk sc_ - rule to ensure no new ones are added): - grep -E "\`%.{,4}s'" src/*.c - remove all uses of the 'register' keyword: Done. add a maint.mk rule for this, too. |