From f65a3841606fcbc256c5dfcb7bd3ef90a7adec10 Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Tue, 3 Dec 2013 08:02:57 +0100 Subject: maint: avoid '%s' quoting notation in diagnostic messages Add a new rule to ensure the use of quote() instead of '%s' or `%s' in format strings of diagnostics messages. * cfg.mk (sc_prohibit_quotes_notation): Add rule. * TODO: Remove the entry regarding the '%s' notation. * src/mkfifo.c (main): Remove the offending and in this case even duplicate quoting in the format string of the error diagnostic. * src/mknod.c (main): Likewise. * src/df.c (decode_output_arg): Change two invocations of error() according to the above new rule. * src/numfmt.c: Fix numerous wrong quote notations to fit the above new rule, mostly in internal debugging diagnostic messages. --- TODO | 4 ---- 1 file changed, 4 deletions(-) (limited to 'TODO') diff --git a/TODO b/TODO index e10da7cad..3dc05af77 100644 --- a/TODO +++ b/TODO @@ -130,10 +130,6 @@ Add a distcheck-time test to ensure that every distributed file is either read-only(indicating generated) or is version-controlled and up to date. -remove '%s' notation (now that they're all gone, add a maint.mk sc_ - rule to ensure no new ones are added): - grep -E "\`%.{,4}s'" src/*.c - remove all uses of the 'register' keyword: Done. add a maint.mk rule for this, too. -- cgit v1.2.3-54-g00ecf