diff options
| author | Paul Eggert <eggert@CS.UCLA.EDU> | 2009-03-13 15:48:30 -0700 |
|---|---|---|
| committer | Jim Meyering <meyering@redhat.com> | 2009-03-18 21:44:37 +0100 |
| commit | 8f7fae59727e0a050a4833705a6f7849ba2c4531 (patch) | |
| tree | 7af8e87ff4424402ac12314a1d8f429a0dd23cba /THANKS | |
| parent | e6d2d9479495dff8520e577c221d5195eb9bb48b (diff) | |
| download | coreutils-8f7fae59727e0a050a4833705a6f7849ba2c4531.tar.xz | |
sort: handle fd exhaustion better when merging
This is an alternative to my 9 March patch labeled "Silently lower
nmerge; don't (sometimes incorrectly) range-check"
<http://lists.gnu.org/archive/html/bug-coreutils/2009-03/msg00070.html>.
It differs by not using 'dup' to probe for extra file descriptors;
instead, it simply calls 'open' (and 'pipe') to open files and pipes,
until one of these calls fails due to file descriptor exhaustion; it
then backs off by 1, does a merge with the files that it has opened,
and then retries with the (now-smaller) number of files.
This patch requires quite a few more changes to the source code than
the earlier patch, but it is in some sense "better" because it doesn't
need to call "dup" ahead of time in order to decide whether "open" or
"pipe" will fail. Also, it's more robust in the case where "open" or
"pipe" fails with errno==EMFILE because some system-wide limit is
exhausted.
* src/sort.c (create_temp_file): New arg SURVIVE_FD_EXHAUSTION.
(stream_open): New function, containing guts of xfopen.
(xfopen): Use it.
(pipe_fork): Set errno on failure.
(maybe_create_temp): New function, containing guts of create_temp.
(create_temp): Use it.
(open_temp): Distinguish failures due to file descriptor exhaustion
from other failures, and on fd exhaustion return a notice to caller
rather than dying. Don't test execlp's return value; when it returns,
it *always* returns -1.
(open_input_files): New function.
(mergefps): New arg FPS. It's now the caller's responsibility to open
the input and output files. All callers changed.
(mergefiles): New function.
(avoid_trashing_input, merge): Handle the case where a single merge
can't merge as much as we wanted due to file descriptor exhaustion, by
merging as much as we can and then retrying.
* tests/Makefile.am (TESTS): Add misc/sort-continue.
* tests/misc/sort-continue: New file.
* THANKS: Add Glen Lenker and Matt Pham who coauthored this patch.
Diffstat (limited to 'THANKS')
| -rw-r--r-- | THANKS | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -204,6 +204,7 @@ Geoff Whale geoffw@cse.unsw.EDU.AU Gerald Pfeifer gerald@pfeifer.com Gerhard Poul gpoul@gnu.org Germano Leichsenring germano@jedi.cs.kobe-u.ac.jp +Glen Lenker glen.lenker@gmail.com Göran Uddeborg goeran@uddeborg.se Guochun Shi gshi@ncsa.uiuc.edu GOTO Masanori gotom@debian.or.jp @@ -365,6 +366,7 @@ Mate Wierdl mw@moni.msci.memphis.edu Matej Vela mvela@public.srce.hr Matt Kraai kraai@ftbfs.org Matt Perry matt@primefactor.com +Matt Pham mattvpham@gmail.com Matt Schalit mschalit@pacbell.net Matt Swift swift@alum.mit.edu Matthew Arnison maffew@cat.org.au |