diff options
author | Jim Meyering <jim@meyering.net> | 2007-09-22 08:40:47 +0200 |
---|---|---|
committer | Jim Meyering <jim@meyering.net> | 2007-09-22 08:44:42 +0200 |
commit | 920b4416c147ecb76731137158da8bcc9041fecd (patch) | |
tree | b5dee14b3d092f9abbc82aeddd19a4c4488437fd /ChangeLog | |
parent | ebeb56f9dfd14d50b4ec237730e7bef9336f7cc7 (diff) | |
download | coreutils-920b4416c147ecb76731137158da8bcc9041fecd.tar.xz |
rm: fix a tiny, nearly inconsequential bug.
Don't perform a "."-relative lstat, when the file in question
may well not be in ".". Although this is a bug, a few attempts
to exercise it on a linux-2.6.22 system failed. You probably need
a pre-openat system to trigger the failure. The consequence of this
bug would be a lower-quality diagnostic upon failed dir removal.
* src/remove.c (is_dir_lstat): Add a parameter, fd_cwd.
Use it instead of hard-coding AT_FDCWD.
(remove_entry): Call is_dir_lstat with fd_cwd.
Signed-off-by: Jim Meyering <jim@meyering.net>
Diffstat (limited to 'ChangeLog')
-rw-r--r-- | ChangeLog | 12 |
1 files changed, 12 insertions, 0 deletions
@@ -1,3 +1,15 @@ +2007-09-22 Jim Meyering <jim@meyering.net> + + rm: fix a tiny, nearly inconsequential bug. + Don't perform a "."-relative lstat, when the file in question + may well not be in ".". Although this is a bug, a few attempts + to exercise it on a linux-2.6.22 system failed. You probably need + a pre-openat system to trigger the failure. The consequence of this + bug would be a lower-quality diagnostic upon failed dir removal. + * src/remove.c (is_dir_lstat): Add a parameter, fd_cwd. + Use it instead of hard-coding AT_FDCWD. + (remove_entry): Call is_dir_lstat with fd_cwd. + 2007-09-22 Karl Berry <karl@freefriends.org> * TODO: It'd be nice to add renice. |