diff options
| author | Jim Meyering <meyering@redhat.com> | 2011-11-27 16:13:26 +0100 |
|---|---|---|
| committer | Jim Meyering <meyering@redhat.com> | 2011-11-28 10:29:01 +0100 |
| commit | 73a9acd6e885ae1e1e0dd2e5038df687f9b83c19 (patch) | |
| tree | 33b876dedf75235d6564a4fc3a028710a2b32ecb | |
| parent | 1e676ec8443f096f7e46aeef781301e38ef30f1d (diff) | |
| download | coreutils-73a9acd6e885ae1e1e0dd2e5038df687f9b83c19.tar.xz | |
build: enable -Wsuggest-attribute=pure|const in lib/,...
but not in gnulib-tests/.
* configure.ac (GNULIB_WARN_CFLAGS): Do not exclude
-Wsuggest-attribute=pure|const, thus enabling these two warning
options in lib/, since gnulib now toes the line.
Continue to disable them in gnulib-tests/, since some programs
there trigger these suggestions and are not worth fixing.
| -rw-r--r-- | configure.ac | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/configure.ac b/configure.ac index a17417895..8c4fff44f 100644 --- a/configure.ac +++ b/configure.ac @@ -156,15 +156,15 @@ if test "$gl_gcc_warnings" = yes; then # FIXME: it may be easy to remove this, since it affects only one file: # the snprintf call at ftoastr.c:132. nw="$nw -Wdouble-promotion" - # FIXME: remove/reenable the following two, once gnulib is adjusted. - nw="$nw -Wsuggest-attribute=const" - nw="$nw -Wsuggest-attribute=pure" gl_MANYWARN_COMPLEMENT([GNULIB_WARN_CFLAGS], [$WARN_CFLAGS], [$nw]) AC_SUBST([GNULIB_WARN_CFLAGS]) # For gnulib-tests, the set is slightly smaller still. nw= nw="$nw -Wstrict-prototypes" + # It's not worth being this picky about test programs. + nw="$nw -Wsuggest-attribute=const" + nw="$nw -Wsuggest-attribute=pure" gl_MANYWARN_COMPLEMENT([GNULIB_TEST_WARN_CFLAGS], [$GNULIB_WARN_CFLAGS], [$nw]) AC_SUBST([GNULIB_TEST_WARN_CFLAGS]) |