diff options
| author | Jim Meyering <meyering@redhat.com> | 2009-06-29 20:43:26 +0200 |
|---|---|---|
| committer | Jim Meyering <meyering@redhat.com> | 2009-06-29 20:43:26 +0200 |
| commit | 6d0d1c47b28ea4989a6608e9f7d51218ee0c89ef (patch) | |
| tree | e39018a09a3ba1b49802f77f2c018f899382c4df | |
| parent | 5718733510a657394c3801e274316e1c21f20212 (diff) | |
| download | coreutils-6d0d1c47b28ea4989a6608e9f7d51218ee0c89ef.tar.xz | |
tail: add comments noting potential inotify-related problems
* src/tail.c (tail_forever_inotify): Add two FIXME comments.
| -rw-r--r-- | src/tail.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/tail.c b/src/tail.c index 059ee8245..89c43b827 100644 --- a/src/tail.c +++ b/src/tail.c @@ -1258,6 +1258,8 @@ tail_forever_inotify (int wd, struct File_spec *f, int n_files) len = safe_read (wd, evbuf, evlen); evbuf_off = 0; + /* For kernels prior to 2.6.21, read returns 0 when the buffer + is too small. FIXME: handle that. */ if (len == SAFE_READ_ERROR && errno == EINVAL && max_realloc--) { len = 0; @@ -1277,8 +1279,10 @@ tail_forever_inotify (int wd, struct File_spec *f, int n_files) { for (i = 0; i < n_files; i++) { - if (f[i].parent_wd == ev->wd && - STREQ (ev->name, f[i].name + f[i].basename_start)) + /* With N=hundreds of frequently-changing files, this O(N^2) + process might be a problem. FIXME: use a hash table? */ + if (f[i].parent_wd == ev->wd + && STREQ (ev->name, f[i].name + f[i].basename_start)) break; } |