diff options
| author | Erich Eckner <git@eckner.net> | 2017-09-05 08:39:23 +0200 |
|---|---|---|
| committer | Erich Eckner <git@eckner.net> | 2017-09-05 08:39:23 +0200 |
| commit | 764554bbe6b2249ec6c78e8d3db42200fbfe52e1 (patch) | |
| tree | 2d1dd629f5118cde57612502769190a12898f45b /hpoj/hpoj-pack.patch | |
| parent | 400d358a2a06a6f35a06008a892935dab866e388 (diff) | |
| download | archlinuxewe.git.save-764554bbe6b2249ec6c78e8d3db42200fbfe52e1.tar.xz | |
hpoj new
Diffstat (limited to 'hpoj/hpoj-pack.patch')
| -rw-r--r-- | hpoj/hpoj-pack.patch | 59 |
1 files changed, 59 insertions, 0 deletions
diff --git a/hpoj/hpoj-pack.patch b/hpoj/hpoj-pack.patch new file mode 100644 index 00000000..beb7040d --- /dev/null +++ b/hpoj/hpoj-pack.patch @@ -0,0 +1,59 @@ +There is a rather scary and longstanding GCC bug [1] which causes +instant crashes if a program defines a struct with function-pointers +and that structure happens to be "packed". Why anybody would want to +do such a thing is beyond me, but suffice it to say that hpoj v0.91 is +doing precisely that. The current Debian/sarge package for hpoj is +definitely affected (any attempt to scan an image results in an +instant crash). + +A patch to work around the problem is attached. + +Perhaps the hpoj developers can tell us whether it was really +intentional to have the #pragma pack(1) span all of <stdlib.h> and +<xform.h>? + +Thanks, + + --david + +[1] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1844 + +--- hpoj-0.91/include/hpojip.h 2002-07-25 02:01:24.000000000 -0700 ++++ hpoj-0.91-davidm/include/hpojip.h 2004-11-11 21:19:58.775236374 -0800 +@@ -131,12 +132,15 @@ + float fl; + } DWORD_OR_PVOID; + ++#pragma pack () ++ + #ifdef HPOJIP_INTERNAL + #include "../lib/hpojip/xform.h" // this file uses the above definitions + #else + typedef struct IP_XFORM_TBL_s FAR *LPIP_XFORM_TBL; + #endif + ++#pragma pack (1) + + /****************************************************************************\ + **************************************************************************** +@@ -587,8 +591,6 @@ + + EXPORT(WORD) ipGetFuncPtrs (LPIP_JUMP_TBL lpJumpTbl); + +-#pragma pack () +- + /****************************************************************************\ + **************************************************************************** + * + + +------------------------------------------------------- +This SF.Net email is sponsored by: +Sybase ASE Linux Express Edition - download now for FREE +LinuxWorld Reader's Choice Award Winner for best database on Linux. +http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click + +_______________________________________________ +hpoj-devel mailing list +hpoj-devel@lists.sourceforge.net +https://lists.sourceforge.net/lists/listinfo/hpoj-devel |