diff options
| author | Aaron Griffin <aaronmgriffin@gmail.com> | 2007-11-06 00:55:45 -0600 |
|---|---|---|
| committer | Aaron Griffin <aaronmgriffin@gmail.com> | 2007-11-06 22:47:10 -0600 |
| commit | 2ee90ddae23dd86c68223c0d6c49f0b92d62429d (patch) | |
| tree | 050a4d45e7e56c5a860df533cf4557f34de8416d /lib/libalpm/remove.c | |
| parent | bdab234d977dd2e9417a39f5191e495d5c460ee7 (diff) | |
| download | pacman-2ee90ddae23dd86c68223c0d6c49f0b92d62429d.tar.xz | |
Maintain list tail pointers in the head node
List head nodes contain null 'prev' pointer, which we can (ab)use to maintain a
back reference to the tail pointer of the list.
While list additions are not _significantly_ improved, they are still sped up.
Original
$ time pacman -Qo /usr/bin/wtpt
/usr/bin/wtpt is owned by lcms 1.17-2
real 0m3.623s
user 0m1.883s
sys 0m1.473s
New
$ time pacman -Qo /usr/bin/wtpt
/usr/bin/wtpt is owned by lcms 1.17-2
real 0m2.006s
user 0m0.263s
sys 0m1.627s
Signed-off-by: Aaron Griffin <aaronmgriffin@gmail.com>
Diffstat (limited to 'lib/libalpm/remove.c')
| -rw-r--r-- | lib/libalpm/remove.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/libalpm/remove.c b/lib/libalpm/remove.c index 6bbb4655..a4c3c15c 100644 --- a/lib/libalpm/remove.c +++ b/lib/libalpm/remove.c @@ -304,7 +304,8 @@ int _alpm_remove_commit(pmtrans_t *trans, pmdb_t *db) _alpm_log(PM_LOG_DEBUG, "removing %d files\n", filenum); /* iterate through the list backwards, unlinking files */ - for(lp = alpm_list_last(files); lp; lp = lp->prev) { + files = alpm_list_reverse(files); + for(lp = files; lp; lp = alpm_list_next(lp)) { unlink_file(info, lp, trans); /* update progress bar after each file */ |