diff options
author | Dan McGee <dan@archlinux.org> | 2007-03-05 22:13:33 +0000 |
---|---|---|
committer | Dan McGee <dan@archlinux.org> | 2007-03-05 22:13:33 +0000 |
commit | 869e81e1cf115e835040d0ecadb6108880103abe (patch) | |
tree | 2c67f7f304e27cfab2b9d7b1fd48f8b15a914dd4 /HACKING | |
parent | facb99098d8d28f7bd3ac1aeb02ab0e158f9cff2 (diff) | |
download | pacman-869e81e1cf115e835040d0ecadb6108880103abe.tar.xz |
This commit looks much more monumental than it is. Almost all just #include
reordering and adding ones that were forgotten (noticed when trying to
compile after reordering).
* Updated the HACKING file to include information on #include usage.
* print -> vprint in "making dir" function in pactest.
Diffstat (limited to 'HACKING')
-rw-r--r-- | HACKING | 34 |
1 files changed, 32 insertions, 2 deletions
@@ -1,8 +1,8 @@ Contributing to pacman ====================== -Please read 'submitting-patches' and 'translation-help' in the same directory as -this file. +Please read 'submitting-patches' and 'translation-help' in the same directory +as this file. Coding style ------------ @@ -62,4 +62,34 @@ Coding style NOT sizeof(*mylist); +Other Concerns +-------------- + +Currently our #include usage is in messy shape, but this is no reason to +continue down this messy path. When adding an include to a file, follow this +general pattern, including blank lines: + +#include "config.h" + +#include <standardheader.h> +#include <another.h> +#include <...> + +Follow this with some more headers, depending on whether the file is in libalpm +or pacman proper. For libalpm: + +/* libalpm */ +#include "yourfile.h" +#include "alpm_list.h" +#include "anythingelse.h" + +For pacman: + +#include <alpm.h> +#include <alpm_list.h> + +/* pacman */ +#include "yourfile.h" +#include "anythingelse.h" + vim: set ts=2 sw=2 et: |