diff options
| author | lolilolicon <lolilolicon@gmail.com> | 2011-09-29 03:05:03 +0800 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2011-09-28 14:09:01 -0500 |
| commit | 775b94e64903057a75071491670013975fc3ecb2 (patch) | |
| tree | 2007af54b3bd285cba2098f7b08d180bc65ba003 | |
| parent | 497501d1c751b340a115657084402bb3899396c4 (diff) | |
| download | pacman-775b94e64903057a75071491670013975fc3ecb2.tar.xz | |
pkgdelta: proper quoting in [[ expression ]]
Always quote the right-hand side of expression when the == or != operator
is used, unless intended as a pattern.
Signed-off-by: lolilolicon <lolilolicon@gmail.com>
| -rw-r--r-- | scripts/pkgdelta.sh.in | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/scripts/pkgdelta.sh.in b/scripts/pkgdelta.sh.in index a0e3ceec..ef34c5bd 100644 --- a/scripts/pkgdelta.sh.in +++ b/scripts/pkgdelta.sh.in @@ -93,17 +93,17 @@ create_xdelta() newver="$pkgver" newarch="$arch" - if [[ $oldname != $newname ]]; then + if [[ $oldname != "$newname" ]]; then error "$(gettext "The package names don't match : '%s' and '%s'")" "$oldname" "$newname" return 1 fi - if [[ $oldarch != $newarch ]]; then + if [[ $oldarch != "$newarch" ]]; then error "$(gettext "The package architectures don't match : '%s' and '%s'")" "$oldarch" "$newarch" return 1 fi - if [[ $oldver == $newver ]]; then + if [[ $oldver == "$newver" ]]; then error "$(gettext "Both packages have the same version : '%s'")" "$newver" return 1 fi |