diff options
author | Luke Shumaker <lukeshu@parabola.nu> | 2017-04-05 15:36:03 -0400 |
---|---|---|
committer | Jan Alexander Steffens (heftig) <jan.steffens@gmail.com> | 2017-04-05 22:17:51 +0200 |
commit | 578a62f1e0713b0df9722470146fb85fb819202c (patch) | |
tree | b7047b5e97d65928e310d511355bf315da3eedbe /mkarchroot.in | |
parent | 4228d79b635d1a2f448492f64eacbe83bc40e0cc (diff) | |
download | devtools32-578a62f1e0713b0df9722470146fb85fb819202c.tar.xz |
mkarchroot: Don't let the environment affect pacstrap (sans proxy settings).
A previous iteration of this change (libretools commit d7dcce53396d)
simply inserted `env -i` to clear the environment.
However, that lead to it ignoring proxy settings, which some users had
problems with:
https://labs.parabola.nu/issues/487:
> To fix other bugs, the pacstrap environment is blank, which also
> means that the proxy settings are blank.
So (in libretools commit d17d1d82349f), I changed it to use `declare
-x` to inspect the environment, and create a version of it only
consisting of variables ending with "_proxy" (case-insensitive).
I honestly don't remember what "other bugs" prompted me to clear the
environment in the first place.
Diffstat (limited to 'mkarchroot.in')
-rw-r--r-- | mkarchroot.in | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/mkarchroot.in b/mkarchroot.in index 9f365e8..3aff357 100644 --- a/mkarchroot.in +++ b/mkarchroot.in @@ -78,6 +78,11 @@ for file in "${files[@]}"; do cp "$file" "$working_dir$file" done +_env=() +while read -r varname; do + _env+=("$varname=${!varname}") +done < <(declare -x | sed -r 's/^declare -x ([^=]*)=.*/\1/' | grep -i '_proxy$') +env -i "${_env[@]}" \ pacstrap -GMcd ${pac_conf:+-C "$pac_conf"} "$working_dir" \ "${cache_dirs[@]/#/--cachedir=}" "$@" || die 'Failed to install all packages' |