diff options
| author | Dave Reisner <dreisner@archlinux.org> | 2013-07-30 15:24:48 -0400 |
|---|---|---|
| committer | Pierre Schmitz <pierre@archlinux.de> | 2013-08-08 21:28:10 +0200 |
| commit | be3c71fa81e6d35a1fae0612a8b7b4b613d7d2f6 (patch) | |
| tree | a5907bf32ccf54914ede5a355ea91137c760570e /checkpkg.in | |
| parent | fb30cabe61862f640f0e99f214dc2777a8ec1b35 (diff) | |
| download | devtools32-be3c71fa81e6d35a1fae0612a8b7b4b613d7d2f6.tar.xz | |
avoid injecting code into the format string
Now that die() properly forwards arguments to error(), we can expect
that the first arg is a format string and not the entirety of the
output.
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Signed-off-by: Pierre Schmitz <pierre@archlinux.de>
Diffstat (limited to 'checkpkg.in')
| -rw-r--r-- | checkpkg.in | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/checkpkg.in b/checkpkg.in index 95bf049..8e0f574 100644 --- a/checkpkg.in +++ b/checkpkg.in @@ -41,13 +41,13 @@ for _pkgname in "${pkgname[@]}"; do pkgurl=$(pacman -Spdd --print-format '%l' --noconfirm "$_pkgname") if [[ $? -ne 0 ]]; then - die "Couldn't download previous package for $_pkgname." + die "Couldn't download previous package for %s." "$_pkgname" fi oldpkg=${pkgurl##*://*/} if [[ ${oldpkg##*/} = ${pkgfile##*/} ]]; then - die "The built package ($_pkgname) is the one in the repo right now!" + die "The built package (%s) is the one in the repo right now!" "$_pkgname" fi if [[ ! -f $oldpkg ]]; then |