diff options
| author | Luke Shumaker <lukeshu@parabola.nu> | 2017-02-06 02:55:30 -0500 |
|---|---|---|
| committer | Luke Shumaker <lukeshu@parabola.nu> | 2017-02-06 03:10:11 -0500 |
| commit | 09bc36a930319d1287c41b78b24acfb36b0a8715 (patch) | |
| tree | b5835925ca7e38c9810c26e02f0ec5b29bea41f5 | |
| parent | 76dec8507e2e767db07f967644ed8958f85cd5a2 (diff) | |
| download | devtools32-09bc36a930319d1287c41b78b24acfb36b0a8715.tar.xz | |
lib/common.sh: add 'lock_close'; use it as appropriate.
`lock_close FD` is easier to remember than 'exec FD>&-`; and is especially
easier if FD is a variable (though that isn't actually taken advantage of
here).
This uses Bash 4.1+ `exec {var}>&-`, rather than the clunkier
`eval exec "$var>&-"` that was necessary in older versions of Bash.
Thanks to Dave Reisner for pointing this new bit of syntax out to me
the last time I submitted this (back in 2014, 4.1 had just come out).
| -rw-r--r-- | archbuild.in | 2 | ||||
| -rw-r--r-- | lib/common.sh | 8 | ||||
| -rw-r--r-- | makechrootpkg.in | 2 |
3 files changed, 10 insertions, 2 deletions
diff --git a/archbuild.in b/archbuild.in index 9c5d706..c1917c3 100644 --- a/archbuild.in +++ b/archbuild.in @@ -58,7 +58,7 @@ if ${clean_first} || [[ ! -d "${chroots}/${repo}-${arch}" ]]; then fi rm -rf --one-file-system "${copy}" done - exec 9>&- + lock_close 9 rm -rf --one-file-system "${chroots}/${repo}-${arch}" mkdir -p "${chroots}/${repo}-${arch}" diff --git a/lib/common.sh b/lib/common.sh index f6aea93..91a55dc 100644 --- a/lib/common.sh +++ b/lib/common.sh @@ -159,6 +159,14 @@ slock() { } ## +# usage : lock_close( $fd ) +## +lock_close() { + local fd=$1 + exec {fd}>&- +} + +## # usage: pkgver_equal( $pkgver1, $pkgver2 ) ## pkgver_equal() { diff --git a/makechrootpkg.in b/makechrootpkg.in index 284d444..9970145 100644 --- a/makechrootpkg.in +++ b/makechrootpkg.in @@ -103,7 +103,7 @@ create_chroot() { stat_done # Drop the read lock again - exec 8>&- + lock_close 8 fi # Update mtime |