From cbbc53e8f84067cae60c6f2e8e00682c968430a7 Mon Sep 17 00:00:00 2001 From: peter1138 Date: Sat, 12 Jan 2008 13:36:22 +0000 Subject: (svn r11817) -Codechange: Base vehicle group validity on owner, not name. --- src/group.h | 2 +- src/group_cmd.cpp | 11 +++++------ 2 files changed, 6 insertions(+), 7 deletions(-) (limited to 'src') diff --git a/src/group.h b/src/group.h index 297b02b4d..08b354b00 100644 --- a/src/group.h +++ b/src/group.h @@ -26,7 +26,7 @@ struct Group : PoolItem { bool replace_protection; ///< If set to true, the global autoreplace have no effect on the group uint16 num_engines[TOTAL_NUM_ENGINES]; ///< Caches the number of engines of each type the player owns (no need to save this) - Group(StringID str = STR_NULL); + Group(PlayerID owner = INVALID_PLAYER); virtual ~Group(); bool IsValid() const; diff --git a/src/group_cmd.cpp b/src/group_cmd.cpp index 42ac7b58b..967956b62 100644 --- a/src/group_cmd.cpp +++ b/src/group_cmd.cpp @@ -45,20 +45,20 @@ static inline void UpdateNumEngineGroup(EngineID i, GroupID old_g, GroupID new_g DEFINE_OLD_POOL_GENERIC(Group, Group) -Group::Group(StringID str) +Group::Group(PlayerID owner) { - this->string_id = str; + this->owner = owner; } Group::~Group() { DeleteName(this->string_id); - this->string_id = STR_NULL; + this->owner = INVALID_PLAYER; } bool Group::IsValid() const { - return this->string_id != STR_NULL; + return this->owner != INVALID_PLAYER; } void InitializeGroup(void) @@ -93,13 +93,12 @@ CommandCost CmdCreateGroup(TileIndex tile, uint32 flags, uint32 p1, uint32 p2) AutoPtrT g_auto_delete; - Group *g = new Group(STR_EMPTY); + Group *g = new Group(_current_player); if (g == NULL) return CMD_ERROR; g_auto_delete = g; if (flags & DC_EXEC) { - g->owner = _current_player; g->replace_protection = false; g->vehicle_type = vt; -- cgit v1.2.3-54-g00ecf